screenshot.py failure |
|||||
Issue description
On the device:
localhost ~ # /usr/local/autotest/bin/screenshot.py /var/log/screenshots/test-prefix-0.png
Traceback (most recent call last):
File "/usr/local/autotest/bin/screenshot.py", line 21, in <module>
image = crtcScreenshot(args.crtc)
File "/usr/local/autotest/cros/graphics/drm.py", line 402, in crtcScreenshot
fb = _drm.resources().getCrtc(crtc_id).fb()
File "/usr/local/autotest/cros/graphics/drm.py", line 104, in getCrtc
crtc._fd = self._fd
AttributeError: 'NoneType' object has no attribute '_fd'
Clearly we need tests to ensure this doesn't break.
Background - we use this to take screenshots when tests fail.
,
Apr 28 2016
Ah, you're right, it wasn't. Could we have a better error here? What's a good way to wake up the screen?
,
Apr 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5f4922c627d9eb895f6fcf35e1e19b090a5894a8 commit 5f4922c627d9eb895f6fcf35e1e19b090a5894a8 Author: Ilja H. Friedel <ihf@chromium.org> Date: Thu Apr 28 04:35:09 2016 autotest: make screenshot more robust. Try to wake up screen if we can't find a valid crtc and try once more. BUG= chromium:607321 TEST=/usr/local/autotest/bin/screenshot.py /tmp/test.png Change-Id: I669859bf652a8d178d240cbd20e1ac58d7007bf2 Reviewed-on: https://chromium-review.googlesource.com/341043 Commit-Ready: Ilja Friedel <ihf@chromium.org> Tested-by: Ilja Friedel <ihf@chromium.org> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> Reviewed-by: Haixia Shi <hshi@chromium.org> [modify] https://crrev.com/5f4922c627d9eb895f6fcf35e1e19b090a5894a8/client/cros/graphics/drm.py
,
Apr 29 2016
,
Apr 29 2016
Issue 476791 has been merged into this issue. Issue 496949 has been merged into this issue.
,
May 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b57c2f1bedf5f1ab0f9933ecd19caf2a412687a0 commit b57c2f1bedf5f1ab0f9933ecd19caf2a412687a0 Author: Ilja H. Friedel <ihf@chromium.org> Date: Thu Apr 28 04:35:09 2016 autotest: make screenshot more robust. Try to wake up screen if we can't find a valid crtc and try once more. BUG= chromium:607321 TEST=/usr/local/autotest/bin/screenshot.py /tmp/test.png Change-Id: I669859bf652a8d178d240cbd20e1ac58d7007bf2 Reviewed-on: https://chromium-review.googlesource.com/341043 Commit-Ready: Ilja Friedel <ihf@chromium.org> Tested-by: Ilja Friedel <ihf@chromium.org> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> Reviewed-by: Haixia Shi <hshi@chromium.org> (cherry picked from commit 5f4922c627d9eb895f6fcf35e1e19b090a5894a8) Reviewed-on: https://chromium-review.googlesource.com/342791 Reviewed-by: Ilja Friedel <ihf@chromium.org> [modify] https://crrev.com/b57c2f1bedf5f1ab0f9933ecd19caf2a412687a0/client/cros/graphics/drm.py
,
May 23 2016
Bulk verified
,
May 23 2016
bulk verified |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ihf@chromium.org
, Apr 28 2016