[Windows Host] Windows host cannot accept new connections |
|||||||||
Issue descriptionA recent change to some IPC code seems to have broken the Chromoting Host's ability to establish new connections. I've rolled back the following change and CRD works grea, re-applying break us again: 9097190cafdecfb1b5796b65c83af92e861ccaf8 https://codereview.chromium.org/1903663004/
,
Apr 28 2016
,
Apr 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d4a0c92b0079c32e777933a52b6d8eaf32d0c6e commit 3d4a0c92b0079c32e777933a52b6d8eaf32d0c6e Author: joedow <joedow@chromium.org> Date: Fri Apr 29 15:18:51 2016 Fixing an AttachmentBroker problem which broke the windows host A previous change did some cleanup in the remoting codebase however it caused a crash when we tried to spin up the desktop process: https://codereview.chromium.org/1903663004/ The issue was that the code in the ipc_utils_win file attempted to register a broker but did not check to see if one was registered first. The DesktopProcess class did register a broker, but did so after this utility function was called. BUG= 607313 Review-Url: https://codereview.chromium.org/1925263002 Cr-Commit-Position: refs/heads/master@{#390653} [modify] https://crrev.com/3d4a0c92b0079c32e777933a52b6d8eaf32d0c6e/remoting/host/desktop_process.cc [modify] https://crrev.com/3d4a0c92b0079c32e777933a52b6d8eaf32d0c6e/remoting/host/ipc_util_win.cc [modify] https://crrev.com/3d4a0c92b0079c32e777933a52b6d8eaf32d0c6e/remoting/host/remoting_me2me_host.cc [modify] https://crrev.com/3d4a0c92b0079c32e777933a52b6d8eaf32d0c6e/remoting/host/win/wts_session_process_delegate.cc
,
Apr 29 2016
,
Apr 29 2016
,
Apr 29 2016
Thanks, can you merge this to M51?
,
Apr 29 2016
I discussed this with our release manager yesterday and decided not to merge it yet. We've already snapped our release (for the CRD host for M51) and don't plan on taking any additional changes so I don't think this needs to be merged since it only touches CRD code. If we do decide we need to produce another release candidate, I will merge the change in.
,
Apr 29 2016
Ah, I see. So you're saying that my change that I merged to M51 won't affect CRD, and therefore your CL also does not need to be merged?
,
Apr 29 2016
We snapped our CRD release prior to your merge so the host we plan to release is working fine. If we need to update our release candidate from M51, then I will merge my change in.
,
May 12 2016
Marking as Won'tFix for now. If we release another M51 Host, I will reopen
,
May 18 2016
Joe, did this make it into M52? I am unable to connect to any M52 Host (quick white screen, then a disconnect, same as M51 Hosts after our release)
,
May 18 2016
I'm pretty sure this specific issue is fixed, can you open a new bug and include host logs ?
,
Jun 9 2016
Verified Fixed in 52.0.2743.33 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by joedow@chromium.org
, Apr 27 2016Labels: OS-Windows
Owner: joedow@chromium.org