New issue
Advanced search Search tips

Issue 607302 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.5%-13.7% regression in thread_times.key_idle_power_cases at 389840:389910

Project Member Reported by pmeenan@chromium.org, Apr 27 2016

Issue description

See the link to graphs below.
 
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Apr 28 2016

Cc: mlippautz@chromium.org
Owner: mlippautz@chromium.org

=== Auto-CCing suspected CL author mlippautz@chromium.org ===

Hi mlippautz@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [heap] Uncommit pooled pages concurrently
Author  : mlippautz
Commit description:
  
- Move the concurrent unmapping to MemoryAllocator
- Hide (private) members where possible
- MemoryAllocator:Free is now the bottleneck for freeing
- Pooled pages are either allocated from a set of pooled pages are obtained
  through work stealing from the concurrent unmapper

BUG= chromium:605866 , chromium:581412
LOG=N

Review URL: https://codereview.chromium.org/1913083002

Cr-Commit-Position: refs/heads/master@{#35797}
Commit  : 2158df87116906160cebc3ad20c97f454822da03
Date    : Tue Apr 26 16:45:40 2016


===== TESTED REVISIONS =====
Revision                       Mean     Std Dev     N  Good?
chromium@389839                2.54666  0.153363    5  good
chromium@389875                2.46677  0.0443964   5  good
chromium@389884                2.527    0.0832648   5  good
chromium@389884,v8@c32b202014  2.52671  0.0274548   5  good
chromium@389884,v8@af9e4c33ab  2.50632  0.054909    5  good
chromium@389884,v8@2158df8711  2.89686  0.0499559   5  bad    <--
chromium@389885                2.87705  0.0449786   5  bad
chromium@389886                2.87592  0.0272216   5  bad
chromium@389887                2.85639  0.0221906   5  bad
chromium@389889                2.88597  0.0419996   5  bad
chromium@389893                2.84658  0.00131894  5  bad
chromium@389910                2.86586  0.0274911   5  bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 607302

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.key_idle_power_cases
Test Metric: tasks_per_second_total_all/request-animation-frame.html
Relative Change: 12.53%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/122
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9014194268312787536


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5838279446888448

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: WontFix (was: Assigned)
The CL in question has already been reverted. Good to know though.

Sign in to add a comment