New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 607300 link

Starred by 2 users
Status: WontFix
Owner:
█ mfomitchev@chromium.org
inactive
Closed: Sep 2016
Cc:
rjkroege@chromium.org
sadrul@chromium.org
█ mfomitchev@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Teach sys_ui to use ScreenMus.

Project Member Reported by mfomitchev@chromium.org, Apr 27 2016 
Currently sys_ui uninstalls ScreenMus as the global screen instance in AshInit::Initialize(), and subsequently ash::DisplayManager installs ScreenAsh instead. This leads to problems (e.g. the display ids are different across processes). We need to teach ash to use ScreenMus instead.

This probably means we should
- Add some of functionality from ScreenAsh to Screen
- Have ash::DisplayManager use the installed screen instance (when it is available) instead of using ScrenAsh.

Comment 1 by mfomitchev@chromium.org, May 10 2016

Cc: rjkroege@chromium.org
Owner: mfomitchev@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05

commit 2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05
Author: msw <msw@chromium.org>
Date: Tue Sep 13 06:03:23 2016

mash: Port ash_sysui app list presenter to mojo:ash.

Move app_list_presenter_mus.* to ash/mus.
Remove mus display id workaround; cleanup.

BUG= 607300 , 616857 
TEST=Chrome --mash shows app list.
R=sky@chromium.org,mfomitchev@chromium.org

Review-Url: https://codereview.chromium.org/2335833002
Cr-Commit-Position: refs/heads/master@{#418181}

[modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/mus/BUILD.gn
[rename] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/mus/app_list_presenter_mus.cc
[rename] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/mus/app_list_presenter_mus.h
[modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/mus/manifest.json
[modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/mus/shell_delegate_mus.h
[modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/mus/window_manager.cc
[modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/sysui/BUILD.gn
[modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/sysui/manifest.json
[modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/sysui/shell_delegate_mus.h
[modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/ash/sysui/sysui_application.cc
[modify] https://crrev.com/2fbb48a8fd66453d4a9911d5f94cbc82dd9aea05/chrome/app/mojo/chrome_manifest.json

Comment 4 by mfomitchev@chromium.org, Sep 13 2016

Status: WontFix (was: Available)
The display ids are now the same for both ScreenMus and ScreenAsh. Also sys_ui is going away, and there's extensive development work by kylechar@ and rjkroege@ on Display refactoring, so closing this bug as obsolete.
►

Sign in to add a comment