New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 607298 link

Starred by 2 users
Status: Duplicate
Merged: issue 640673
Owner:
█ jialiul@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
emilyschechter@chromium.org
█ jialiul@chromium.org
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Download recovery of file:/// URLs or uncommon downloads shouldn't say "recover malware"

Project Member Reported by nparker@chromium.org, Apr 27 2016 
Repro steps, on Windows (M49 stable)
 * Go to a file URL like file:///C:/Program%20Files%20(x86)/Internet%20Explorer/
 * Click on an executable type.  
 * Download shelf will warn you the file make harm your computer.  This could be skipped for all FILE URLs since the binary is already on disk
 * Go directly to chrome://downloads, and it'll show you the warning again (fine)
 * Click "keep" and it says "Recover malware?"  It definitely shouldn't say malware.

Comment 1 by nparker@chromium.org, Apr 27 2016

Summary: Download recovery of file:/// URLs shouldn't say "recover malware" (was: Download recovery of file:/// URLs shouldn't say "malware")
Screenshots:
https://screenshot.googleplex.com/JZggHH0k7V3
https://screenshot.googleplex.com/uqyD2yFtbko
https://screenshot.googleplex.com/BU7o5dYf6Mm

Comment 2 by nparker@chromium.org, Apr 27 2016 

The behaviour is the same on M50 stable.

Comment 3 by jialiul@chromium.org, Apr 27 2016 

A couple of questions might be worth discussing:
(1) if we choose to skip all FILE urls, what is the expected behavior when use click on it? Open it?

(2) What if the file is actually on a network-mapped drive? Shall we treated it the same way as if it is on local file system?

Comment 4 by vakh@chromium.org, May 6 2016

Labels: -Pri-2 SafeBrowsing-Triaged Pri-3
Owner: jialiul@chromium.org

Comment 5 by jialiul@chromium.org, Jun 1 2016

Cc: jialiul@chromium.org
Owner: rachelis@chromium.org
Status: Available (was: Untriaged)
+rachelis@, since we might need new string in this case. 
rachelis@, could you help with this one? I can do to the coding part, but I have no idea how the localization process works if we want to add a new string.

Feel free to re-assign.

Comment 6 Deleted

Comment 7 by jialiul@chromium.org, Jun 1 2016

Summary: Download recovery of file:/// URLs or uncommon downloads shouldn't say "recover malware" (was: Download recovery of file:/// URLs shouldn't say "recover malware")

Comment 8 by jialiul@chromium.org, Jun 2 2016

Cc: rachelis@chromium.org
Owner: jialiul@chromium.org
Extend the scope of this bug to uncommon downloads. Currently, when users try to recover a uncommon download, they will see "Recover Malware?" warning. It is inconsistent with its actual danger type. 

Screenshot:   https://screenshot.googleplex.com/8gpzgNvaeXN.png

By using existing strings, we can do something like: 
https://screenshot.googleplex.com/VNJ3MFCcUS7.png


For File:// url downloads, in the short term we might want to fix warning string to something like 
"Confirm Download
This file maybe harmful to your computer."

Ultimately we should probably disable downloading File:// URL downloads.  

rachelis@, what do you think?

Comment 9 by jialiul@chromium.org, Jun 8 2016

Cc: -rachelis@chromium.org emilyschechter@chromium.org
A better organized doc can be found at go/fix_download_recovery

+emilyschechter@, could you help us find another available UI expert?

Comment 10 by jialiul@chromium.org, Jun 8 2016

Labels: Hotlist-User-Journey-StreamingWebsites

Comment 11 by emilyschechter@chromium.org, Jun 10 2016 

Yep! We chatted and came up with some new strings, and hoping to get a thumbs up from UI.

Comment 12 by jialiul@chromium.org, Jun 29 2016

Labels: hotlist-download-protection-UI

Comment 13 by jialiul@chromium.org, Aug 24 2016

Mergedinto: 640673
Status: Duplicate (was: Available)
►

Sign in to add a comment