New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 607287 link

Starred by 1 user
Status: Fixed
Owner:
█ maxbogue@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
s...@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

LocalDeviceInfoProvider provides out of date information after sync shutdown

Project Member Reported by maxbogue@chromium.org, Apr 27 2016 
Between the ::Initialize and ::InitializeContinuation calls, ::GetLocalDeviceInfo returns out of date information:

https://code.google.com/p/chromium/codesearch#chromium/src/components/sync_driver/local_device_info_provider_impl.cc&l=83

We probably just want to nuke the local DeviceInfo object whenever PSS::ShutdownImpl(CLEAR_DATA) is called.

Note that this was noticed due to iOS tests: http://crbug.com/592875. If it affects real users, it would be extremely rare, as it requires an access during a very small timeframe after signing out and back in.
Project Member

Comment 1 by bugdroid1@chromium.org, May 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/931c0e91a7501df49fb488d978e64e1632cef37a

commit 931c0e91a7501df49fb488d978e64e1632cef37a
Author: maxbogue <maxbogue@chromium.org>
Date: Thu May 05 02:05:53 2016

[Sync] Clear LocalDeviceInfoProvider cache on sync DB destruction.

Previously this cache would continue returning the old cache GUID and
DeviceInfo, which are no longer valid after directory destruction.

BUG= 607287 

Review-Url: https://codereview.chromium.org/1951703002
Cr-Commit-Position: refs/heads/master@{#391729}

[modify] https://crrev.com/931c0e91a7501df49fb488d978e64e1632cef37a/components/browser_sync/browser/profile_sync_service.cc
[modify] https://crrev.com/931c0e91a7501df49fb488d978e64e1632cef37a/components/browser_sync/browser/profile_sync_service_unittest.cc
[modify] https://crrev.com/931c0e91a7501df49fb488d978e64e1632cef37a/components/sync_driver/local_device_info_provider.h
[modify] https://crrev.com/931c0e91a7501df49fb488d978e64e1632cef37a/components/sync_driver/local_device_info_provider_impl.cc
[modify] https://crrev.com/931c0e91a7501df49fb488d978e64e1632cef37a/components/sync_driver/local_device_info_provider_impl.h
[modify] https://crrev.com/931c0e91a7501df49fb488d978e64e1632cef37a/components/sync_driver/local_device_info_provider_mock.cc
[modify] https://crrev.com/931c0e91a7501df49fb488d978e64e1632cef37a/components/sync_driver/local_device_info_provider_mock.h
[modify] https://crrev.com/931c0e91a7501df49fb488d978e64e1632cef37a/components/sync_driver/local_device_info_provider_unittest.cc

Comment 2 by maxbogue@chromium.org, May 5 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment