Push ninja 1.7.1 to depot_tools |
|||||||||||||||||
Issue description
Rough steps:
git fetch upstream --tags
git checkout v1.7.0
CXX=/Users/thakis/src/chrome/src/third_party/llvm-build/Release+Asserts/bin/clang++ \
./configure.py
# (mac only: edit generated ninja.build to add -mmacosx-version-min=10.6 -stdlib=libstdc++ to cflags and ldflags,
# also add -L$$(xcrun --show-sdk-path)/usr/lib to ldflags)
ninja
./ninja ninja_test
./ninja_test
strip ninja
Note to self: don't forget to update the shell script too.
leiz, can you attach linux binaries again? Make sure `./ninja --version` says "1.7.0" yadda yadda. (I think the last time you made sure they run on pre-precise or something ancient.)
Linux 32 bit version needs -D_FILE_OFFSET_BITS=64 ( http://src.chromium.org/viewvc/chrome?revision=243436&view=revision … ), and they should maybe not require GLIBC_2.14 ( http://src.chromium.org/viewvc/chrome?revision=225756&view=revision )
Scott, I'll do Windows this time, cc'ing you just FYI. I'll build ninja.exe with clang-cl this time unless you know why this is a bad idea -- the ninja.exe produced by it is like 25% faster than the one that MSVC produces.
I'll do the mac binary too.
Like issue 505508 , but 1.7.0
1.7.0 changes that are relevant to chromium (pasting from my in-progress release notes):
+ `-w dupbuild=err` now works in subninjas (#1095)
+ Clean up build on SIGHUP (#964)
+ subprocesses are now spawned via posix_spawn instead of fork/exec, which
speeds up builds on some systems (e.g Mac OS X) (#1118)
+ child processes no longer detached from terminal, restoring 1.5.0 behavior
(#1113)
+ experimentally expose deps=msvc on non-Windows too (#1125)
* Output formatting changes
+ in non-interactive mode, print commands when finished, not when started
(#999)
+ output on failing command different (#1033)
,
Apr 27 2016
Hm, it looks like 32-bit ninja.exe's are slower (1.59s vs 1.4s with clang-cl, 1.6s vs 1.56s with VS2013 for empty builds of 'chrome'). Maybe we want to switch to a 64-bit ninja.exe?
,
Apr 27 2016
OK, there were a few bots that still needed x86 but I think they're likely gone with XP now. (Did you try VS2015 vs. clang-cl?)
,
Apr 27 2016
Mac binary.
The 10.11 SDK can't target 10.6 anymore, so built with the 10.10 SDK. Seems a bit faster than ninja 1.6.0 even.
thakis-macpro:ninja thakis$ CFLAGS="-isysroot$(xcrun --sdk macosx10.10 -show-sdk-path) -mmacosx-version-min=10.6 -stdlib=libstdc++" LDFLAGS="-isysroot$(xcrun --sdk macosx10.10 -show-sdk-path) -mmacosx-version-min=10.6 -stdlib=libstdc++" CXX=$HOME/src/chrome/src/third_party/llvm-build/Release+Asserts/bin/clang++ ./configure.py
warning: A compatible version of re2c (>= 0.11.3) was not found; changes to src/*.in.cc will not affect your build.
wrote build.ninja.
thakis-macpro:ninja thakis$ ninja
[25/25] LINK ninja
thakis-macpro:ninja thakis$ ./ninja all
[27/27] LINK ninja_test
thakis-macpro:ninja thakis$ ./ninja_test
[221/221] ElideMiddle.ElideInTheMiddle
passed
thakis-macpro:ninja thakis$ otool -l ninja | grep VERSION_MIN -A 4
cmd LC_VERSION_MIN_MACOSX
cmdsize 16
version 10.6
sdk 10.10
Load command 10
thakis-macpro:ninja thakis$ strip ninja
thakis-macpro:ninja thakis$ otool -L ninja
ninja:
/usr/lib/libstdc++.6.dylib (compatibility version 7.0.0, current version 104.1.0)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1213.0.0)
thakis-macpro:ninja thakis$ ./ninja --version
1.7.0
thakis-macpro:ninja thakis$ ls -l ninja
-rwxr-xr-x 1 thakis eng 176588 Apr 27 13:02 ninja
A bit larger than last time (not that much), but it shrinks by 20kB when targeting 10.11 with the 10.11 SDK. Maybe we should stop targeting 10.6 eventually.
,
Apr 27 2016
I hadn't tried 2015. I just did. With 2015 cl.exe, ninja.exe (64-bit) is 502kB and takes about 1.42s for empty builds of 'chrome'. clang-cl with the 2015 SDK produces a 471kB binary that takes about 1.4s. clang-cl with the 2013 SDK is 396kB @ 1.4s, cl.exe 2013 is 404kB @ 1.5s. Current depot_tools (1.6, 32-bit) is 130kB @ 1.75s.
,
Apr 27 2016
Windows binary (64-bit, built with clang-cl)
C:\src\ninja>ninja.bootstrap.exe
[26/28] CXX build\minidump-win32.obj
src\minidump-win32.cc(38,22) : warning: format specifies type 'int' but the argument has type 'DWORD' (aka 'unsigned lo
ng') [-Wformat]
temp_path, GetCurrentProcessId());
^~~~~~~~~~~~~~~~~~~~~
1 warning generated.
[26/28] CXX build\disk_interface.obj
src\disk_interface.cc(88,55) : warning: missing field 'dwMajorVersion' initializer [-Wmissing-field-initializers]
OSVERSIONINFO version_info = { sizeof(version_info) };
^
src\disk_interface.cc(89,8) : warning: 'GetVersionExA' is deprecated [-Wdeprecated-declarations]
if (!GetVersionEx(&version_info))
^
C:\Program Files (x86)\Windows Kits\8.1\include\um\sysinfoapi.h(449,23) : note: expanded from macro 'GetVersionEx'
#define GetVersionEx GetVersionExA
^
C:\Program Files (x86)\Windows Kits\8.1\include\um\sysinfoapi.h(433,1) : note: 'GetVersionExA' has been explicitly mark
ed deprecated here
GetVersionExA(
^
2 warnings generated.
[28/28] LINK ninja.exe
LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor
mance
C:\src\ninja>ninja --version
1.7.0
C:\src\ninja>ninja all
[26/29] LINK canon_perftest.exe
LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor
mance
[26/29] LINK depfile_parser_perftest.exe
LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor
mance
[26/29] LINK hash_collision_bench.exe
LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor
mance
[27/29] LINK build_log_perftest.exe
LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor
mance
[28/29] LINK manifest_parser_perftest.exe
LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor
mance
[29/29] LINK ninja_test.exe
LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor
mance
C:\src\ninja>ninja_test
to stderr MSVCHelperTest.NoReadOfStderr
passed
,
Apr 27 2016
32-bit ninja.exe if we should need it (also clang-cl)
,
Apr 27 2016
,
Apr 27 2016
Just repeating the steps from bug 505508 with a few minor adjustments. Binary size increased by 8 KB. $ git clone git://github.com/ninja-build/ninja.git && cd ninja $ git checkout v1.7.0 $ /path/to/chrome/src/third_party/llvm-build/Release+Asserts/bin/clang++ --version clang version 3.9.0 (trunk 267383) Target: x86_64-unknown-linux-gnu Thread model: posix $ cat /path/to/chrome/src/chrome/build/linux/debian_wheezy_amd64-sysroot/.stamp https://commondatastorage.googleapis.com/chrome-linux-sysroot/toolchain/c52471d9dec240c8d0a88fa98aa1eefeee32e22f/debian_wheezy_amd64_sysroot.tgz $ CXX="/path/to/chrome/src/third_party/llvm-build/Release+Asserts/bin/clang++" CXXFLAGS="--sysroot=/path/to/chrome/src/chrome/build/linux/debian_wheezy_amd64-sysroot" LDFLAGS="--sysroot=/path/to/chrome/src/chrome/build/linux/debian_wheezy_amd64-sysroot" ./configure.py $ ninja $ ./ninja ninja_test $ ./ninja_test $ strip ninja $ objdump -x ninja|grep GLIBC 0x0d696914 0x00 05 GLIBC_2.4 0x09691a75 0x00 03 GLIBC_2.2.5 0x08922974 0x00 02 GLIBCXX_3.4 $ mv ninja ninja-linux64
,
Apr 27 2016
Err, /path/to/chrome/src/chrome/build/linux should be /path/to/chrome/src/build/linux
,
Apr 27 2016
$ git clone git://github.com/ninja-build/ninja.git && cd ninja $ git checkout v1.7.0 $ /path/to/chrome/src/third_party/llvm-build/Release+Asserts/bin/clang++ --version clang version 3.9.0 (trunk 267383) Target: x86_64-unknown-linux-gnu Thread model: posix $ cat /path/to/chrome/src/build/linux/debian_wheezy_i386-sysroot/.stamp https://commondatastorage.googleapis.com/chrome-linux-sysroot/toolchain/c52471d9dec240c8d0a88fa98aa1eefeee32e22f/debian_wheezy_i386_sysroot.tgz $ CXX="/path/to/chrome/src/third_party/llvm-build/Release+Asserts/bin/clang++" CFLAGS="-m32 -D_FILE_OFFSET_BITS=64 --sysroot=/path/to/chrome/src/build/linux/debian_wheezy_i386-sysroot" CXXFLAGS="-m32 -D_FILE_OFFSET_BITS=64 --sysroot=/path/to/chrome/src/build/linux/debian_wheezy_i386-sysroot" LDFLAGS="--sysroot=/path/to/chrome/src/build/linux/debian_wheezy_i386-sysroot -m32 -L/path/to/chrome/src/build/linux/debian_wheezy_i386-sysroot/usr/lib/i386-linux-gnu -Wl,-rpath-link=/path/to/chrome/src/build/linux/debian_wheezy_i386-sysroot/usr/lib/i386-linux-gnu" ./configure.py $ ninja $ ./ninja ninja_test $ ./ninja_test $ strip ninja $ objdump -x ninja|grep GLIBC 0x0d696910 0x00 06 GLIBC_2.0 0x08922974 0x00 03 GLIBCXX_3.4 0x0d696914 0x00 09 GLIBC_2.4 0x0d696911 0x00 08 GLIBC_2.1 0x09691f73 0x00 05 GLIBC_2.1.3 0x0d696912 0x00 04 GLIBC_2.2 0x0d696910 0x00 02 GLIBC_2.0 $ mv ninja ninja-linux32
,
Apr 27 2016
ninja-linux32 | Bin 145284 -> 153512 bytes ninja-linux64 | Bin 166960 -> 175224 bytes ninja-mac | Bin 171356 -> 176588 bytes ninja.exe | Bin 310272 -> 396800 bytes
,
Apr 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/2b6ed98e7d60dea33e1e39970230ce4e1b63d782 commit 2b6ed98e7d60dea33e1e39970230ce4e1b63d782 Author: thakis@chromium.org <thakis@chromium.org> Date: Wed Apr 27 23:13:47 2016 Update ninja to v1.7.0 on Mac, Linux32, Linux64, Windows. See the bug for how these were built. See the bug comment 0 also for what's new in this version. The linux binaries were built by thestig@chromium.org. The windows and mac binaries were built by thakis@chromium.org. The Windows binary is now 64-bit instead of 32-bit. BUG= 607268 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1919773006 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300251 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/2b6ed98e7d60dea33e1e39970230ce4e1b63d782/ninja-linux32 [modify] https://crrev.com/2b6ed98e7d60dea33e1e39970230ce4e1b63d782/ninja-linux64 [modify] https://crrev.com/2b6ed98e7d60dea33e1e39970230ce4e1b63d782/ninja-mac [modify] https://crrev.com/2b6ed98e7d60dea33e1e39970230ce4e1b63d782/ninja.exe
,
Apr 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/6b178372ad4a474bc0e2da1c526cbba2f0ec9eaa commit 6b178372ad4a474bc0e2da1c526cbba2f0ec9eaa Author: recipe-roller@chromium.org <recipe-roller@chromium.org> Date: Wed Apr 27 23:26:26 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/2b6ed98e7d60dea33e1e39970230ce4e1b63d782 Update ninja to v1.7.0 on Mac, Linux32, Linux64, Windows. (thakis@chromium.org) R=thakis@chromium.org,scottmg@chromium.org BUG= 607268 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/1930713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300252 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/6b178372ad4a474bc0e2da1c526cbba2f0ec9eaa/infra/config/recipes.cfg
,
Apr 28 2016
Fallout so far (cosmetic, but ugly enough that I want to do a 1.7.1 for it tomorrow): https://github.com/ninja-build/ninja/issues/1142
,
Apr 28 2016
thakis-macpro:ninja thakis$ CFLAGS="-isysroot$(xcrun --sdk macosx10.10 -show-sdk-path) -mmacosx-version-min=10.6 -stdlib=libstdc++" LDFLAGS="-isysroot$(xcrun --sdk macosx10.10 -show-sdk-path) -mmacosx-version-min=10.6 -stdlib=libstdc++" CXX=$HOME/src/chrome/src/third_party/llvm-build/Release+Asserts/bin/clang++ ./configure.py
warning: A compatible version of re2c (>= 0.11.3) was not found; changes to src/*.in.cc will not affect your build.
wrote build.ninja.
thakis-macpro:ninja thakis$ ninja
[4/4] LINK ninja
thakis-macpro:ninja thakis$ ./ninja all
[6/6] LINK ninja_test
thakis-macpro:ninja thakis$ ./ninja_test
[221/221] ElideMiddle.ElideInTheMiddle
passed
thakis-macpro:ninja thakis$ otool -l ninja | grep VERSION_MIN -A 4
cmd LC_VERSION_MIN_MACOSX
cmdsize 16
version 10.6
sdk 10.10
Load command 10
thakis-macpro:ninja thakis$ otool -L ninja
ninja:
/usr/lib/libstdc++.6.dylib (compatibility version 7.0.0, current version 104.1.0)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1213.0.0)
thakis-macpro:ninja thakis$ strip ninja
thakis-macpro:ninja thakis$ cp ninja ninja-mac
thakis-macpro:ninja thakis$ ls -l ninja
-rwxr-xr-x 1 thakis eng 176588 Apr 28 08:06 ninja
thakis-macpro:ninja thakis$ ./ninja --version
1.7.1
,
Apr 28 2016
(64-bit again) C:\src\ninja>git fetch -a upstream remote: Counting objects: 25, done. remote: Compressing objects: 100% (25/25), done. remote: Total 25 (delta 11), reused 0 (delta 0), pack-reused 0 Unpacking objects: 100% (25/25), done. From https://github.com/ninja-build/ninja 06b0e56..644f6b1 master -> upstream/master a60702e..b49b0fc release -> upstream/release * [new tag] v1.7.1 -> v1.7.1 C:\src\ninja>git checkout v1.7.1 Previous HEAD position was a60702e... v1.7.0 HEAD is now at b49b0fc... v1.7.1 C:\src\ninja>ninja.bootstrap.exe [26/28] CXX build\minidump-win32.obj src\minidump-win32.cc(38,22) : warning: format specifies type 'int' but the argument has type 'DWORD' (aka 'unsigned lo ng') [-Wformat] temp_path, GetCurrentProcessId()); ^~~~~~~~~~~~~~~~~~~~~ 1 warning generated. [26/28] CXX build\disk_interface.obj src\disk_interface.cc(88,55) : warning: missing field 'dwMajorVersion' initializer [-Wmissing-field-initializers] OSVERSIONINFO version_info = { sizeof(version_info) }; ^ src\disk_interface.cc(89,8) : warning: 'GetVersionExA' is deprecated [-Wdeprecated-declarations] if (!GetVersionEx(&version_info)) ^ C:\Program Files (x86)\Windows Kits\8.1\include\um\sysinfoapi.h(449,23) : note: expanded from macro 'GetVersionEx' #define GetVersionEx GetVersionExA ^ C:\Program Files (x86)\Windows Kits\8.1\include\um\sysinfoapi.h(433,1) : note: 'GetVersionExA' has been explicitly mark ed deprecated here GetVersionExA( ^ 2 warnings generated. [28/28] LINK ninja.exe LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor mance C:\src\ninja>ninja --version 1.7.1 C:\src\ninja>ninja all [8/29] LINK depfile_parser_perftest.exe LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor mance [9/29] LINK canon_perftest.exe LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor mance [13/29] LINK hash_collision_bench.exe LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor mance [19/29] LINK build_log_perftest.exe LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor mance [24/29] LINK manifest_parser_perftest.exe LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor mance [29/29] LINK ninja_test.exe LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker perfor mance C:\src\ninja>ninja_test to stderr MSVCHelperTest.NoReadOfStderr passed
,
Apr 28 2016
thakis@thakis:~/src/ninja-upstream$ CXX="$HOME/src/chrome/src/third_party/llvm-build/Release+Asserts/bin/clang++" CFLAGS="--sysroot=$HOME/src/chrome/src/build/linux/debian_wheezy_amd64-sysroot" LDFLAGS="--sysroot=$HOME/src/chrome/src/build/linux/debian_wheezy_amd64-sysroot" ./configure.py
warning: A compatible version of re2c (>= 0.11.3) was not found; changes to src/*.in.cc will not affect your build.
wrote build.ninja.
thakis@thakis:~/src/ninja-upstream$ ninja
[24/24] LINK ninja
thakis@thakis:~/src/ninja-upstream$ ./ninja all
[27/27] LINK ninja_test
thakis@thakis:~/src/ninja-upstream$ ./ninja_test
[222/222] ElideMiddle.ElideInTheMiddle
passed
thakis@thakis:~/src/ninja-upstream$ strip ninja
thakis@thakis:~/src/ninja-upstream$ ./ninja --version
1.7.1
thakis@thakis:~/src/ninja-upstream$ objdump -x ninja | grep GLIBC
0x0d696914 0x00 05 GLIBC_2.4
0x09691a75 0x00 03 GLIBC_2.2.5
0x08922974 0x00 02 GLIBCXX_3.4
thakis@thakis:~/src/ninja-upstream$ mv ninja ninja-linux64
,
Apr 28 2016
thakis@thakis:~/src/ninja-upstream$ CXX="$HOME/src/chrome/src/third_party/llvm-build/Release+Asserts/bin/clang++" CFLAGS="-m32 -D_FILE_OFFSET_BITS=64 --sysroot=$HOME/src/chrome/src/build/linux/debian_wheezy_i386-sysroot" LDFLAGS="--sysroot=$HOME/src/chrome/src/build/linux/debian_wheezy_i386-sysroot -m32 -L$HOME/src/chrome/src/build/linux/debian_wheezy_i386-sysroot/usr/lib/i386-linux-gnu -Wl,-rpath-link=$HOME/src/chrome/src/build/linux/debian_wheezy_i386-sysroot/usr/lib/i386-linux-gnu" ./configure.py
warning: A compatible version of re2c (>= 0.11.3) was not found; changes to src/*.in.cc will not affect your build.
wrote build.ninja.
thakis@thakis:~/src/ninja-upstream$ ninja
[24/24] LINK ninja
thakis@thakis:~/src/ninja-upstream$ ./ninja all
[15/27] CXX build/subprocess_test.o
src/subprocess_test.cc:230:23: warning: format specifies type 'unsigned long' but the argument has type 'rlim_t' (aka 'unsigned long long') [-Wformat]
kNumProcs, rlim.rlim_cur);
^~~~~~~~~~~~~
1 warning generated.
[27/27] LINK ninja_test
thakis@thakis:~/src/ninja-upstream$ ./ninja_test
[222/222] ElideMiddle.ElideInTheMiddle
passed
thakis@thakis:~/src/ninja-upstream$ ./ninja --version
1.7.1
thakis@thakis:~/src/ninja-upstream$ strip ninja
thakis@thakis:~/src/ninja-upstream$ objdump -x ninja | grep GLIBC
0x0d696910 0x00 06 GLIBC_2.0
0x08922974 0x00 03 GLIBCXX_3.4
0x0d696914 0x00 09 GLIBC_2.4
0x0d696911 0x00 08 GLIBC_2.1
0x09691f73 0x00 05 GLIBC_2.1.3
0x0d696912 0x00 04 GLIBC_2.2
0x0d696910 0x00 02 GLIBC_2.0
thakis@thakis:~/src/ninja-upstream$ file ninja
ninja: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.26, BuildID[sha1]=f7c32a5ef63a469d8db0580498d26e70f82c2e5f, stripped
thakis@thakis:~/src/ninja-upstream$ mv ninja ninja-linux32
,
Apr 28 2016
ninja-linux32 | Bin 153512 -> 153512 bytes ninja-linux64 | Bin 175224 -> 175240 bytes ninja-mac | Bin 176588 -> 176588 bytes ninja.exe | Bin 396800 -> 396800 bytes
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/ce4d6c0224b115991b3c3a58530593f9bff8cbd1 commit ce4d6c0224b115991b3c3a58530593f9bff8cbd1 Author: thakis@chromium.org <thakis@chromium.org> Date: Thu Apr 28 15:38:59 2016 Update ninja to v1.7.1 on Mac, Linux32, Linux64, Windows. See the bug for how these were built (comment 16 onwards). See the bug comment 0 also for what's new in this version. All binaries built by thakis@chromium.org. The Windows binary is now (as of 1.7.x) 64-bit instead of 32-bit. BUG= 607268 TBR=scottmg@chromium.org Review URL: https://codereview.chromium.org/1925133002 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300281 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/ce4d6c0224b115991b3c3a58530593f9bff8cbd1/ninja-linux32 [modify] https://crrev.com/ce4d6c0224b115991b3c3a58530593f9bff8cbd1/ninja-linux64 [modify] https://crrev.com/ce4d6c0224b115991b3c3a58530593f9bff8cbd1/ninja-mac [modify] https://crrev.com/ce4d6c0224b115991b3c3a58530593f9bff8cbd1/ninja.exe
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/eff593033fc2006156b27427db29a31540ead25c commit eff593033fc2006156b27427db29a31540ead25c Author: recipe-roller@chromium.org <recipe-roller@chromium.org> Date: Thu Apr 28 15:45:33 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/ce4d6c0224b115991b3c3a58530593f9bff8cbd1 Update ninja to v1.7.1 on Mac, Linux32, Linux64, Windows. (thakis@chromium.org) R=thakis@chromium.org,scottmg@chromium.org BUG= 607268 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/1927133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300282 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/eff593033fc2006156b27427db29a31540ead25c/infra/config/recipes.cfg
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/121126fec502eb5cd49da1ce87a189c50243ddcf commit 121126fec502eb5cd49da1ce87a189c50243ddcf Author: thakis@chromium.org <thakis@chromium.org> Date: Thu Apr 28 15:48:25 2016 Update ninja version in shell script too. BUG= 607268 TBR=scottmg@chromium.org Review URL: https://codereview.chromium.org/1924033004 . git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300283 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/121126fec502eb5cd49da1ce87a189c50243ddcf/ninja
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/9b439641e34af2367f7ab657d9c6d7800c50ea1a commit 9b439641e34af2367f7ab657d9c6d7800c50ea1a Author: recipe-roller@chromium.org <recipe-roller@chromium.org> Date: Thu Apr 28 15:56:59 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/121126fec502eb5cd49da1ce87a189c50243ddcf Update ninja version in shell script too. (thakis@chromium.org) R=thakis@chromium.org,scottmg@chromium.org BUG= 607268 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/1923393004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@300284 0039d316-1c4b-4281-b951-d872f2087c98 [modify] https://crrev.com/9b439641e34af2367f7ab657d9c6d7800c50ea1a/infra/config/recipes.cfg
,
Apr 28 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=87161 ------------------------------------------------------------------ r87161 | recipe-roller@chromium.org | 2016-04-28T16:03:15.731759Z -----------------------------------------------------------------
,
Apr 28 2016
,
Apr 28 2016
|
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by scottmg@chromium.org
, Apr 27 2016