New issue
Advanced search Search tips

Issue 607259 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Update Chromium/Blink to request oblique from Skia.

Project Member Reported by bunge...@chromium.org, Apr 27 2016

Issue description

Skia is adding SkFontStyle::Slant::kOblique_Slant to handle font families with both italic and oblique faces. Use this value in Chromium and Blink.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ad9fb9ca0cd95da8fe4701f19fae02311b9a2c8

commit 2ad9fb9ca0cd95da8fe4701f19fae02311b9a2c8
Author: bungeman <bungeman@chromium.org>
Date: Wed Apr 27 21:18:47 2016

Update font_service to understand 'oblique'.

Skia is adding 'oblique' to SkFontStyle::Slant to handle font families
with both italic and oblique faces. This allows the font_service to
forward this value.

BUG= chromium:607259 

Review-Url: https://codereview.chromium.org/1922153004
Cr-Commit-Position: refs/heads/master@{#390189}

[modify] https://crrev.com/2ad9fb9ca0cd95da8fe4701f19fae02311b9a2c8/components/font_service/font_service_app.cc
[modify] https://crrev.com/2ad9fb9ca0cd95da8fe4701f19fae02311b9a2c8/components/font_service/public/interfaces/font_service.mojom

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ce9625c1dcda455519be1030dd941e9ba535000

commit 8ce9625c1dcda455519be1030dd941e9ba535000
Author: bungeman <bungeman@chromium.org>
Date: Thu Apr 28 15:12:02 2016

Rebaseline "Request oblique from Skia in Blink."

This is a semi-manual roll due to the rebaseline bot being disabled.
This is a set of rebaselines for https://crrev.com/1927733002/ which
landed as https://chromium.googlesource.com/chromium/src/+/2c55324f0fc2
refs/heads/master@{#390268} .

NOTRY=true
The win_blink_rel trybot was geen.

TBR=eae@chromium.org
This is a rebaseline and we've already looked at these.

BUG= chromium:607259 

Review-Url: https://codereview.chromium.org/1926053002
Cr-Commit-Position: refs/heads/master@{#390383}

[modify] https://crrev.com/8ce9625c1dcda455519be1030dd941e9ba535000/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8ce9625c1dcda455519be1030dd941e9ba535000/third_party/WebKit/LayoutTests/platform/win/css1/font_properties/font_style-expected.png
[modify] https://crrev.com/8ce9625c1dcda455519be1030dd941e9ba535000/third_party/WebKit/LayoutTests/platform/win/css2.1/t1504-c523-font-style-00-b-expected.png
[modify] https://crrev.com/8ce9625c1dcda455519be1030dd941e9ba535000/third_party/WebKit/LayoutTests/platform/win/css2.1/t1508-c527-font-08-b-expected.png
[modify] https://crrev.com/8ce9625c1dcda455519be1030dd941e9ba535000/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textStyles-expected.png
[modify] https://crrev.com/8ce9625c1dcda455519be1030dd941e9ba535000/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textStyles-expected.txt

Status: Fixed (was: Started)

Sign in to add a comment