Toolbar does not autohide when scrolled using keyboard
Reported by
jahag...@amazon.com,
Apr 27 2016
|
|||||
Issue descriptionSteps to reproduce the problem: 1. Use a device that auto hides the toolbar (url bar) 2. Scroll a page using touch gesture and observe that it autohides. 3. Scroll a page using keyboard and observe. What is the expected behavior? Toolbar should auto hide even if we scroll using keyboard What went wrong? Toolbar doesn't autohide when scrolled using keyboard or bluetooth mouse Did this work before? No Chrome version: Chrome Android 49.0.2623.105 Channel: stable OS Version: Android 5.1.1 Flash Version:
,
Dec 16 2016
aelias@ I don't really know the clank code that does this can you re-route this issue as appropriate?
,
Dec 16 2016
,
Jan 12 2017
This behavior is intentional though maybe we want to change it? On the main thread, ViewportScrollCallback::shouldScrollBrowserControls returns false if the scroll is not of Pixel or PrecisePixel granularity which is only true for touch and high precision touchpads. Similarly, in CC, from LayerTreeHostImpl::ApplyScroll we call viewport()->ScrollBy which passes scroll_state->is_direct_manipulation() for affect_browser_controls. I think changing those two places should make all gesture scrolls affect top controls. That said, keyboard doesn't use gestures so we'd need some additional work. Keyboards (always on main thread) scroll through ScrollManager::logicalScroll and ScrollManager::bubblingScroll
,
Jan 12 2017
I think we should aim to make all root-layer scrolls affect the top controls, yeah.
,
Mar 3 2017
Seems related to this bug 681312
,
May 31 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rsgav...@chromium.org
, Dec 16 2016Components: IO>Keyboard
Owner: dtapu...@chromium.org
Status: Assigned (was: Unconfirmed)