New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607241 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature

Blocked on:
issue 368775
issue 646148

Blocking:
issue 370522
issue 683347



Sign in to add a comment

YUV Overlay Plane support in Chrome OS systems

Project Member Reported by za...@chromium.org, Apr 27 2016

Issue description

Systems support in this case refers to 3 parts;
1) kernel drm drivers
2) minigbm and other system libraries
3) drm-tests and autotests
 

Comment 1 by za...@chromium.org, Apr 27 2016

Blockedon: 368775
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/drm-tests/+/1fafce87c75ebe003d556978e094ac965881f796

commit 1fafce87c75ebe003d556978e094ac965881f796
Author: Zach Reizner <zachr@google.com>
Date: Fri Apr 15 00:36:30 2016

drm-tests: refactor nv12_test to use bsdrm and planes

This test used to use the atrocious "sp" library. This CL removes that
dependency by using bsdrm, gbm, and its own drawing code. In particular,
the usage of gbm and bsdrm enhance this test because gbm uses hardware
specific knowledge to generate properly aligned buffer objects, and
bsdrm will automatically make proper framebuffers out of them.

In addition, this test transitions to using an overlay plane to output a
NV12 surface. The hardware that was used to test this change only
supports the NV12 on planes.

BUG=chromium:587632, chromium:607241 
TEST=nv12_test on daisy on kernel patched with "NV12 FIMD overlays via GSC"

Change-Id: I7725aa0235a9aa5b14f50b699b0ee559b654ebd5
Reviewed-on: https://chromium-review.googlesource.com/339070
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Haixia Shi <hshi@chromium.org>

[modify] https://crrev.com/1fafce87c75ebe003d556978e094ac965881f796/Makefile
[modify] https://crrev.com/1fafce87c75ebe003d556978e094ac965881f796/nv12_test.c

Project Member

Comment 3 by bugdroid1@chromium.org, May 11 2016

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/2c1903a2023803958542a2aae1897bc48fcd3a4f

commit 2c1903a2023803958542a2aae1897bc48fcd3a4f
Author: Zach Reizner <zachr@google.com>
Date: Fri May 06 22:12:29 2016

CHROMIUM: drm/rockchip: enable plane scaling

The VOP can handle scaling up or down by up to a factor of 8. Sadly, it
does not seem to handle vertical scale down factors near 2, 4, or 8.
This CL includes a workaround to slightly reduce the src height to
ensure the degenerate case is avoided.

TEST=plane_test
BUG= chromium:607241 

Change-Id: I9d116a69bcb0d202a72a6ea1b068a767865ad108
Signed-off-by: Zach Reizner <zachr@google.com>
Reviewed-on: https://chromium-review.googlesource.com/343200
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[modify] https://crrev.com/2c1903a2023803958542a2aae1897bc48fcd3a4f/drivers/gpu/drm/rockchip/rockchip_drm_vop.c

Project Member

Comment 4 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/minigbm/+/58080dfa64598d295494d03a3b6332e351326f57

commit 58080dfa64598d295494d03a3b6332e351326f57
Author: Zach Reizner <zachr@google.com>
Date: Wed Apr 27 18:14:41 2016

rockchip: add NV12 bo creation support

This patch does alignment if needed on the width and height, but does
not expose this change to the public facing gbm_bo. It is expected that
framebuffer creation in the kernel with do alignment such that
applications don't have to have platform specific knowledge of alignment
requirements.

TEST=nv12_test
BUG= chromium:607241 

Change-Id: I6138afb56537f516fac038ff4db39593c623fccd
Reviewed-on: https://chromium-review.googlesource.com/341010
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/58080dfa64598d295494d03a3b6332e351326f57/rockchip.c

Project Member

Comment 5 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e964f9c9feb8a170a015ace54156152530db6178

commit e964f9c9feb8a170a015ace54156152530db6178
Author: Zach Reizner <zachr@google.com>
Date: Thu Apr 28 23:57:19 2016

drm-tests: add plane_test

TEST=plane_test
BUG= chromium:607241 
CQ-DEPEND=CL:341324

Change-Id: Id6339ee6851ee3b3298f8af884386ce10a38b5ce
Reviewed-on: https://chromium-review.googlesource.com/341262
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Stéphane Marchesin <marcheu@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[modify] https://crrev.com/e964f9c9feb8a170a015ace54156152530db6178/chromeos-base/drm-tests/drm-tests-9999.ebuild

Project Member

Comment 6 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/drm-tests/+/d847a7ef80a19f5c7cdf4a0525b1529bf0b84cd1

commit d847a7ef80a19f5c7cdf4a0525b1529bf0b84cd1
Author: Zach Reizner <zachr@google.com>
Date: Thu Apr 28 23:48:32 2016

drm-tests: mv nv12_test to plane_test and support more formats

What's better than nv12_test? A test that can write to an unbounded
number of formats is what. This patch lays out the groundwork for easily
adding more formats to draw to. It also allows the user of plane_test to
pass in the desired format as the first argument.

TEST=plane_test
BUG= chromium:607241 
CQ-DEPEND=CL:341262

Change-Id: Icdbed59258a85ec1b1eb0753e94b7f86e5d9669f
Reviewed-on: https://chromium-review.googlesource.com/341324
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[add] https://crrev.com/d847a7ef80a19f5c7cdf4a0525b1529bf0b84cd1/plane_test.c
[modify] https://crrev.com/d847a7ef80a19f5c7cdf4a0525b1529bf0b84cd1/Makefile
[delete] https://crrev.com/1fafce87c75ebe003d556978e094ac965881f796/nv12_test.c

Project Member

Comment 7 by bugdroid1@chromium.org, May 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/drm-tests/+/fa0547a876bf0e1ac3740ea2a9cf8c7999acb87f

commit fa0547a876bf0e1ac3740ea2a9cf8c7999acb87f
Author: Zach Reizner <zachr@google.com>
Date: Thu May 12 01:43:40 2016

drm-tests: plane_test: add more options for testing planes

Hardware overlay planes are complex and it's often required to test
specific features individually when debugging them. This change adds
options to translate, scale, and crop planes. It also allows multiple
planes to be used at the same time in order to test their interactions.

TEST=plane_test
BUG= chromium:607241 

Change-Id: I23222761d24dea485006ea779801a1167b38be4e
Reviewed-on: https://chromium-review.googlesource.com/344294
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Dominik Behr <dbehr@chromium.org>

[modify] https://crrev.com/fa0547a876bf0e1ac3740ea2a9cf8c7999acb87f/plane_test.c

Cc: dongseon...@intel.com
Blockedon: 646148
Blocking: 370522
Blocking: 683347
Status: Archived (was: Started)

Comment 13 by ketakid@google.com, Mar 18 2017

Status: Available (was: Archived)
Activating. Please assign to the right owner and the appropriate priority.
Status: Fixed (was: Available)
Let close this. We have nv12 support in core chromeos and support in kms on some boards. We'll track future enabling for specific platforms in their own new bugs.

Sign in to add a comment