New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 607239 link

Starred by 1 user
Status: Verified
Owner:
gangwu@chromium.org
Closed: May 2016
Cc:
jonr...@chromium.org
zea@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

BaseNode aggressive DCHECK that isn't a folder

Project Member Reported by jonr...@chromium.org, Apr 27 2016 
BaseNode::GetIsPermanentFolder has an aggressive DCHECK: https://code.google.com/p/chromium/codesearch#chromium/src/sync/internal_api/base_node.cc&rcl=1461755891&l=167

However it is possible to have some older accounts which have nigori nodes without that bit set.

Could this be relaxed for development of the chromium os login flow?

Comment 1 by zea@chromium.org, Apr 27 2016

Owner: gangwu@chromium.org
Status: Assigned (was: Available)
Gang, I think we can just expand the DCHECK to be directory || nigori datatype.
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a2ae139f2788c83123fac4538ad581766241747

commit 5a2ae139f2788c83123fac4538ad581766241747
Author: gangwu <gangwu@chromium.org>
Date: Mon May 02 21:23:47 2016

[Sync] Do not check IS_DIR bit on nigori node

Some older accounts have nigori nodes without IS_DIR bit set,
so do not check on nigori node.

BUG= 607239 

Review-Url: https://codereview.chromium.org/1942593002
Cr-Commit-Position: refs/heads/master@{#391054}

[modify] https://crrev.com/5a2ae139f2788c83123fac4538ad581766241747/sync/internal_api/base_node.cc

Comment 3 by gangwu@chromium.org, May 3 2016

Status: Fixed (was: Assigned)

Comment 4 by patricia@chromium.org, May 23 2016 

Bulk verified

Comment 5 by patricia@chromium.org, May 23 2016

Status: Verified (was: Fixed)
bulk verified
►

Sign in to add a comment