New issue
Advanced search Search tips

Issue 607221 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Implement request queue for background offlining

Project Member Reported by fgor...@chromium.org, Apr 27 2016

Issue description

Request queue implementation plan:
1. Land the interfaces
2. Land implementation of the Queue with tests
3. Land basic implementation of the store (one entry, no persistence) with tests
4. Land implementation of policy for AddRequest with tests
5. Land implementation of policy for purging with tests
6. Land proper implementation of the store (using SQLite) with tests


 
Design available here: http://go/paquete-request-queue 
Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d01b7921e6789afc69ff794e36b84cfd609355ba

commit d01b7921e6789afc69ff794e36b84cfd609355ba
Author: fgorski <fgorski@chromium.org>
Date: Tue May 03 04:41:37 2016

[Offline pages] Empty RequestQueue and SavePageRequest

This is initial patch for request queue and save page request. SavePageRequest comes with basic implementation and tests.

BUG= 607221 
R=dougarnett@chromium.org,petewil@chromium.org

Review-Url: https://codereview.chromium.org/1932953002
Cr-Commit-Position: refs/heads/master@{#391169}

[modify] https://crrev.com/d01b7921e6789afc69ff794e36b84cfd609355ba/components/BUILD.gn
[modify] https://crrev.com/d01b7921e6789afc69ff794e36b84cfd609355ba/components/components_tests.gyp
[modify] https://crrev.com/d01b7921e6789afc69ff794e36b84cfd609355ba/components/offline_pages.gypi
[modify] https://crrev.com/d01b7921e6789afc69ff794e36b84cfd609355ba/components/offline_pages/background/BUILD.gn
[add] https://crrev.com/d01b7921e6789afc69ff794e36b84cfd609355ba/components/offline_pages/background/request_queue.cc
[add] https://crrev.com/d01b7921e6789afc69ff794e36b84cfd609355ba/components/offline_pages/background/request_queue.h
[add] https://crrev.com/d01b7921e6789afc69ff794e36b84cfd609355ba/components/offline_pages/background/save_page_request.cc
[add] https://crrev.com/d01b7921e6789afc69ff794e36b84cfd609355ba/components/offline_pages/background/save_page_request.h
[add] https://crrev.com/d01b7921e6789afc69ff794e36b84cfd609355ba/components/offline_pages/background/save_page_request_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, May 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5f5e71c825261caab602fc6f59f9ea030fd4f8d

commit c5f5e71c825261caab602fc6f59f9ea030fd4f8d
Author: fgorski <fgorski@chromium.org>
Date: Wed May 04 03:56:19 2016

[Offline pages] Adding in memory request queue store with tests

* Creates interface for RequestQueueStore
* Creates a basic in memory implementation of the store
* Creates tests for implementation
* Adds a copy constructor to SavePageRequest (implicitly tested
  in request queue store implementation).

BUG= 607221 
R=dougarnett@chromium.org,petewil@chromium.org

Review-Url: https://codereview.chromium.org/1951483002
Cr-Commit-Position: refs/heads/master@{#391440}

[modify] https://crrev.com/c5f5e71c825261caab602fc6f59f9ea030fd4f8d/components/components_tests.gyp
[modify] https://crrev.com/c5f5e71c825261caab602fc6f59f9ea030fd4f8d/components/offline_pages.gypi
[modify] https://crrev.com/c5f5e71c825261caab602fc6f59f9ea030fd4f8d/components/offline_pages/background/BUILD.gn
[add] https://crrev.com/c5f5e71c825261caab602fc6f59f9ea030fd4f8d/components/offline_pages/background/request_queue_in_memory_store.cc
[add] https://crrev.com/c5f5e71c825261caab602fc6f59f9ea030fd4f8d/components/offline_pages/background/request_queue_in_memory_store.h
[add] https://crrev.com/c5f5e71c825261caab602fc6f59f9ea030fd4f8d/components/offline_pages/background/request_queue_in_memory_store_unittest.cc
[add] https://crrev.com/c5f5e71c825261caab602fc6f59f9ea030fd4f8d/components/offline_pages/background/request_queue_store.h
[modify] https://crrev.com/c5f5e71c825261caab602fc6f59f9ea030fd4f8d/components/offline_pages/background/save_page_request.cc
[modify] https://crrev.com/c5f5e71c825261caab602fc6f59f9ea030fd4f8d/components/offline_pages/background/save_page_request.h

Labels: -OS-Android
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ff2a7b64f096594f1970eb18c61996972268835

commit 5ff2a7b64f096594f1970eb18c61996972268835
Author: fgorski <fgorski@chromium.org>
Date: Thu Jun 23 16:19:09 2016

[Offline pages] Adding persistent request queue based on SQLite

* This patch adds request queue SQLite base store.
* Converst in memory store tests to typed tests and adapts them to SQLite.

BUG= 607221 

Review-Url: https://codereview.chromium.org/2053163002
Cr-Commit-Position: refs/heads/master@{#401622}

[modify] https://crrev.com/5ff2a7b64f096594f1970eb18c61996972268835/components/offline_pages.gypi
[modify] https://crrev.com/5ff2a7b64f096594f1970eb18c61996972268835/components/offline_pages/background/BUILD.gn
[add] https://crrev.com/5ff2a7b64f096594f1970eb18c61996972268835/components/offline_pages/background/DEPS
[modify] https://crrev.com/5ff2a7b64f096594f1970eb18c61996972268835/components/offline_pages/background/request_queue.cc
[modify] https://crrev.com/5ff2a7b64f096594f1970eb18c61996972268835/components/offline_pages/background/request_queue_in_memory_store.cc
[add] https://crrev.com/5ff2a7b64f096594f1970eb18c61996972268835/components/offline_pages/background/request_queue_store_sql.cc
[add] https://crrev.com/5ff2a7b64f096594f1970eb18c61996972268835/components/offline_pages/background/request_queue_store_sql.h
[modify] https://crrev.com/5ff2a7b64f096594f1970eb18c61996972268835/components/offline_pages/background/request_queue_store_unittest.cc
[modify] https://crrev.com/5ff2a7b64f096594f1970eb18c61996972268835/components/offline_pages/background/save_page_request.h
[modify] https://crrev.com/5ff2a7b64f096594f1970eb18c61996972268835/components/offline_pages/background/save_page_request_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment