Some keyboard input fails in omnibox with mash |
|||||||||
Issue descriptionWhen running mash chrome on a Pixel keyboard input to the browser is problematic. [a-z0-9.,] seems to work fine always but keys like enter, backspace, etc. don't work initially. Replicate by typing a URL into the omnibox. The [a-z0-9.,] work fine but hitting backspace or enter doesn't work. If you click on the omnibox specifically then enter and backspace start working.
,
May 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38232cbdc87495f63516b1210e1548dadb8ddfbf commit 38232cbdc87495f63516b1210e1548dadb8ddfbf Author: sadrul <sadrul@chromium.org> Date: Wed May 11 23:45:55 2016 views/mus: Fix activating a widget. It's necessary to activate the aura::Window backing the widget, to make sure key-events work correctly. BUG= 607212 Review-Url: https://codereview.chromium.org/1968133002 Cr-Commit-Position: refs/heads/master@{#393108} [modify] https://crrev.com/38232cbdc87495f63516b1210e1548dadb8ddfbf/ui/views/mus/native_widget_mus.cc
,
May 11 2016
,
May 16 2016
It looks like this is fixed for the initial focus case but it's somehow losing focus after you select the omnibox. Reproduce by opening chrome, typing a URL/query into the omnibox and hitting enter to navigating to it. This part works now (yay). After the page has changed, click on the omnibox and type another URL/query then hit enter. The enter key doesn't work this time.
,
May 16 2016
,
May 18 2016
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dba514473583dbad9a49972a886ce66d3a49b8cd commit dba514473583dbad9a49972a886ce66d3a49b8cd Author: sadrul <sadrul@chromium.org> Date: Wed May 18 19:33:14 2016 views/mus: Fix window activation. Make sure the aura::Window instances embedded inside the Widget are not activated, because they are not top-level windows. BUG= 607212 Review-Url: https://codereview.chromium.org/1991673002 Cr-Commit-Position: refs/heads/master@{#394504} [modify] https://crrev.com/dba514473583dbad9a49972a886ce66d3a49b8cd/ui/views/mus/native_widget_mus.cc [modify] https://crrev.com/dba514473583dbad9a49972a886ce66d3a49b8cd/ui/views/mus/native_widget_mus_unittest.cc
,
May 18 2016
Should be fixed for realz now
,
May 23 2016
Bulk verified
,
May 23 2016
bulk verified
,
Feb 26 2018
,
Feb 26 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by sadrul@chromium.org
, May 11 2016Status: Started (was: Untriaged)