New issue
Advanced search Search tips

Issue 607210 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 476553



Sign in to add a comment

Main thread pull-to-refresh should use regular overscroll mechanism

Project Member Reported by bokan@chromium.org, Apr 27 2016

Issue description

Currently, the ViewportScrollController doesn't consume all the remaining scroll delta since pull-to-refresh isn't activated when calling ChromeClient::didOverscroll. I'm not sure what mechanism activates pull-to-refresh but all our viewport scrolling actions should happen from one place and scrolling shouldn't chain up beyond the element with a ViewportScrollController.
 

Comment 1 by bokan@chromium.org, Jul 6 2016

Labels: -Pri-2 Pri-3
It turns out that the Browser-size OverscrollController keeps track of gesture scrolls sent to the renderer. When the ACKs come back as being handled or not, decides whether that gesture scroll should be applied to the Pull-To-Refresh handler.

IMO, a more straightforward way would be to actually use the overscroll messages already sent to the browser to activate the p2r effect. p2r wants to activate only when a gesture hasn't had any scrolling so we would either have to account for that somehow or add a bit of extra information to the overscroll message.


Comment 2 by bokan@chromium.org, Nov 23 2017

Blocking: 476553
Triage check-in, this is still relevant and will likely be more so when we undertake scroll unification. 

Sign in to add a comment