New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607200 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

balance-pool --all-boards includes brillo entries

Reported by jrbarnette@chromium.org, Apr 27 2016

Issue description

If you run `balance-pool --all-boards bvt`, the actions listed
include these:

Balancing brillo-abox_edge bvt pool:
Balancing brillo-dragonboard bvt pool:

For now, we shouldn't be doing that.

This problem was fixed for the lab_inventory script, but because
balance-pool doesn't share code with lab_inventory, we're going
to have to fix it again.

The proper fix is to join the lab_inventory and balance_pool code
to prevent this kind of problem from occurring more than once.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cf0ad2ba0e9df5ca6473f50829235b7cc94163d5

commit cf0ad2ba0e9df5ca6473f50829235b7cc94163d5
Author: Kevin Cheng <kevcheng@chromium.org>
Date: Tue Apr 19 21:51:39 2016

[autotest] Update run-pool-inventory to balance_pool.

Balance out the pool before we send out the notification eMail to the
deputy.

BUG= chromium:605747 , chromium:607200 , chromium:617292 
TEST=locally with dry-run/debug options and unittest

Change-Id: I47cd45fe495e1d46a1a49e97922868de74c5fd02
Reviewed-on: https://chromium-review.googlesource.com/339674
Commit-Ready: Kevin Cheng <kevcheng@chromium.org>
Tested-by: Kevin Cheng <kevcheng@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/cf0ad2ba0e9df5ca6473f50829235b7cc94163d5/site_utils/balance_pools.py
[modify] https://crrev.com/cf0ad2ba0e9df5ca6473f50829235b7cc94163d5/site_utils/lab_inventory_unittest.py
[modify] https://crrev.com/cf0ad2ba0e9df5ca6473f50829235b7cc94163d5/contrib/run-pool-inventory
[modify] https://crrev.com/cf0ad2ba0e9df5ca6473f50829235b7cc94163d5/site_utils/lab_inventory.py

Status: Fixed (was: Assigned)
Closing... please feel free to reopen if its not fixed.
Status: Verified (was: Fixed)

Sign in to add a comment