New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607197 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 82385



Sign in to add a comment

ClangToTWin tester bots failing start_crash_service step

Project Member Reported by h...@chromium.org, Apr 27 2016

Issue description

Examples:

https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%20tester/builds/4420
https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin64%20tester/builds/4464

Looks like the binary is not there?


Traceback (most recent call last):
  File "E:\b\build\scripts\slave\chromium\run_crash_handler.py", line 71, in <module>
    sys.exit(main())
  File "E:\b\build\scripts\slave\chromium\run_crash_handler.py", line 50, in main
    raise chromium_utils.PathNotFound('Unable to find %s' % exe_path)
common.chromium_utils.PathNotFound: Unable to find E:\b\build\slave\ClangToTWin_tester\build\src\out\Release\crash_service.exe
 

Comment 1 by h...@chromium.org, Apr 27 2016

Looking at https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%20tester/builds/4420/steps/extract%20build/logs/stdio

It extracts these files:

Extracting  full-build-win32\crash_service.exe.assert.manifest
Extracting  full-build-win32\crash_service.exe.manifest
Extracting  full-build-win32\crash_service64.exe.assert.manifest
Extracting  full-build-win32\crash_service64.exe.manifest

But no crash_service.exe, but in the previous build, it did.

Comment 3 by h...@chromium.org, Apr 27 2016

Cc: scottmg@chromium.org
Status: Started (was: Untriaged)
Probably related to scottmg's https://codereview.chromium.org/1858883004

I don't really know what crash_service is, but was removing it intentional, and the tests should not be using it?

Comment 4 by h...@chromium.org, Apr 27 2016

Cc: dpranke@chromium.org
https://codereview.chromium.org/1862773003/ looks like it's removing references to crash_service on the bots, including ours

+dpranke for that patch
looks like it got reverted, but maybe it re-landed later? do we need a master restart for chromium.fyi to pick it up?
Cc: stip@chromium.org
Labels: Infra-Troopers
Status: Untriaged (was: Started)
I think the update_scripts step on that bot is updating the src/ checkout, which suggests that maybe we have a bad .gclient somewhere.

@stip, can you take a look?

We shouldn't be starting up crash_service any more, and I don't see any sign of it in the recipes at tip of tree.

chromium.fyi was restarted last night (before that build), so that's not the problem.

Comment 6 by thakis@chromium.org, Apr 28 2016

https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/4001/steps/compile/logs/stdio still passes `-w dupbuild=err` which we removed months ago. It looks like that bot is never updating slave scripts maybe?

stip, did you have a chance to check what's up here?

Comment 7 by h...@chromium.org, Apr 28 2016

Labels: -Pri-3 Pri-1
Upping priority as this means we currently don't have test coverage for Win Clang release builds.

Comment 8 by thakis@chromium.org, Apr 28 2016

stiiiiiiiip haaaaaaaaalllp
I logged into vm310-m1 (ClangToTWin tester) and moved a suspicious-looking pair of DEPS and .DEPS.git files, and forced a build.

If that goes through ok, I can look at the other failing bots, since stip@'s awol.

Comment 10 by h...@chromium.org, Apr 28 2016

That build failed with another exception:

@@@STEP_LOG_LINE@exception@KeyError: 'parent_buildername'@@@

but that might just be because it's confused about how the build was triggered..


Yup, that was me failing to remember that you can't force builds on triggered builders. 

So, we just have to wait.
hrm. My changes don't appear to have helped:

https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%20tester/builds/4454/steps/update_scripts/logs/stdio

I'm not sure what's going on, so I'm going to back away slowly and try to get a trooper to look at it.

Comment 13 by stip@google.com, Apr 28 2016

*moves forward slowly to replace dpranke*

Comment 14 by stip@google.com, Apr 28 2016

Labels: Infra-Labs
so update_scripts is *definitely* checking out src/, which is 

Comment 15 by stip@google.com, Apr 28 2016

(somehow hit send accidentally).

update_scripts checking our src is definitely not correct. labs, can you reimage vm310-m1?

Comment 16 by stip@chromium.org, Apr 28 2016

Owner: vhang@chromium.org

Comment 17 by jo...@google.com, Apr 28 2016

Components: Infra>Labs
Owner: jo...@chromium.org
Status: Assigned (was: Untriaged)
Taking a look.

Comment 18 by jo...@chromium.org, Apr 28 2016

Re-imaged and migrated to new hardware in the process. Waiting on a build for verification.

Comment 19 by jo...@chromium.org, Apr 29 2016

Status: Fixed (was: Assigned)
Build is now green: 

https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%20tester/builds/4456

Thanks.
Status: Assigned (was: Fixed)
As per comment #9, there's two more bots with the same issue.

@johnw, mind reimaging those as well?

https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin64%20tester (vm312-m1)
https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin64 (build129-m1)

Or should we file a new ticket for them?

Comment 21 by jo...@chromium.org, Apr 29 2016

Sorry, I missed that there were multiple bots involved. We'll get these all fixed up.

Thanks.

Comment 23 by jo...@google.com, Apr 29 2016

Status: Fixed (was: Assigned)
Thanks, John!
Status: Started (was: Fixed)
It looks like build27-m1 needs this too:

https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/4008

(https://build.chromium.org/p/chromium.fyi/builders/CrWinClangLLD64 on the same slave is happy though...)

Comment 26 by jo...@chromium.org, Apr 29 2016

Waiting for build27-m1 to finish it's current build before working on it.

Thanks.

@thakis - it looks like `update_scripts` is broken in the same way on both builders, but some how we're seeing crash service get added on one builder, and not the other, which is really weird. I don't even know how that's possible, since both builders should be seeing the same recipes.
I expect that `update_scripts` has been failing on these bots for some time, but you've been getting away with this because you've been doing incremental builds and have an old crash_service lying around.

However, when MB is enabled, it starts off by doing a clobber build so it can be sure it's in a clean directory and not confused over whether it was previously GYP or GN (it also does clobbers when switching between the two). As a result, your old crash_service is deleted, and things start to break.

update_scripts should really be a fatal error, but currently isn't (see bug 421769).
Ah, that's a good explanation, thanks.
CrWinAsan(dll) is now passing:

https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%28dll%29/builds/4019

I can look at vm311-m1 vm978-m1 today.

any luck?
Yeah, I redeployed both this morning. Neither has picked up any jobs for me to confirm greenness yet, however. 
Status: Fixed (was: Started)
Looks like all our fyi bots are now happy. Thanks, johnw :-)
Blocking: 82385
Status: Started (was: Fixed)
https://build.chromium.org/p/chromium.fyi/builders/ClangToTMacASan%20tester/builds/2095 -- vm30-m1 also prints

Agreeing to the Xcode/iOS license requires admin privileges, please re-run as root via sudo.


Traceback (most recent call last):
  File "../build/mac/find_sdk.py", line 97, in <module>
    print main()
  File "../build/mac/find_sdk.py", line 89, in main
    'macosx' + best_sdk, 'Path']).strip()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['xcodebuild', '-version', '-sdk', 'macosx10.10', 'Path']' returned non-zero exit status 69
CalledProcessError: Command '['/usr/bin/python', '../build/mac/find_sdk.py', '--print_sdk_path', '10.10']' returned non-zero exit status 1:
  File "/b/build/slave/ClangToTMacASan_tester/build/src/native_client/SConstruct", line 2437:
    (mac_debug_env, mac_optimized_env) = GenerateOptimizationLevels(MakeMacEnv())


justincohen, can you heal that bot too please?
Status: Fixed (was: Started)
sorry, wrong bug
Status: Started (was: Fixed)
Here's an exciting new bot where this is broken: https://build.chromium.org/p/chromium.fyi/builders/CrWinClang(shared)%20tester -- vm962-m1

Comment 39 by dnj@google.com, May 9 2016

Labels: -Infra-Troopers
Removing troopers label, as labs is handling this.
Ping, https://build.chromium.org/p/chromium.fyi/builders/CrWinClang(shared)%20tester / vm962-m1 is still having this problem.
Thanks again :-)

Sign in to add a comment