Implement the https://goto.google.com/chrometranslateui2016q3 |
|||||||||||||||||
Issue descriptionOS: Win/Linux Implement the Chrome Translate UI design 2016Q2 version at https://goto.google.com/chrometranslateui2016q3
,
Apr 27 2016
,
Apr 28 2016
1. removed ‘Nope’ and replaced it with ‘x’ (close button) 2. show detected and page languages on the initial bubble- Makes it clearer that this is a translation feature, even for users who can’t perfectly read their UI language 3. Clicking on language names takes user to the language edit view (already exists) 4. increased the visibility of Always Translate 5. Instead of Nope, relabeled the button Options and made it a simple drop down 6. If the same language is translated 2 times, next time, the ‘always translate’ option is checked by default. 7. After 10 consecutive clicks on ‘x’ or ‘outside the box’ for the same language across sites: Stop showing the bubble, but show the omnibar icon 8. After 3 consecutive clicks on ‘x’ for the same language across sites: Stop showing the bubble, but show the omnibar icon 9. Translate events reset all counters 10. After 2 consecutive clicks on Translate for the same language: Show bubble with ‘Always do this’ checked But if users manually uncheck the checkbox, we will never automatically check it
,
Apr 29 2016
Hey ftang, is there a CL to track?
,
Apr 29 2016
,
May 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7223e2c7d071d74bcd66c5a113e97fe21a82bb68 commit 7223e2c7d071d74bcd66c5a113e97fe21a82bb68 Author: ftang <ftang@chromium.org> Date: Wed May 04 16:50:56 2016 Implement the 2016Q2 Translate UI designe spec out in https://goto.google.com/chrometranslateui2016q3 1. removed ‘Nope’ and replaced it with ‘x’ (close button) 2. show detected and page languages on the initial bubble- Makes it clearer that this is a translation feature, even for users who can’t perfectly read their UI language 3. Clicking on language names takes user to the language edit view (already exists) 4. increased the visibility of Always Translate 5. Instead of Nope, relabeled the button Options and made it a simple drop down 6. If the same language is translated 2 times, next time, the ‘always translate’ option is checked by default. 7. After 10 consecutive clicks on ‘x’ or ‘outside the box’ for the same language across sites: Stop showing the bubble, but show the omnibar icon 8. After 3 consecutive clicks on ‘x’ for the same language across sites: Stop showing the bubble, but show the omnibar icon 9. Translate events reset all counters 10. After 2 consecutive clicks on Translate for the same language: Show bubble with ‘Always do this’ checked But if users manually uncheck the checkbox, we will never automatically check it BUG= 607170 Review-Url: https://codereview.chromium.org/1923143003 Cr-Commit-Position: refs/heads/master@{#391540} [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/chrome/app/generated_resources.grd [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/chrome/browser/translate/chrome_translate_client.cc [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/chrome/browser/ui/translate/translate_bubble_model.h [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/chrome/browser/ui/translate/translate_bubble_model_impl.cc [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/chrome/browser/ui/translate/translate_bubble_model_impl.h [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/chrome/browser/ui/translate/translate_bubble_view_state_transition.cc [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/chrome/browser/ui/translate/translate_bubble_view_state_transition.h [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/chrome/browser/ui/views/translate/translate_bubble_view.cc [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/chrome/browser/ui/views/translate/translate_bubble_view.h [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/components/translate/core/browser/translate_prefs.cc [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/components/translate/core/browser/translate_prefs.h [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/components/translate/core/browser/translate_prefs_unittest.cc [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/components/translate/core/browser/translate_ui_delegate.cc [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/components/translate/core/browser/translate_ui_delegate.h [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/components/translate/core/browser/translate_ui_delegate_unittest.cc [add] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/ui/resources/default_100_percent/common/translate.png [add] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/ui/resources/default_200_percent/common/translate.png [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/ui/resources/ui_resources.grd [modify] https://crrev.com/7223e2c7d071d74bcd66c5a113e97fe21a82bb68/ui/views/bubble/bubble_frame_view.h
,
May 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee70896060915a77908913761506faed25f2763b commit ee70896060915a77908913761506faed25f2763b Author: ftang <ftang@chromium.org> Date: Sat May 07 00:39:28 2016 add translate::kTranslateUI2016Q2 to chrome://flags page BUG= 607170 Review-Url: https://codereview.chromium.org/1947393004 Cr-Commit-Position: refs/heads/master@{#392219} [modify] https://crrev.com/ee70896060915a77908913761506faed25f2763b/chrome/app/generated_resources.grd [modify] https://crrev.com/ee70896060915a77908913761506faed25f2763b/chrome/browser/about_flags.cc
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/883a6d1220cde7daf15ef9b3e3f96acc5315f682 commit 883a6d1220cde7daf15ef9b3e3f96acc5315f682 Author: ftang <ftang@chromium.org> Date: Thu May 12 21:29:15 2016 log the click activate/deactive of translate icon on location bar BUG= 607170 Review-Url: https://codereview.chromium.org/1962393003 Cr-Commit-Position: refs/heads/master@{#393359} [modify] https://crrev.com/883a6d1220cde7daf15ef9b3e3f96acc5315f682/chrome/browser/ui/translate/translate_bubble_view_state_transition.cc [modify] https://crrev.com/883a6d1220cde7daf15ef9b3e3f96acc5315f682/chrome/browser/ui/translate/translate_bubble_view_state_transition.h [modify] https://crrev.com/883a6d1220cde7daf15ef9b3e3f96acc5315f682/chrome/browser/ui/views/location_bar/bubble_icon_view.cc [modify] https://crrev.com/883a6d1220cde7daf15ef9b3e3f96acc5315f682/chrome/browser/ui/views/location_bar/bubble_icon_view.h [modify] https://crrev.com/883a6d1220cde7daf15ef9b3e3f96acc5315f682/chrome/browser/ui/views/translate/translate_bubble_view.cc [modify] https://crrev.com/883a6d1220cde7daf15ef9b3e3f96acc5315f682/chrome/browser/ui/views/translate/translate_icon_view.cc [modify] https://crrev.com/883a6d1220cde7daf15ef9b3e3f96acc5315f682/chrome/browser/ui/views/translate/translate_icon_view.h
,
May 12 2016
,
May 16 2016
,
May 19 2016
This is not an OWP feature, so moving to Type-Launch.
,
Jun 29 2016
Issue 567318 has been merged into this issue.
,
Sep 28 2016
This launch bug has not been modified in the last 90 days and has no milestone label. Please take a look and add appropriate milestone label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 27 2016
This launch bug has not been modified in the last 90 days and has no milestone label. Please take a look and add appropriate milestone label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 28 2017
This launch bug has not been modified in the last 90 days and has no milestone label. Please take a look and add appropriate milestone label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 4 2017
,
Apr 4 2017
,
Apr 4 2017
,
Apr 17 2017
,
Apr 18 2017
,
Apr 18 2017
,
Apr 18 2017
,
Apr 27 2017
,
Jun 8 2017
,
Jun 8 2017
What are the next steps? If the 2016-q2 UI isn't launching it needs to be deleted rather than rot in the chromium codebase.
,
Jun 8 2017
We're trying to figure out exactly what's happening with this UI. Translate team can't support the increase in server load with it now hence why we're not launching yet but we're finalizing the direction we want to take in the future.
,
Nov 6 2017
,
Nov 27 2017
,
Jan 18 2018
|
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by groby@chromium.org
, Apr 27 2016