New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 607156 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

http/tests/fetch/referrer/serviceworker-echo-referrer-from-default-document.html flakes on Mac10.11 dbg

Project Member Reported by engedy@chromium.org, Apr 27 2016

Issue description

The following layout test is crashing on Mac10.11 dbg:

http/tests/fetch/referrer/serviceworker-echo-referrer-from-default-document.html

Caused by https://codereview.chromium.org/1899873006.

 

Comment 2 by engedy@chromium.org, Apr 27 2016

Failed run: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/1358

Stack trace:
ASSERTION FAILED: scriptState->contextIsValid()
03:48:34.658 4780   ../../third_party/WebKit/Source/bindings/core/v8/ScriptState.h(38) : blink::ScriptState::Scope::Scope(blink::ScriptState *)
03:48:34.658 4780   1   0x11d2a6746 blink::ScriptState::Scope::Scope(blink::ScriptState*)
03:48:34.658 4780   2   0x11d2a637b blink::ScriptState::Scope::Scope(blink::ScriptState*)
03:48:34.658 4780   3   0x11d44c0cd blink::BodyStreamBuffer::BodyStreamBuffer(blink::ScriptState*, WTF::PassOwnPtr<blink::FetchDataConsumerHandle>)
03:48:34.658 4780   4   0x11d44cb8b blink::BodyStreamBuffer::BodyStreamBuffer(blink::ScriptState*, WTF::PassOwnPtr<blink::FetchDataConsumerHandle>)
03:48:34.658 4780   5   0x11d48214d blink::FetchManager::Loader::didReceiveResponse(unsigned long, blink::ResourceResponse const&, WTF::PassOwnPtr<blink::WebDataConsumerHandle>)
03:48:34.658 4780   6   0x127b26bfb blink::DocumentThreadableLoader::handleResponse(unsigned long, blink::ResourceResponse const&, WTF::PassOwnPtr<blink::WebDataConsumerHandle>)
03:48:34.658 4780   7   0x127b25ce0 blink::DocumentThreadableLoader::responseReceived(blink::Resource*, blink::ResourceResponse const&, WTF::PassOwnPtr<blink::WebDataConsumerHandle>)
03:48:34.658 4780   8   0x127b26f9a non-virtual thunk to blink::DocumentThreadableLoader::responseReceived(blink::Resource*, blink::ResourceResponse const&, WTF::PassOwnPtr<blink::WebDataConsumerHandle>)
03:48:34.658 4780   9   0x127782abd blink::RawResource::responseReceived(blink::ResourceResponse const&, WTF::PassOwnPtr<blink::WebDataConsumerHandle>)
03:48:34.658 4780   10  0x1277c5e55 blink::ResourceLoader::didReceiveResponse(blink::WebURLLoader*, blink::WebURLResponse const&, blink::WebDataConsumerHandle*)
03:48:34.658 4780   11  0x113335ac6 content::WebURLLoaderImpl::Context::OnReceivedResponse(content::ResourceResponseInfo const&)
03:48:34.658 4780   12  0x1133389ea content::WebURLLoaderImpl::RequestPeerImpl::OnReceivedResponse(content::ResourceResponseInfo const&)
03:48:34.658 4780   13  0x1132a0c70 content::ResourceDispatcher::OnReceivedResponse(int, content::ResourceResponseHead const&)
03:48:34.658 4780   14  0x1132aeccd void base::DispatchToMethodImpl<content::ResourceDispatcher*, void (content::ResourceDispatcher::*)(int, content::ResourceResponseHead const&), int, content::ResourceResponseHead, 0ul, 1ul>(content::ResourceDispatcher* const&, void (content::ResourceDispatcher::*)(int, content::ResourceResponseHead const&), std::__1::tuple<int, content::ResourceResponseHead> const&, base::IndexSequence<0ul, 1ul>)
03:48:34.658 4780   15  0x1132aebc3 void base::DispatchToMethod<content::ResourceDispatcher*, void (content::ResourceDispatcher::*)(int, content::ResourceResponseHead const&), int, content::ResourceResponseHead>(content::ResourceDispatcher* const&, void (content::ResourceDispatcher::*)(int, content::ResourceResponseHead const&), std::__1::tuple<int, content::ResourceResponseHead> const&)
03:48:34.658 4780   16  0x1132aeafd void IPC::DispatchToMethod<content::ResourceDispatcher, void (content::ResourceDispatcher::*)(int, content::ResourceResponseHead const&), void, std::__1::tuple<int, content::ResourceResponseHead> >(content::ResourceDispatcher*, void (content::ResourceDispatcher::*)(int, content::ResourceResponseHead const&), void*, std::__1::tuple<int, content::ResourceResponseHead> const&)
03:48:34.658 4780   17  0x1132a734a bool IPC::MessageT<ResourceMsg_ReceivedResponse_Meta, std::__1::tuple<int, content::ResourceResponseHead>, void>::Dispatch<content::ResourceDispatcher, content::ResourceDispatcher, void, void (content::ResourceDispatcher::*)(int, content::ResourceResponseHead const&)>(IPC::Message const*, content::ResourceDispatcher*, content::ResourceDispatcher*, void*, void (content::ResourceDispatcher::*)(int, content::ResourceResponseHead const&))
03:48:34.658 4780   18  0x11329f858 content::ResourceDispatcher::DispatchMessage(IPC::Message const&)
03:48:34.658 4780   19  0x11329e7b0 content::ResourceDispatcher::OnMessageReceived(IPC::Message const&)
03:48:34.658 4780   20  0x1132b2a98 content::ResourceSchedulingFilter::DispatchMessage(IPC::Message const&)
03:48:34.658 4780   21  0x1132b3795 content::(anonymous namespace)::DispatchMessageTask::run()
03:48:34.658 4780   22  0x1229dfaa2 scheduler::WebTaskRunnerImpl::runTask(std::__1::unique_ptr<blink::WebTaskRunner::Task, std::__1::default_delete<blink::WebTaskRunner::Task> >)
03:48:34.658 4780   23  0x1229e12ad void base::internal::RunnableAdapter<void (*)(std::__1::unique_ptr<blink::WebTaskRunner::Task, std::__1::default_delete<blink::WebTaskRunner::Task> >)>::Run<std::__1::unique_ptr<blink::WebTaskRunner::Task, std::__1::default_delete<blink::WebTaskRunner::Task> > >(std::__1::unique_ptr<blink::WebTaskRunner::Task, std::__1::default_delete<blink::WebTaskRunner::Task> >&&)
03:48:34.658 4780   24  0x1229e10c6 void base::internal::InvokeHelper<false, void, base::internal::RunnableAdapter<void (*)(std::__1::unique_ptr<blink::WebTaskRunner::Task, std::__1::default_delete<blink::WebTaskRunner::Task> >)> >::MakeItSo<std::__1::unique_ptr<blink::WebTaskRunner::Task, std::__1::default_delete<blink::WebTaskRunner::Task> > >(base::internal::RunnableAdapter<void (*)(std::__1::unique_ptr<blink::WebTaskRunner::Task, std::__1::default_delete<blink::WebTaskRunner::Task> >)>, std::__1::unique_ptr<blink::WebTaskRunner::Task, std::__1::default_delete<blink::WebTaskRunner::Task> >&&)
03:48:34.658 4780   25  0x1229e0fad base::internal::Invoker<base::IndexSequence<0ul>, base::internal::BindState<base::internal::RunnableAdapter<void (*)(std::__1::unique_ptr<blink::WebTaskRunner::Task, std::__1::default_delete<blink::WebTaskRunner::Task> >)>, void (std::__1::unique_ptr<blink::WebTaskRunner::Task, std::__1::default_delete<blink::WebTaskRunner::Task> >), base::internal::PassedWrapper<std::__1::unique_ptr<blink::WebTaskRunner::Task, std::__1::default_delete<blink::WebTaskRunner::Task> > > >, base::internal::InvokeHelper<false, void, base::internal::RunnableAdapter<void (*)(std::__1::unique_ptr<blink::WebTaskRunner::Task, std::__1::default_delete<blink::WebTaskRunner::Task> >)> >, void ()>::Run(base::internal::BindStateBase*)
03:48:34.658 4780   26  0x10dc192bf base::Callback<void (), (base::internal::CopyMode)1>::Run() const
03:48:34.658 4780   27  0x10dc43fbe base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask const&)
03:48:34.658 4780   28  0x1229a8ef5 scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(scheduler::internal::WorkQueue*, scheduler::internal::TaskQueueImpl::Task*)
03:48:34.658 4780   29  0x1229a55f0 scheduler::TaskQueueManager::DoWork(base::TimeTicks, bool)
03:48:34.658 4780   30  0x1229af56a void base::internal::RunnableAdapter<void (scheduler::TaskQueueManager::*)(base::TimeTicks, bool)>::Run<base::TimeTicks const&, bool const&>(scheduler::TaskQueueManager*, base::TimeTicks const&&&, bool const&&&)
03:48:34.658 4780   31  0x1229af2ce void base::internal::InvokeHelper<true, void, base::internal::RunnableAdapter<void (scheduler::TaskQueueManager::*)(base::TimeTicks, bool)> >::MakeItSo<base::WeakPtr<scheduler::TaskQueueManager>, base::TimeTicks const&, bool const&>(base::internal::RunnableAdapter<void (scheduler::TaskQueueManager::*)(base::TimeTicks, bool)>, base::WeakPtr<scheduler::TaskQueueManager>, base::TimeTicks const&&&, bool const&&&)
03:48:34.658 4780   Received signal 11 SEGV_MAPERR 0000fbadbeef

Comment 3 by engedy@chromium.org, Apr 27 2016

The most recent run passed.  Will adjust CL to mark test as flaky instead.
Status: Assigned (was: Untriaged)

Comment 5 by engedy@chromium.org, Apr 27 2016

Summary: http/tests/fetch/referrer/serviceworker-echo-referrer-from-default-document.html flakes on Mac10.11 dbg (was: http/tests/fetch/referrer/serviceworker-echo-referrer-from-default-document.html crashes on Mac10.11 dbg)
Components: Blink>Network>FetchAPI
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68f484f87bf4240e271a9ff96f17f57b7a7de5f3

commit 68f484f87bf4240e271a9ff96f17f57b7a7de5f3
Author: engedy <engedy@chromium.org>
Date: Wed Apr 27 14:32:45 2016

Mark serviceworker-echo-referrer-from-default-document.html as crashing on Mac.

Add test expectation that http/tests/fetch/referrer/serviceworker-echo-referrer-from-default-document.html will crash on Mac10.11 dbg.

BUG= 607156 
TBR=yhirano

Review URL: https://codereview.chromium.org/1930483002

Cr-Commit-Position: refs/heads/master@{#390067}

[modify] https://crrev.com/68f484f87bf4240e271a9ff96f17f57b7a7de5f3/third_party/WebKit/LayoutTests/TestExpectations

This is also occurring on WebKit Linux (dbg) and WebKit Win7 (dgb). I'm going to mark the test as crashing there as well.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fd5cd7875ed4aa759e6c9beaad633bffda38714

commit 5fd5cd7875ed4aa759e6c9beaad633bffda38714
Author: jdonnelly <jdonnelly@chromium.org>
Date: Wed Apr 27 21:25:11 2016

Mark serviceworker-echo-referrer-from-default-document.html as crashing
on Win7 and Linux.

Add test expectation that
http/tests/fetch/referrer/serviceworker-echo-referrer-from-default-document.html
will crash on WebKit Win7 (dbg) and WebKit Linux (dbg).

BUG= 607156 
TBR=yhirano

Review-Url: https://codereview.chromium.org/1918823010
Cr-Commit-Position: refs/heads/master@{#390192}

[modify] https://crrev.com/5fd5cd7875ed4aa759e6c9beaad633bffda38714/third_party/WebKit/LayoutTests/TestExpectations

Initially, I went for disabling the test because it failed only on a single builder.

If the failure is more wide-spread, and it is acceptable practice in Blink to revert CLs due to test failures (is it?), then I'm fine with reverting (with running tryjobs), although yhirano@ told me he would look at it first thing today.
Cc: tyoshino@chromium.org
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/582f4114bc1bfc048633ea00172b9d0871ed9d8a

commit 582f4114bc1bfc048633ea00172b9d0871ed9d8a
Author: yhirano <yhirano@chromium.org>
Date: Thu Apr 28 10:15:34 2016

[Fetch API] Abort fetching when the passed ScriptState is invalid.

Sometimes GlobalFetch::fetch is called with an invalid ScriptState.
Do not start fetching in such a case.

BUG= 607156 

Review-Url: https://codereview.chromium.org/1924193002
Cr-Commit-Position: refs/heads/master@{#390338}

[modify] https://crrev.com/582f4114bc1bfc048633ea00172b9d0871ed9d8a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/582f4114bc1bfc048633ea00172b9d0871ed9d8a/third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp

Status: Fixed (was: Assigned)
Labels: Test-Layout

Sign in to add a comment