New issue
Advanced search Search tips

Issue 607155 link

Starred by 1 user
Status: Fixed
Owner:
msramek@chromium.org
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 595332



Sign in to add a comment

Update the conditions to show notices about other forms of browsing history

Project Member Reported by msramek@chromium.org, Apr 27 2016 
The permanent notice on the history page and in the CBD dialog footer should be shown to all users (syncing their browsing history without a custom passphrase and with the web and app activity toggled on), regardless of the result of WebHistoryService::HasOtherFormsOfBrowsingHistory().
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2908c2ef968baf62cef0a45c87031e145c3ea39e

commit 2908c2ef968baf62cef0a45c87031e145c3ea39e
Author: msramek <msramek@chromium.org>
Date: Fri Apr 29 09:35:31 2016

Relax the conditions to show the permanent notice about other forms of browsing history

The notice in the Clear Browsing Data dialog footer and history page header
will now not require WebHistoryService::HasOtherFormsOfBrowsingHistory()
to be true.

However, showing the one-time notice in the Clear Browsing Data dialog
still will.

BUG= 607155 

Review-Url: https://codereview.chromium.org/1915983007
Cr-Commit-Position: refs/heads/master@{#390607}

[modify] https://crrev.com/2908c2ef968baf62cef0a45c87031e145c3ea39e/components/browsing_data_ui/history_notice_utils.cc

Comment 2 by msramek@chromium.org, May 2 2016

Labels: Merge-Request-51
This has now passed through Canary (twice). Requesting merge to M51.

Comment 3 by tin...@google.com, May 2 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 4 by bugdroid1@chromium.org, May 2 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/415badb4264d0080e2956a257bb1ecc8c357e091

commit 415badb4264d0080e2956a257bb1ecc8c357e091
Author: Martin Sramek <msramek@chromium.org>
Date: Mon May 02 13:22:21 2016

Relax the conditions to show the permanent notice about other forms of browsing history

The notice in the Clear Browsing Data dialog footer and history page header
will now not require WebHistoryService::HasOtherFormsOfBrowsingHistory()
to be true.

However, showing the one-time notice in the Clear Browsing Data dialog
still will.

BUG= 607155 

Review-Url: https://codereview.chromium.org/1915983007
Cr-Commit-Position: refs/heads/master@{#390607}
(cherry picked from commit 2908c2ef968baf62cef0a45c87031e145c3ea39e)

Review URL: https://codereview.chromium.org/1935023002 .

Cr-Commit-Position: refs/branch-heads/2704@{#331}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/415badb4264d0080e2956a257bb1ecc8c357e091/components/browsing_data_ui/history_notice_utils.cc

Comment 5 by msramek@chromium.org, May 2 2016

Status: Fixed (was: Started)
►

Sign in to add a comment