New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 607154 link

Starred by 1 user
Status: Verified
Owner:
perezju@chromium.org
Closed: Apr 2016
Cc:
█ picksi@chromium.org
█ mikec...@chromium.org
█ nednguyen@chromium.org
sullivan@chromium.org
primiano@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Memory health benchmark should be running on Android One

Project Member Reported by perezju@chromium.org, Apr 27 2016 
The memory health benchmark should be running on Android One bots. But it's not because of:

  @classmethod
  def ShouldDisable(cls, possible_browser):
    # Benchmark requires DeskClock app only available on Nexus devices.
    # See  http://crbug.com/546842 
    return 'nexus' not in possible_browser.platform.GetDeviceTypeName().lower()
https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/benchmarks/memory_infra.py&l=63

On Android One the device type name (which resolves to "getprop ro.product.model") returns: "W6210 (4560MMX_b fingerprint)".

The real fix is of course to complete  issue 586148 , so we can enable the test on all devices. But meanwhile I'll try to come up with a workaround (the DeskClock app *is* available on these devices).
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/525bab5f06cc34ff940c999cf00f78284d167257

commit 525bab5f06cc34ff940c999cf00f78284d167257
Author: perezju <perezju@chromium.org>
Date: Wed Apr 27 15:02:13 2016

[Memory Health] Enable benchmark on Android One bots

The previous mechanism used to disable on non-nexus devices had the
unintended effect of also disabling on Android One.

BUG= 607154 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1924553005

Cr-Commit-Position: refs/heads/master@{#390077}

[modify] https://crrev.com/525bab5f06cc34ff940c999cf00f78284d167257/tools/perf/benchmarks/memory_infra.py

Comment 3 by picksi@chromium.org, Apr 29 2016 

For some context; Which benchmark is this? One that contributes to the current system health plan dashboard or the Android memory acceptance test, or something else entirely?

Comment 4 by perezju@chromium.org, Apr 29 2016 

Neither. Although it *is* the memory.memory_health_plan benchmark, this is running on public bots, so it does *not* form part of the high level metrics reported on the chrome health dashboard.
►

Sign in to add a comment