New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 607113 link

Starred by 0 users
Status: Fixed
Owner:
gambard@chromium.org
Closed: Sep 2017
Cc:
marq@chromium.org
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

NewTabPageController should typecast self.view to NewTabPageView

Project Member Reported by vabr@chromium.org, Apr 27 2016 
Currently, NTPC has two properties: view and ntpView. They point to the same view, but the first one is UIView, and the second one is NTPV.

As per marq@'s comment in https://chromereviews.googleplex.com/392357013/diff/100001/chrome/browser/ui/ntp/new_tab_page_controller.mm#newcode117, this should be just one property with an appropriate getter.
Project Member

Comment 1 by sheriffbot@chromium.org, Apr 27 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by edchin@chromium.org, May 8 2017

Cc: marq@chromium.org
Status: Available (was: Untriaged)

Comment 3 by gambard@chromium.org, Sep 26 2017

Owner: gambard@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f336d40b40c7e42938bf0e66b807305d8808a3d

commit 7f336d40b40c7e42938bf0e66b807305d8808a3d
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Sep 27 13:53:20 2017

Merge NTPView and view in NTPController

NTPController had two properties, ntpView and view which point to the
same object. This CL merge both of them.

Bug:  607113 
Change-Id: I9511cd9e0a821b8766d5368f25506508babc54bc
Reviewed-on: https://chromium-review.googlesource.com/684840
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504651}
[modify] https://crrev.com/7f336d40b40c7e42938bf0e66b807305d8808a3d/ios/chrome/browser/ui/ntp/new_tab_page_controller.h
[modify] https://crrev.com/7f336d40b40c7e42938bf0e66b807305d8808a3d/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm
[modify] https://crrev.com/7f336d40b40c7e42938bf0e66b807305d8808a3d/ios/chrome/browser/ui/ntp/new_tab_page_controller_unittest.mm

Comment 5 by gambard@chromium.org, Sep 27 2017

Status: Fixed (was: Assigned)

Comment 6 by gambard@chromium.org, Sep 27 2017

Labels: -Type-Bug Type-Task
►

Sign in to add a comment