Tomasz, is there a blocker or bug for this issue?
To add the ability to zip folders, zip unpacker want to use fileManagerPrivate.resolveIsolatedEntries().
And we want to update zip unpacker and file manager at the same time.
Making the zip unpacker a component extension will make things easier.
The blocker was a difficulty to compile NaCl module using Chrome build system. I didn't try, but I remember that no one has done it before. However, maybe it's worth trying. I agree it would make things way way simpler if we could keep the Zip Unpacker extension in Chromium repo.
Cc: yamaguchi@chromium.org Labels: M-63 Owner: klemenko@google.com Status: Assigned (was: Available) Summary: Migrate Zip Unpacker to a normal component extension (was: Make ZIP unpacker a component extension.)
Hi,
change https://chromium-review.googlesource.com/c/chromium/src/+/662983 breaks non x86 builds.
x86 related flags are added for all arches:
if (!is_nacl) {
cflags += [
"-maes",
"-msse3",
"-msse4.1",
]
}
For MIPS build there are clang errors:
clang: error: argument unused during compilation: '-maes' [-Werror,-Wunused-command-line-argument]
clang: error: argument unused during compilation: '-msse3' [-Werror,-Wunused-command-line-argument]
clang: error: argument unused during compilation: '-msse4.1' [-Werror,-Wunused-command-line-argument]
Comment 1 by mtomasz@chromium.org
, Apr 27 2016