Bisected to

https://chromium.googlesource.com/chromium/src/+/8b134c7492731333fabeda5e358f0604ae5f565e

lionel.g.landwerlin@, could you please look into this?

You can reproduce this on high DPI machine like Pixel or run --ash-host-window-bouinds=1800x1000*2 on desktop.

Thanks, reproduced.
Looks like I got the scaling wrong. At native resolution the shadows are visible.

Please make sure the shadow works with fractional scale factor such as 1.25 and 1.5 as well. Thanks!

I haven't done a lot of desktop builds recently and after 2 different ones I still don't have a working ash desktop.
What flags are you using? 

Here :

gn gen out/Default --args='target_os="chromeos"'

Thanks!

That should work. You may want to use

is_component_build = true
enable_nacl = false
dcheck_always_on = true

Thanks a lot.
./out/Debug/chrome --ui-enable-software-compositing --ui-disable-threaded-compositing --ash-host-window-bounds=1024x768*1.25 

Looks fine to me.

Deleted: Screenshot from 2016-04-29 20-57-53.png 54.3 KB

	Screenshot from 2016-04-29 20-57-53.png 54.3 KB View Download

If I revert https://codereview.chromium.org/1937493002/ from my branch, at a factor of 1.25 or above shadows are missing or barely visible.

Sorry I forgot to mention that it is the small shadow (ones used for menu, etc) that is broken.

Here are the expected (https://codereview.chromium.org/1937493002/ reverted) and the latest with your patch.

Deleted: expected.png 162 KB

	expected.png 162 KB View Download

Deleted: latest.png 169 KB

	latest.png 169 KB View Download

Oops, I meant https://codereview.chromium.org/1889153002.

#7, that behavior is exactly the issue, if you really meant  https://codereview.chromium.org/1937493002/ :)

I also noticed that the right side corners (top bottom) are no longer rounded after https://codereview.chromium.org/1889153002.

Deleted: current.png 1.5 KB

	current.png 1.5 KB View Download

Deleted: expected.png 1.6 KB

	expected.png 1.6 KB View Download

Ok, so it seems there are 2 issues. Scaling (which appears to be fixed in https://codereview.chromium.org/1937493002/) and I guess an off by one clamping (missing ceil/floor).

I won't be able to fix the remaining one over the weekend. Should we revert https://codereview.chromium.org/1889153002 now and I will reland a better version later (probably on Monday)?

This isn't that urgent. If you can fix this next week, no need to revert. Have a nice weekend!

To make sure I'm not chasing existing issues I reverted https://codereview.chromium.org/1889153002

At scale=1 or 2 there are no issues with the top right corner not being rounded.
Though at scale=1.25 depending on the size of the window (odd width) you notice the top right corner not rounded.
So I think this was a preexisting issue, only at fractional scale and with the window's width an odd number.

The latest update on https://codereview.chromium.org/1937493002 should fix the remaining issue with menus' shadows.

Sorry for making bisect this.

Issue 610810 has been merged into this issue.

 Issue 611993  has been merged into this issue.

 Issue 614226  has been merged into this issue.

I forgot to add the bug number in the revert of the commit that introduced this issue.
As of https://codereview.chromium.org/1983803003 this issue should be fixed.

Verified on ChromeOS 8350.31.0, 52.0.2743.41 link

[Auto-generated comment by a script] We noticed that this issue is targeted for M-52; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-52 label, otherwise remove Merge-TBD label. Thanks.

[Bulk edit]

Our blockerbot script was offline; it was recently brought back online, and thus labeled many old issues (including this one) erroneously.  Removing Merge-TBD label since all milestones for this issue are already completed; no further work should be done.