Issue metadata
Sign in to add a comment
|
Collapsed borders are incorrectly painted in http://nyti.ms/mini |
||||||||||||||||||||||
Issue descriptionOpen http://nyti.ms/mini. Expected: the cross word grid should have borders between the cells in dark gray color. Actual: the borders are in white color which looks invisible.
,
Apr 27 2016
Here is the bisect range for this bug : https://chromium.googlesource.com/chromium/src/+log/51.0.2704.23..51.0.2704.24?pretty=fuller&n=10000 suspecting CL : https://chromium.googlesource.com/chromium/src/+/f984c3395c994122091f7e7db88c8776f51f9b0e
,
Apr 27 2016
Scott, I have created a fix which is under review. It'll be landed in m52 and m51 soon, but not m50. Before the fix is landed and m51 becomes stable, you can try a workaround: remove 'position: relative' from the table.
,
Apr 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca106e2693d28e0d045a82077e3a6d8d14c2df43 commit ca106e2693d28e0d045a82077e3a6d8d14c2df43 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Wed Apr 27 23:53:05 2016 Set needsPaintPhaseDescendantBlockBackgrounds if a table has collapsed borders No matter the actual borders are defined by which descendants and whether the descedants have self-painting layer, a border-collapsing table always paint collapsed borders in PaintPhaseDescendantBlockBackgrounds. Set needsPaintPhaseDescendantBlockBackgrounds if a table has visible collapsed borders. BUG= 607022 TEST=PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds Review-Url: https://codereview.chromium.org/1925703003 Cr-Commit-Position: refs/heads/master@{#390242} [modify] https://crrev.com/ca106e2693d28e0d045a82077e3a6d8d14c2df43/third_party/WebKit/Source/core/layout/LayoutTable.cpp [modify] https://crrev.com/ca106e2693d28e0d045a82077e3a6d8d14c2df43/third_party/WebKit/Source/core/paint/PaintInfo.h [modify] https://crrev.com/ca106e2693d28e0d045a82077e3a6d8d14c2df43/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp
,
Apr 28 2016
,
Apr 28 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
Apr 29 2016
Please merge your change to M51 branch 2704 before 5:00 PM PST, tomorrow (Friday), so we can take it in for next week M51 beta release. Thank you.
,
Apr 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0232fd39ca56b39772db60d2f94d011389817880 commit 0232fd39ca56b39772db60d2f94d011389817880 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Apr 29 05:52:02 2016 Set needsPaintPhaseDescendantBlockBackgrounds if a table has collapsed borders No matter the actual borders are defined by which descendants and whether the descedants have self-painting layer, a border-collapsing table always paint collapsed borders in PaintPhaseDescendantBlockBackgrounds. Set needsPaintPhaseDescendantBlockBackgrounds if a table has visible collapsed borders. BUG= 607022 TEST=PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds Review-Url: https://codereview.chromium.org/1925703003 Cr-Commit-Position: refs/heads/master@{#390242} Review URL: https://codereview.chromium.org/1933063002 . Cr-Commit-Position: refs/branch-heads/2704@{#304} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/0232fd39ca56b39772db60d2f94d011389817880/third_party/WebKit/Source/core/layout/LayoutTable.cpp [modify] https://crrev.com/0232fd39ca56b39772db60d2f94d011389817880/third_party/WebKit/Source/core/paint/PaintInfo.h [modify] https://crrev.com/0232fd39ca56b39772db60d2f94d011389817880/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp
,
Apr 29 2016
,
May 4 2016
Tested the issue on Windows 7 using 51.0.2704.36.Observed that the cross word grid have borders between the cells in dark gray color. Please find attached screenshot. Marking it as TE-Verified. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by wangxianzhu@chromium.org
, Apr 27 2016