New issue
Advanced search Search tips

Issue 607017 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

mac_views_browser compile regression (r389779 ?)

Project Member Reported by tapted@chromium.org, Apr 26 2016

Issue description

Chrome Version       : 52.0.2717.0
OS Version: OS X 10.11.4

"compile" step went red in http://goto.google.com/macviewsbuilder/builds/9821

What steps will reproduce the problem?
1. go/macviewsbuilder
2. see red

What is the expected result?

no red

What happens instead of that?


[6374/6792] LINK content_unittests, POSTBUILDS
FAILED: /b/build/slave/cache/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ /* snip */ -Wl,-search_paths_first -Wl,-ObjC -Wl,-dead_strip -compatibility_version 2718.0.0 -current_version 2718.0.0 -mmacosx-version-min=10.7 -isysroot /Applications/Xcode7.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -Wl,-order_file -Wl,../../chrome/app/framework.order -arch x86_64 -L. -install_name @executable_path/../Versions/52.0.2718.0/Chromium\ Framework.framework/Chromium\ Framework -stdlib=libc++ -o "Chromium Framework.framework/Versions/A/Chromium Framework" @Chromium_Framework.framework.rsp
Undefined symbols for architecture x86_64:
  "ExtensionInstallPrompt::GetDefaultShowDialogCallback()", referenced from:
      ExtensionEnableFlow::CheckPermissionAndMaybePromptUser() in libbrowser_ui.a(browser_ui.extension_enable_flow.o)
      extensions::CrxInstaller::ConfirmReEnable() in libbrowser_extensions.a(browser_extensions.crx_installer.o)
      extensions::UnpackedInstaller::ShowInstallPrompt() in libbrowser_extensions.a(browser_extensions.unpacked_installer.o)
      extensions::ExtensionReenabler::PromptForReenable(scoped_refptr<extensions::Extension const> const&, content::BrowserContext*, content::WebContents*, GURL const&, base::Callback<void (extensions::ExtensionReenabler::ReenableResult), (base::internal::CopyMode)1> const&) in libbrowser_extensions.a(browser_extensions.extension_reenabler.o)
      extensions::WebstoreStandaloneInstaller::ShowInstallUI() in libbrowser_extensions.a(browser_extensions.webstore_standalone_installer.o)
      ExtensionInstallPrompt::ShowConfirmation() in libbrowser_extensions.a(browser_extensions.extension_install_prompt.o)
      extensions::ExternalInstallError::ShowDialog(Browser*) in libbrowser_extensions.a(browser_extensions.external_install_error.o)

Might be r389779

Changed by	ellyjones@chromium.org
Changed at	Tue 26 Apr 2016 07:59:09
Revision	145ffb972813fef174d6a96f2ca97983ede90c8a

MacViews: add extension install dialog to MacViewsWebUIDialogs

This dialog is now behind the MacViewsWebUIDialogs feature flag.

BUG= 605657 

Review URL: https://codereview.chromium.org/1918793004

Cr-Commit-Position: refs/heads/master@{#389779}
 

Comment 1 by tapted@chromium.org, May 31 2016

Status: Fixed (was: Assigned)

Sign in to add a comment