New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 607003 link

Starred by 2 users
Status: Fixed
Owner:
dalecur...@chromium.org
Closed: May 2016
Cc:
█ qsr@chromium.org
henrika@chromium.org
█ tsunghung@chromium.org
solenberg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

OpenSLES output driver does not properly configure > stereo audio.

Project Member Reported by dalecur...@chromium.org, Apr 26 2016 
The code throws a DCHECK if > stereo audio is provided:

https://code.google.com/p/chromium/codesearch#chromium/src/media/audio/android/opensles_output.cc&l=49

It looks like it's just a matter of setting the right channel flags. Will try to find some way to test this and add support.

This hasn't been an issue in the past since only WebRTC and WebAudio used it, but now that we have media playback using this code we should support this use case.

Comment 1 by dalecur...@chromium.org, Apr 27 2016

Cc: tsunghung@chromium.org
Fix here. https://codereview.chromium.org/1921963004
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48c1c49bc3646cf90a59ad90260a43ff23001bf1

commit 48c1c49bc3646cf90a59ad90260a43ff23001bf1
Author: dalecurtis <dalecurtis@chromium.org>
Date: Mon May 02 23:35:23 2016

Add support for multichannel playback to OpenSLES output.

Ports the code from AOSP for detecting channel layouts given a
channel count. No idea if it works though since I'm not sure how
to setup a multichannel android device.

Notably this also changes the mono layout from using the center
channel to using the left channel mask per notes in the ported
code.

Multichannel is only supported on Lollipop+ devices since OpenSLES
does not configure successfully on any KitKat device I've tried.

BUG= 607003 
TEST=multichannel test clip.

Review-Url: https://codereview.chromium.org/1921963004
Cr-Commit-Position: refs/heads/master@{#391095}

[modify] https://crrev.com/48c1c49bc3646cf90a59ad90260a43ff23001bf1/media/audio/BUILD.gn
[modify] https://crrev.com/48c1c49bc3646cf90a59ad90260a43ff23001bf1/media/audio/android/audio_manager_android.cc
[modify] https://crrev.com/48c1c49bc3646cf90a59ad90260a43ff23001bf1/media/audio/android/opensles_input.cc
[modify] https://crrev.com/48c1c49bc3646cf90a59ad90260a43ff23001bf1/media/audio/android/opensles_output.cc
[add] https://crrev.com/48c1c49bc3646cf90a59ad90260a43ff23001bf1/media/audio/android/opensles_util.cc
[modify] https://crrev.com/48c1c49bc3646cf90a59ad90260a43ff23001bf1/media/audio/android/opensles_util.h
[modify] https://crrev.com/48c1c49bc3646cf90a59ad90260a43ff23001bf1/media/media.gyp

Comment 3 by dalecur...@chromium.org, May 10 2016

Labels: Merge-Request-51
No issues with latest dev so merging.

Comment 4 by tin...@google.com, May 10 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 5 by bugdroid1@chromium.org, May 10 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2bbdb83e7084bb2982bf026ed26f6480c0d64a4

commit e2bbdb83e7084bb2982bf026ed26f6480c0d64a4
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Tue May 10 22:18:07 2016

Merge M51: "Add support for multichannel playback to OpenSLES output."

Ports the code from AOSP for detecting channel layouts given a
channel count. No idea if it works though since I'm not sure how
to setup a multichannel android device.

Notably this also changes the mono layout from using the center
channel to using the left channel mask per notes in the ported
code.

Multichannel is only supported on Lollipop+ devices since OpenSLES
does not configure successfully on any KitKat device I've tried.

BUG= 607003 
TEST=multichannel test clip.

Review-Url: https://codereview.chromium.org/1921963004
Cr-Commit-Position: refs/heads/master@{#391095}
(cherry picked from commit 48c1c49bc3646cf90a59ad90260a43ff23001bf1)

Review URL: https://codereview.chromium.org/1967833002 .

Cr-Commit-Position: refs/branch-heads/2704@{#483}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/e2bbdb83e7084bb2982bf026ed26f6480c0d64a4/media/audio/BUILD.gn
[modify] https://crrev.com/e2bbdb83e7084bb2982bf026ed26f6480c0d64a4/media/audio/android/audio_manager_android.cc
[modify] https://crrev.com/e2bbdb83e7084bb2982bf026ed26f6480c0d64a4/media/audio/android/opensles_input.cc
[modify] https://crrev.com/e2bbdb83e7084bb2982bf026ed26f6480c0d64a4/media/audio/android/opensles_output.cc
[add] https://crrev.com/e2bbdb83e7084bb2982bf026ed26f6480c0d64a4/media/audio/android/opensles_util.cc
[modify] https://crrev.com/e2bbdb83e7084bb2982bf026ed26f6480c0d64a4/media/audio/android/opensles_util.h
[modify] https://crrev.com/e2bbdb83e7084bb2982bf026ed26f6480c0d64a4/media/media.gyp

Comment 6 by dalecur...@chromium.org, May 10 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment