OOPIF: Going back to data URL or about:blank in subframe uses wrong process |
||
Issue descriptionVersion: 52.0.2717.0 and earlier OS: All What steps will reproduce the problem? (0) Start Chrome with --site-per-process (1) http://csreis.github.io/tests/cross-site-iframe.html (which loads a data URL in the subframe) (2) Click "Go cross-site (simple page)" (Should have a subframe process now) (3) Go back. What is the expected output? The data URL should load in the same SiteInstance/process as the first time we visited it (i.e., the parent page's process). What do you see instead? The data URL loads in the subframe process. This means we don't respect the SiteInstance that's on the FrameNavigationEntry, probably because we think we don't need to swap for data URLs. Applies to about:blank pages as well (if you navigate to them manually so that they stay in session history).
,
May 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c753351ae3064f9c4b29ffff9143cc606f8a5a3c commit c753351ae3064f9c4b29ffff9143cc606f8a5a3c Author: nasko <nasko@chromium.org> Date: Fri May 06 17:01:12 2016 Move ownership of source SiteInstance to the FrameNavigationEntry. BUG= 606996 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/1944013003 Cr-Commit-Position: refs/heads/master@{#392078} [modify] https://crrev.com/c753351ae3064f9c4b29ffff9143cc606f8a5a3c/content/browser/frame_host/frame_navigation_entry.cc [modify] https://crrev.com/c753351ae3064f9c4b29ffff9143cc606f8a5a3c/content/browser/frame_host/frame_navigation_entry.h [modify] https://crrev.com/c753351ae3064f9c4b29ffff9143cc606f8a5a3c/content/browser/frame_host/navigation_controller_impl.cc [modify] https://crrev.com/c753351ae3064f9c4b29ffff9143cc606f8a5a3c/content/browser/frame_host/navigation_entry_impl.cc [modify] https://crrev.com/c753351ae3064f9c4b29ffff9143cc606f8a5a3c/content/browser/frame_host/navigation_entry_impl.h [modify] https://crrev.com/c753351ae3064f9c4b29ffff9143cc606f8a5a3c/content/browser/frame_host/navigation_request.cc [modify] https://crrev.com/c753351ae3064f9c4b29ffff9143cc606f8a5a3c/content/browser/frame_host/navigator_impl.cc [modify] https://crrev.com/c753351ae3064f9c4b29ffff9143cc606f8a5a3c/content/browser/frame_host/render_frame_host_manager.cc
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58b07f5147cb47dc85302bd3a112efb627c972ff commit 58b07f5147cb47dc85302bd3a112efb627c972ff Author: nasko <nasko@chromium.org> Date: Mon May 09 22:38:35 2016 Take session history SiteInstance into account for unique origin navigations. This CL fixes an issue with navigating to data: URLs in --site-per-process mode, which caused the data: URL to be loaded in incorrect process. BUG= 606996 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/1960703003 Cr-Commit-Position: refs/heads/master@{#392450} [modify] https://crrev.com/58b07f5147cb47dc85302bd3a112efb627c972ff/content/browser/frame_host/render_frame_host_manager.cc [modify] https://crrev.com/58b07f5147cb47dc85302bd3a112efb627c972ff/content/browser/site_per_process_browsertest.cc
,
May 9 2016
This should make it in tomorrow's canary. I'm going to mark it as fixed and feel free to reopen if there are still issues. |
||
►
Sign in to add a comment |
||
Comment 1 by nasko@chromium.org
, May 2 2016