Unable to seek with multibuffer enabled |
|||||||
Issue descriptionChrome linux 50.0.2661.86 (Official Build) (64-bit) Run with --enable-features=use-new-media-cache. Go to http://espn.go.com/nba/playoffs/2016/story/_/id/15385532/golden-state-warriors-were-right-push-73 Turn on devtools with device mode enabled to simulate a phone UA and try to seek. Seeking works without the above flag.
,
Apr 27 2016
,
Apr 27 2016
Device mode seems to be superfluous.
,
Apr 27 2016
I was only using device mode to force espn to serve me html5 instead of flash.
,
Apr 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fed486149cdfb7ad37fe474e3ab78d62cab42db commit 1fed486149cdfb7ad37fe474e3ab78d62cab42db Author: hubbe <hubbe@chromium.org> Date: Thu Apr 28 21:58:45 2016 Fix seeking after redirect The data length was behing applied to the old UrlData instance instead of the new one after a redirect. Not knowing the length disables seeking, this CL fixes that and adds a test to prevent the problem from occuring again. BUG= 606965 Review-Url: https://codereview.chromium.org/1932823002 Cr-Commit-Position: refs/heads/master@{#390498} [modify] https://crrev.com/1fed486149cdfb7ad37fe474e3ab78d62cab42db/media/blink/multibuffer_data_source_unittest.cc [modify] https://crrev.com/1fed486149cdfb7ad37fe474e3ab78d62cab42db/media/blink/resource_multibuffer_data_provider.cc [modify] https://crrev.com/1fed486149cdfb7ad37fe474e3ab78d62cab42db/media/blink/resource_multibuffer_data_provider.h
,
Apr 29 2016
Will let this bake over the weekend and request merge early next week.
,
May 2 2016
,
May 2 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ba2ce7dcaf9ed453405c542dadec634810e47c5 commit 6ba2ce7dcaf9ed453405c542dadec634810e47c5 Author: Fredrik Hubinette <hubbe@google.com> Date: Mon May 02 22:54:54 2016 Fix seeking after redirect The data length was behing applied to the old UrlData instance instead of the new one after a redirect. Not knowing the length disables seeking, this CL fixes that and adds a test to prevent the problem from occuring again. BUG= 606965 Review-Url: https://codereview.chromium.org/1932823002 Cr-Commit-Position: refs/heads/master@{#390498} (cherry picked from commit 1fed486149cdfb7ad37fe474e3ab78d62cab42db) Review URL: https://codereview.chromium.org/1941783004 . Cr-Commit-Position: refs/branch-heads/2704@{#343} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/6ba2ce7dcaf9ed453405c542dadec634810e47c5/media/blink/multibuffer_data_source_unittest.cc [modify] https://crrev.com/6ba2ce7dcaf9ed453405c542dadec634810e47c5/media/blink/resource_multibuffer_data_provider.cc [modify] https://crrev.com/6ba2ce7dcaf9ed453405c542dadec634810e47c5/media/blink/resource_multibuffer_data_provider.h
,
May 2 2016
,
May 4 2016
Tried the same on Linux 14.04 chrome version 51.0.2704.36 with below steps 1.Launched chrome with --enable-features=use-new-media-cache 2.Navigated to http://espn.go.com/nba/playoffs/2016/story/_/id/15385532/golden-state-warriors-were-right-push-73 and opened devtools with device mode enabled Console output was as shown in the screenshot hubbe@, Could you please let us know the expected output so as to verify this from test team end.
,
May 4 2016
The console output is irrelevant. The expected result is that the video is seekable. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dalecur...@chromium.org
, Apr 26 2016