New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 606963 link

Starred by 1 user
Status: Fixed
Owner:
█ nick@chromium.org
not working at Google anymore
Closed: May 2016
Cc:
tapted@chromium.org
afakhry@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Port task_manager_browsertest_util to new task manager

Project Member Reported by nick@chromium.org, Apr 26 2016 
We should port task_manager_browsertest_util.h to the new task manager, and make sure all the tests pass when we do this, and fix any bugs we encounter along the way.

I already have a pending fix for a IoThreadHelper issue: https://codereview.chromium.org/1918423002/

Also the following 8 tests show different title-formatting behavior between the old and new task manager. Not sure if these are new taskmanager bugs or features, but we need to address them all.

Three categories of failure:

"Extension: Packaged App Test" instead of "App: Packaged App Test".
  - TaskManagerBrowserTest.NoticeAppTabChanges
  - TaskManagerBrowserTest.NoticeAppTab

"Tab: Unmodified" instead of "App: ".
  - TaskManagerBrowserTest.NoticeHostedAppTabChanges
  - TaskManagerBrowserTest.NoticeHostedAppTabAfterReload

chrome-devtools:// URL without a prefix instead of "Tab: *"
  - TaskManagerBrowserTest.DevToolsNewDockedWindow
  - TaskManagerBrowserTest.DevToolsNewUndockedWindow
  - TaskManagerBrowserTest.DevToolsOldDockedWindow
  - TaskManagerBrowserTest.DevToolsOldUndockedWindow

Comment 1 by nick@chromium.org, Apr 26 2016

Summary: Port task_manager_browsertest_util to new task manager (was: Port task_manager_browesrtest_util to new task manager)
Project Member

Comment 2 by bugdroid1@chromium.org, May 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/399f1066416a5987a10a1bc1c3b0b7eaf40f88b5

commit 399f1066416a5987a10a1bc1c3b0b7eaf40f88b5
Author: nick <nick@chromium.org>
Date: Fri May 06 16:20:26 2016

Make old task manager tests work against new task manager.

Re-enable some disabled tests.

BUG= 606963 ,  444945 ,  528282 

Review-Url: https://codereview.chromium.org/1922683003
Cr-Commit-Position: refs/heads/master@{#392071}

[modify] https://crrev.com/399f1066416a5987a10a1bc1c3b0b7eaf40f88b5/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/399f1066416a5987a10a1bc1c3b0b7eaf40f88b5/chrome/browser/extensions/app_background_page_apitest.cc
[modify] https://crrev.com/399f1066416a5987a10a1bc1c3b0b7eaf40f88b5/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/399f1066416a5987a10a1bc1c3b0b7eaf40f88b5/chrome/browser/task_manager/task_manager.cc
[modify] https://crrev.com/399f1066416a5987a10a1bc1c3b0b7eaf40f88b5/chrome/browser/task_manager/task_manager_browsertest.cc
[modify] https://crrev.com/399f1066416a5987a10a1bc1c3b0b7eaf40f88b5/chrome/browser/task_manager/task_manager_browsertest_util.cc
[modify] https://crrev.com/399f1066416a5987a10a1bc1c3b0b7eaf40f88b5/chrome/browser/task_manager/task_manager_browsertest_util.h
[modify] https://crrev.com/399f1066416a5987a10a1bc1c3b0b7eaf40f88b5/chrome/browser/ui/browser_dialogs.h
[modify] https://crrev.com/399f1066416a5987a10a1bc1c3b0b7eaf40f88b5/chrome/browser/ui/cocoa/task_manager_mac.mm
[modify] https://crrev.com/399f1066416a5987a10a1bc1c3b0b7eaf40f88b5/chrome/browser/ui/task_manager/task_manager_table_model.h
[modify] https://crrev.com/399f1066416a5987a10a1bc1c3b0b7eaf40f88b5/chrome/browser/ui/views/browser_dialogs_views_mac.cc
[modify] https://crrev.com/399f1066416a5987a10a1bc1c3b0b7eaf40f88b5/chrome/browser/ui/views/new_task_manager_view.cc
[modify] https://crrev.com/399f1066416a5987a10a1bc1c3b0b7eaf40f88b5/chrome/browser/ui/views/new_task_manager_view.h
[modify] https://crrev.com/399f1066416a5987a10a1bc1c3b0b7eaf40f88b5/chrome/browser/ui/views/task_manager_view.cc
[modify] https://crrev.com/399f1066416a5987a10a1bc1c3b0b7eaf40f88b5/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, May 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25814be52a98fde4623a239cd847bfbbc54a6df0

commit 25814be52a98fde4623a239cd847bfbbc54a6df0
Author: nick <nick@chromium.org>
Date: Mon May 09 22:00:34 2016

Move MockWebContentsTaskManager into its own file.

[splitting apart task_manager_browsertest_util, part 1 of 6]

Move MockWebContentsTaskManager into its own file, and compile it
only into the browser_tests target.
Remove the mostly redundant task manager PanelBrowserTests
(these are actually interactive_ui_tests). Extend
TaskManagerBrowserTest.NoticePanel to replace lost coverage.

BUG= 606963 

Review-Url: https://codereview.chromium.org/1956813002
Cr-Commit-Position: refs/heads/master@{#392428}

[modify] https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc
[rename] https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0/chrome/browser/task_management/mock_web_contents_task_manager.cc
[rename] https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0/chrome/browser/task_management/mock_web_contents_task_manager.h
[modify] https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0/chrome/browser/task_management/providers/web_contents/background_contents_tag_browsertest.cc
[modify] https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0/chrome/browser/task_management/providers/web_contents/devtools_tag_browsertest.cc
[modify] https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0/chrome/browser/task_management/providers/web_contents/extension_tag_browsertest.cc
[modify] https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0/chrome/browser/task_management/providers/web_contents/subframe_task_browsertest.cc
[modify] https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0/chrome/browser/task_management/providers/web_contents/tab_contents_tag_browsertest.cc
[modify] https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0/chrome/browser/task_manager/task_manager_browsertest.cc
[modify] https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0/chrome/browser/ui/panels/panel_browsertest.cc
[modify] https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0/chrome/chrome_browser.gypi
[modify] https://crrev.com/25814be52a98fde4623a239cd847bfbbc54a6df0/chrome/chrome_tests.gypi
Project Member

Comment 6 by bugdroid1@chromium.org, May 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22bcc7727da7c2134dfa1a902c1f0080c145ad3e

commit 22bcc7727da7c2134dfa1a902c1f0080c145ad3e
Author: nick <nick@chromium.org>
Date: Tue May 10 18:43:41 2016

Move TaskManagerTester to the task_management directory.

[splitting apart task_manager_browsertest_util, part 5 of 6]

BUG= 606963 

Review-Url: https://codereview.chromium.org/1956943002
Cr-Commit-Position: refs/heads/master@{#392662}

[add] https://crrev.com/22bcc7727da7c2134dfa1a902c1f0080c145ad3e/chrome/browser/task_management/task_manager_tester.cc
[add] https://crrev.com/22bcc7727da7c2134dfa1a902c1f0080c145ad3e/chrome/browser/task_management/task_manager_tester.h
[modify] https://crrev.com/22bcc7727da7c2134dfa1a902c1f0080c145ad3e/chrome/browser/task_manager/legacy_task_manager_tester.cc
[modify] https://crrev.com/22bcc7727da7c2134dfa1a902c1f0080c145ad3e/chrome/browser/task_manager/legacy_task_manager_tester.h
[modify] https://crrev.com/22bcc7727da7c2134dfa1a902c1f0080c145ad3e/chrome/browser/task_manager/task_manager_browsertest.cc
[modify] https://crrev.com/22bcc7727da7c2134dfa1a902c1f0080c145ad3e/chrome/browser/task_manager/task_manager_browsertest_util.cc
[modify] https://crrev.com/22bcc7727da7c2134dfa1a902c1f0080c145ad3e/chrome/browser/task_manager/task_manager_browsertest_util.h
[modify] https://crrev.com/22bcc7727da7c2134dfa1a902c1f0080c145ad3e/chrome/browser/ui/task_manager/task_manager_table_model.h
[modify] https://crrev.com/22bcc7727da7c2134dfa1a902c1f0080c145ad3e/chrome/chrome_tests.gypi
Project Member

Comment 7 by bugdroid1@chromium.org, May 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50b06493bfa168ad10da21ca1067dcf1da5945b7

commit 50b06493bfa168ad10da21ca1067dcf1da5945b7
Author: nick <nick@chromium.org>
Date: Tue May 10 23:40:27 2016

[Part 6 of 6] Move browsertests and utils to task_management/ directory

Move task_manager_browsertest.cc and
task_manager_browsertest_util.{cc,h} to task_management directory.

[splitting apart task_manager_browsertest_util, part 6 of 6]

BUG= 606963 

Review-Url: https://codereview.chromium.org/1953383002
Cr-Commit-Position: refs/heads/master@{#392773}

[modify] https://crrev.com/50b06493bfa168ad10da21ca1067dcf1da5945b7/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/50b06493bfa168ad10da21ca1067dcf1da5945b7/chrome/browser/extensions/app_background_page_apitest.cc
[modify] https://crrev.com/50b06493bfa168ad10da21ca1067dcf1da5945b7/chrome/browser/prerender/prerender_browsertest.cc
[add] https://crrev.com/50b06493bfa168ad10da21ca1067dcf1da5945b7/chrome/browser/task_management/DEPS
[rename] https://crrev.com/50b06493bfa168ad10da21ca1067dcf1da5945b7/chrome/browser/task_management/task_manager_browsertest.cc
[rename] https://crrev.com/50b06493bfa168ad10da21ca1067dcf1da5945b7/chrome/browser/task_management/task_manager_browsertest_util.cc
[rename] https://crrev.com/50b06493bfa168ad10da21ca1067dcf1da5945b7/chrome/browser/task_management/task_manager_browsertest_util.h
[modify] https://crrev.com/50b06493bfa168ad10da21ca1067dcf1da5945b7/chrome/browser/task_management/task_manager_tester.h
[modify] https://crrev.com/50b06493bfa168ad10da21ca1067dcf1da5945b7/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
[modify] https://crrev.com/50b06493bfa168ad10da21ca1067dcf1da5945b7/chrome/chrome_tests.gypi

Comment 9 by nick@chromium.org, May 24 2016

Status: Fixed (was: Started)
►

Sign in to add a comment