Padding of network filters in the dev tools is uneven
Reported by
damien...@gmail.com,
Apr 26 2016
|
||||||||
Issue description
Chrome Version : 49.0.2623.108
OS Version: linux mint 17.3
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5: -
Firefox 4.x: NOT APPLICABLE
IE 7/8/9: NOT APPLICABLE
What steps will reproduce the problem?
1. open dev tools
2. got to network panel
3. hover a network filter icon
4. see uneven padding (short to the left,
What is the expected result?
Padding left and right of the button should be the same
What happens instead of that?
Left padding is shorter than the right one. See screenshot attached.
It's because the padding is `padding: 3px 6px 3px 3px`
Fix is to change the padding to be `padding: 3px 6px 3px 6px` for this line: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/devtools/front_end/ui/filter.css&q=ui/filter.css&sq=package:chromium&l=66
Original report on twitter:
https://twitter.com/dam_io/status/724624850933952512
UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/49.0.2623.108 Chrome/49.0.2623.108 Safari/537.36
,
Apr 28 2016
,
Apr 28 2016
Thank you for providing more feedback. Adding requester "brajkumar@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 29 2016
Able to reproduce the issue on Windows 7, Ubuntu 14.04 and Mac OS 10.11.4 using chrome latest stable M50-50.0.2661.94. Observed the padding of network filters in the dev tools is not aligned properly after zooming in. This is a non-regression issue seen from past M43-43.0.2325.0 from the time the networks filters is added in to dev tools. Hence marking it as untriaged. Thanks!
,
Apr 29 2016
Doing a git blame it looks it was introduced by this commit: https://chromium.googlesource.com/chromium/src/+/ea29b5a72dcf596beac73d708428357f3b9b6839 Changing the padding from `4px 6px 3px 6px` to `3px 6px 3px 3px`
,
Apr 29 2016
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 12 2016
This issue has been moved once and is lower than Pri-1. Removing the milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7157ec4fd149f677b0f6203398520bcd82739fb6 commit 7157ec4fd149f677b0f6203398520bcd82739fb6 Author: damien <damien@dam.io> Date: Wed Jul 13 15:14:05 2016 Fix uneven padding of network filters in the dev tools. Also makes the filter bar thinner. Screenshots: https://imgur.com/a/CClua First round of reviews here: https://codereview.chromium.org/2105023004 BUG= 606897 TEST=open network panel, padding for selected filter (XHR, JS, CSS) should be even (see screenshots) Review-Url: https://codereview.chromium.org/2150503002 Cr-Commit-Position: refs/heads/master@{#405154} [modify] https://crrev.com/7157ec4fd149f677b0f6203398520bcd82739fb6/AUTHORS [modify] https://crrev.com/7157ec4fd149f677b0f6203398520bcd82739fb6/third_party/WebKit/Source/devtools/front_end/ui/filter.css
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7157ec4fd149f677b0f6203398520bcd82739fb6 commit 7157ec4fd149f677b0f6203398520bcd82739fb6 Author: damien <damien@dam.io> Date: Wed Jul 13 15:14:05 2016 Fix uneven padding of network filters in the dev tools. Also makes the filter bar thinner. Screenshots: https://imgur.com/a/CClua First round of reviews here: https://codereview.chromium.org/2105023004 BUG= 606897 TEST=open network panel, padding for selected filter (XHR, JS, CSS) should be even (see screenshots) Review-Url: https://codereview.chromium.org/2150503002 Cr-Commit-Position: refs/heads/master@{#405154} [modify] https://crrev.com/7157ec4fd149f677b0f6203398520bcd82739fb6/AUTHORS [modify] https://crrev.com/7157ec4fd149f677b0f6203398520bcd82739fb6/third_party/WebKit/Source/devtools/front_end/ui/filter.css
,
Jul 29 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by brajkumar@chromium.org
, Apr 28 2016Labels: Needs-Feedback
89.9 KB
89.9 KB View Download