New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606876 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 593989



Sign in to add a comment

[MD settings] need URLs for passwords and languages

Project Member Reported by dschuyler@chromium.org, Apr 26 2016

Issue description

We have URLs for most of the MD settings. Let's get 
URLs for the main PasswordsAndForms and Languages
sections.

I would normally suggest 'passwords' and 'languages',
but those are already in use by legacy URLs. The
'passwords' url goes to the manage-passwords subpage.
The 'languages' url goes to the manage-langues subpage.

With those names going directly to subpages, can we
use something else for the top-level page?

Maybe 'passwordSettings' and 'languagesSettings'?

 
Components: UI>Settings
it probably makes more sense for chrome://md-settings/languages to jump to the section instead of a sub-page (the overlay opened by chrome://settings/languages includes all language & input method settings, so it corresponds better with the MD Settings section than any one sub-page).

Not sure if the same logic applies to passwords.
Owner: dschuyler@chromium.org
Status: Assigned (was: Untriaged)
Let's re-use the old URLs and make them go to the top-level sections. It's easy to get to the sub-pages from there anyway.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0770a99fd400547704026a9ab6b0f6e5c84aff60

commit 0770a99fd400547704026a9ab6b0f6e5c84aff60
Author: dschuyler <dschuyler@chromium.org>
Date: Fri May 06 19:22:12 2016

[MD settings] url change for passwords and languages

This CL changes the root section URLs for passwords and languages,
replacing those URLs previously used for managing passwords and
languages with URLs that have a manage* prefix. (It's shuffling
names around).

BUG= 606876 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1944293004
Cr-Commit-Position: refs/heads/master@{#392118}

[modify] https://crrev.com/0770a99fd400547704026a9ab6b0f6e5c84aff60/chrome/browser/resources/settings/settings_page/settings_router.js

Status: Fixed (was: Started)
I'm confused about the change in url for passwords.

chrome://settings/passwords takes you to a page you can edit your passwords.

I would expect the md-settings equivalent to take you to the same place.

The top level section "Passwords and forms" includes autofill in addition to passwords. If we need a URL for the top level section, I would suggest chrome://md-settings/forms. This is a new URL, so that the old one doesn't loose its meaning.

Sign in to add a comment