New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606869 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 438447
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 204974

Blocking:
issue 601854



Sign in to add a comment

breakpad should be able to handle hot/cold text segments

Project Member Reported by llozano@chromium.org, Apr 26 2016

Issue description

see issue 601854

breakpad (or crash dumper) is getting confused because linker generates 2 executable segments (hot/cold). 

Please fix breakpad to support this. Using separate hot/cold segments can improve performance (in particular when used with huge pages).

separate hot/cold segments are used in Google3. We assume breakpad for google3 has a fix for this issue.


 

Comment 1 by cmt...@chromium.org, Apr 26 2016

Note: this is really the same issue as https://bugs.chromium.org/p/chromium/issues/detail?id=438447.  You can find more detailed information there.
I am not convinced these are the same issues. 
In one case we are taking whole functions and putting them in a different .text section (.text_unlikely)
in the other case, we are splitting a function into cold and hot parts and that is what was breaking 438447...


Comment 3 by vapier@chromium.org, Apr 27 2016

Blockedon: 204974
Blocking: 601854
we know breakpad (at least dump_syms) has problems with multiple sections -- see issue 204974 where we tried to use -ffunction-sections but had to give up.

if hot/cold text segments are split up into multiple sections, i suspect it's the same problem.
Components: Internals>CrashReporting

Comment 5 by w...@chromium.org, Jul 13 2016

Mergedinto: 438447
Status: Duplicate (was: Untriaged)
Tentatively marking as a duplicate of issue 438447 since AFAICT that explains exactly the issue we're seeing, with more detail as to the potential cause.

Sign in to add a comment