Cronet LICENSE file is using hardcoded list of third party dependencies |
||||||
Issue descriptionCronet LICENSE file is created dynamically from the list of third_party dependencies. Currently the list of dependencies is hard-coded, and is not updated when dependencies change. It should be calculated dynamically using gn desc or some other way to traverse the dependencies tree.
,
Jun 13 2016
Misha is working on this, but this doesn't seem like high priority
,
Jul 12 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccb7680f041642d1c9f957c335996bd239e611c4 commit ccb7680f041642d1c9f957c335996bd239e611c4 Author: mef <mef@chromium.org> Date: Tue Jul 19 18:40:49 2016 [Cronet] Use gn desc to find third party licenses on Android. BUG= 606859 Review-Url: https://codereview.chromium.org/2150933007 Cr-Commit-Position: refs/heads/master@{#406331} [modify] https://crrev.com/ccb7680f041642d1c9f957c335996bd239e611c4/components/cronet/android/BUILD.gn [modify] https://crrev.com/ccb7680f041642d1c9f957c335996bd239e611c4/components/cronet/tools/cronet_licenses.py
,
Jul 19 2016
,
Jul 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61cbb51bc89158030e30b3f22a0c42dc9d67ad60 commit 61cbb51bc89158030e30b3f22a0c42dc9d67ad60 Author: mef <mef@chromium.org> Date: Tue Jul 19 22:27:23 2016 Revert of [Cronet] Use gn desc to find third party licenses on Android. (patchset #3 id:40001 of https://codereview.chromium.org/2150933007/ ) Reason for revert: Broke the builders by not finding the gn. Original issue's description: > [Cronet] Use gn desc to find third party licenses on Android. > > BUG= 606859 > > Committed: https://crrev.com/ccb7680f041642d1c9f957c335996bd239e611c4 > Cr-Commit-Position: refs/heads/master@{#406331} TBR=xunjieli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 606859 Review-Url: https://codereview.chromium.org/2162213002 Cr-Commit-Position: refs/heads/master@{#406398} [modify] https://crrev.com/61cbb51bc89158030e30b3f22a0c42dc9d67ad60/components/cronet/android/BUILD.gn [modify] https://crrev.com/61cbb51bc89158030e30b3f22a0c42dc9d67ad60/components/cronet/tools/cronet_licenses.py
,
Jul 20 2016
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fd5121f8fe912464b4f4d46dbb90d6209f59bf0 commit 0fd5121f8fe912464b4f4d46dbb90d6209f59bf0 Author: mef <mef@chromium.org> Date: Mon Jul 10 16:30:34 2017 [Cronet] Use gn desc to find third party licenses on Android. Filter out build/secondary/third_party dependencies to work around __main__.LicenseError: missing README.chromium or licenses.py SPECIAL_CASES entry in build/secondary/third_party/android_tools BUG= 606859 BUG= 710801 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2959303002 Cr-Commit-Position: refs/heads/master@{#485291} [modify] https://crrev.com/0fd5121f8fe912464b4f4d46dbb90d6209f59bf0/components/cronet/android/BUILD.gn [modify] https://crrev.com/0fd5121f8fe912464b4f4d46dbb90d6209f59bf0/tools/licenses.py
,
Jul 20 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, May 24 2016