New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606844 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
no longer active
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MD Feedback] Continuously typecheck on closure compilation builder.

Project Member Reported by apaci...@chromium.org, Apr 26 2016

Issue description

Components: Platform>Apps>Feedback
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20deb53f9df11c8a5967f34ac07d911138f0a153

commit 20deb53f9df11c8a5967f34ac07d911138f0a153
Author: apacible <apacible@chromium.org>
Date: Fri Jun 10 22:26:47 2016

[Md Feedback] Add initial content/strings to feedback-container element.

Changes include:
- Create feedback-container custom Polymer element with initial contents/strings and very minimal styling.
- String localization. The strings are primarily duplicates of the existing feedback, which avoids messiness if/when one set of strings are modified.
- Add newly used resources to polymer_resources.grdp.

WebUI interaction/functionality implemented later.

BUG= 615535 ,  606844 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2039593002
Cr-Commit-Position: refs/heads/master@{#399296}

[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/app/generated_resources.grd
[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/browser_resources.grd
[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/resources/md_feedback/feedback.html
[add] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/resources/md_feedback/feedback_container.html
[add] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/resources/md_feedback/feedback_container.js
[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/ui/webui/resources/polymer_resources.grdp

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20deb53f9df11c8a5967f34ac07d911138f0a153

commit 20deb53f9df11c8a5967f34ac07d911138f0a153
Author: apacible <apacible@chromium.org>
Date: Fri Jun 10 22:26:47 2016

[Md Feedback] Add initial content/strings to feedback-container element.

Changes include:
- Create feedback-container custom Polymer element with initial contents/strings and very minimal styling.
- String localization. The strings are primarily duplicates of the existing feedback, which avoids messiness if/when one set of strings are modified.
- Add newly used resources to polymer_resources.grdp.

WebUI interaction/functionality implemented later.

BUG= 615535 ,  606844 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2039593002
Cr-Commit-Position: refs/heads/master@{#399296}

[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/app/generated_resources.grd
[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/browser_resources.grd
[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/resources/md_feedback/feedback.html
[add] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/resources/md_feedback/feedback_container.html
[add] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/resources/md_feedback/feedback_container.js
[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/ui/webui/resources/polymer_resources.grdp

Status: Fixed (was: Assigned)

Sign in to add a comment