Suppress opening the launcher and show notifications instead when user installs apps from CWS |
||||||||||||||||||
Issue descriptionCurrently, when user installs apps from CWS, Chrome OS shows the launcher and displays a progress bar. We should suppress that, and instead show notifications which notifies the status (progress and completion). This is separated from b/28152696.
,
Apr 26 2016
We need to show 4 steps of notifications. - Waiting for download - Downloading - Installing - Install completed
,
Apr 26 2016
Jonny, which icon should we show in each notifications?
,
Apr 26 2016
What's the difference between downloading and installing? Can those two steps be merged into one? I just went through the Play install flow on Android and see the following: Waiting for download (grey): https://icons.googleplex.com/#icon=ic_file_download Downloading/installing (green, animated): https://icons.googleplex.com/#icon=ic_file_download Install completed (green): https://icons.googleplex.com/#icon=ic_play_install Reassigning to Sebastien for confirmation and assets.
,
Apr 26 2016
Chrome OS notification uses a different size for it's preview image, 40x40. Is there a spec to look at? I'm assuming we just don't want to drop the image like this in the notification. What do we do for Android notification when it comes to visual scaling ?
,
Apr 26 2016
Chrome OS notification spec here: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Notifications/spec I'll let Sebastien comment on how to scale Android notifications.
,
Apr 26 2016
After chatting w/ Sebastien I'm going to reassign back to me and do the following: - Finish spec'ing out Android-to-Chrome OS notification behavior - Review w/ Hiro/Alex/Jenn/UI-Review - Circle back w/ Sebastien on visual design guidelines (if necessary) Will update the bug when all that's done.
,
May 12 2016
Jonny, any progress?
,
May 12 2016
Based on offline discussion w/ yoshiki and sgabriel, for CWS downloads we will: - Supress the Chrome OS launcher - Display the same notification behavior as Play - Display Chrome OS-specific iconography which will be 2 icons to cover 3 states: -- Downloading -- Installing -- Install complete Reassigning to sgabriel for iconography.
,
May 12 2016
Quick update: - Suppress Chrome OS launcher - Display same notification behavior as Download, but update to include application name and "Install complete" state - Use Download notification iconography (https://folio.googleplex.com/chrome-ux-specs-and-sources/Cros%20System%20notification/Download_exports) sgabriel to add "Install complete" icon
,
May 12 2016
assets attached.
,
May 12 2016
,
May 12 2016
Thank you for finalizing a spec and assets! My tasks are: #1: [Luncher] Suppress Chrome OS launcher #2: [Donwload Manager] Suppress the current download completed notifications for downloads from CWS #3: [Package Manager] Instead of #2, show new completed notification with application name and "Install complete" state for downloads from CWS
,
May 19 2016
,
May 20 2016
+tapted, +mgiuca, +animohan Should we do this on other platforms too, now that the launcher is being disabled?
,
May 20 2016
Yeah I think a notification makes sense. But I'm not sure how easy it will be to do a progress bar, or how well that will integrate with the move towards native notifications (e.g. Issue 326539 for Mac). And there's already a channel open for the webstore to track install success/failure - should we perhaps have the webstore use the regular web notifications API? [progress bar might be tricky though..]
,
May 20 2016
Agreed with moving to notifications. I think it's OK to omit the progress bar -- just start / finish would be fine.
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd0c9080b93a56883be8eda1de4f09420422966a commit fd0c9080b93a56883be8eda1de4f09420422966a Author: yoshiki <yoshiki@chromium.org> Date: Wed Jun 01 08:14:42 2016 Show notification instead of opening app launcher after extension installation This patch suppresses opening the launcher and show app-installed notifications instead after user installs apps from CWS. Even with this patch, the app launcher is opened to show the installation progress. It'll be suppressed in the separated patch, BUG= 606843 TEST=manual tested Review-Url: https://codereview.chromium.org/1993583002 Cr-Commit-Position: refs/heads/master@{#397081} [modify] https://crrev.com/fd0c9080b93a56883be8eda1de4f09420422966a/chrome/app/generated_resources.grd [add] https://crrev.com/fd0c9080b93a56883be8eda1de4f09420422966a/chrome/app/theme/default_100_percent/common/notification_extension_installed.png [add] https://crrev.com/fd0c9080b93a56883be8eda1de4f09420422966a/chrome/app/theme/default_200_percent/common/notification_extension_installed.png [modify] https://crrev.com/fd0c9080b93a56883be8eda1de4f09420422966a/chrome/app/theme/theme_resources.grd [modify] https://crrev.com/fd0c9080b93a56883be8eda1de4f09420422966a/chrome/browser/ui/extensions/extension_install_ui_default.cc [add] https://crrev.com/fd0c9080b93a56883be8eda1de4f09420422966a/chrome/browser/ui/extensions/extension_installed_notification.cc [add] https://crrev.com/fd0c9080b93a56883be8eda1de4f09420422966a/chrome/browser/ui/extensions/extension_installed_notification.h [modify] https://crrev.com/fd0c9080b93a56883be8eda1de4f09420422966a/chrome/chrome_browser_ui.gypi [modify] https://crrev.com/fd0c9080b93a56883be8eda1de4f09420422966a/extensions/browser/api/app_runtime/app_runtime_api.cc [modify] https://crrev.com/fd0c9080b93a56883be8eda1de4f09420422966a/extensions/common/api/app_runtime.idl [modify] https://crrev.com/fd0c9080b93a56883be8eda1de4f09420422966a/extensions/common/constants.h [modify] https://crrev.com/fd0c9080b93a56883be8eda1de4f09420422966a/tools/metrics/histograms/histograms.xml
,
Jun 1 2016
,
Jun 1 2016
I have to do one more work: Suppressing the Chrome OS launcher when user installs an app.
,
Jun 1 2016
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc15c85fddf3fdad7624a4b0b9b5db557343e65d commit dc15c85fddf3fdad7624a4b0b9b5db557343e65d Author: yoshiki <yoshiki@chromium.org> Date: Mon Jun 06 03:16:20 2016 Not show the launcher during Chrome app installation We are currently showing notifications during Chrome app installation from CWS, so we don't need to show the launcher. BUG= 606843 TEST=manual test Review-Url: https://codereview.chromium.org/2032743003 Cr-Commit-Position: refs/heads/master@{#397963} [modify] https://crrev.com/dc15c85fddf3fdad7624a4b0b9b5db557343e65d/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc [modify] https://crrev.com/dc15c85fddf3fdad7624a4b0b9b5db557343e65d/chrome/browser/extensions/webstore_installer.cc [modify] https://crrev.com/dc15c85fddf3fdad7624a4b0b9b5db557343e65d/chrome/browser/extensions/webstore_installer.h
,
Jun 6 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by yoshiki@chromium.org
, Apr 26 2016