Issue 606818 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	mef@chromium.org
Closed:	Apr 2016
Cc:	ios-bugs-priority@chromium.org ios-bugs@chromium.org
Components:	Internals>Network>Library
EstimatedDays:	----
NextAction:	----
OS:	iOS
Pri:	1
Type:	Bug

[Cronet] iOS CronetBidirectionalStream should handle failure before Write task is executed on network thread

Project Member Reported by xunji...@chromium.org, Apr 26 2016

Issue description

components/cronet/ios/cronet_bidirectional_stream.cc

CronetBidirectionalStream::WriteData calls WriteDataOnNetworkThread to send data. However, if there is failure happened between the time when the task is posted and when the task is executed (for instance, if server terminates the connection), WriteDataOnNetworkThread will end up calling a null |bidi_stream_|. WriteDataOnNetworkThread should do a null check.

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ef58edc3a8a1aa123a75daa8045b6962da2f1c6

commit 5ef58edc3a8a1aa123a75daa8045b6962da2f1c6
Author: mef <mef@chromium.org>
Date: Fri Apr 29 22:34:53 2016

[Cronet] Add Hello World response to QuicTestServer and use it in bidirectional stream test.

BUG= 601972 
BUG= 606818 

Review-Url: https://codereview.chromium.org/1892423002
Cr-Commit-Position: refs/heads/master@{#390786}

[modify] https://crrev.com/5ef58edc3a8a1aa123a75daa8045b6962da2f1c6/components/cronet/ios/cronet_bidirectional_stream.cc
[modify] https://crrev.com/5ef58edc3a8a1aa123a75daa8045b6962da2f1c6/components/cronet/ios/test/cronet_bidirectional_stream_test.mm
[modify] https://crrev.com/5ef58edc3a8a1aa123a75daa8045b6962da2f1c6/components/cronet/ios/test/quic_test_server.cc
[modify] https://crrev.com/5ef58edc3a8a1aa123a75daa8045b6962da2f1c6/components/cronet/ios/test/quic_test_server.h

Comment 2 by mef@chromium.org, Apr 30 2016

Status: Fixed (was: Assigned)

►

Issue 606818 link

Issue metadata

[Cronet] iOS CronetBidirectionalStream should handle failure before Write task is executed on network thread

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 29 2016

Comment 1 Deleted

Comment 2 by mef@chromium.org, Apr 30 2016

Comment 2 Deleted

Sign in to add a comment