Issue 606809 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	joedow@chromium.org
Closed:	Jun 2018
Components:	Services>Chromoting
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	3
Type:	Bug

[Host] [Cleanup] Move test-echo logic from ClientSession.cc into a host extension

Project Member Reported by joedow@chromium.org, Apr 26 2016

Issue description

This item tracks the work to remove the special logic for the 'test-echo' message from clientsession.cc and put it into a hot extension.  We've already done work to move the gnubby auth messages into a host extension and need to do this to finish cleaning up the client session logic for message handling.

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/360ff39e17b9baf0ccd6c7d61cacf00c4bfa8bad

commit 360ff39e17b9baf0ccd6c7d61cacf00c4bfa8bad
Author: Joseph Arhar <jarhar@google.com>
Date: Fri Jun 23 22:36:23 2017

Move test echo logic to host extension

Bug:  606809 
Change-Id: Ifb8ce14df492bebf98a07b5f77fe99c413292a2b
Reviewed-on: https://chromium-review.googlesource.com/546315
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joseph Arhar <jarhar@google.com>
Cr-Commit-Position: refs/heads/master@{#482052}
[modify] https://crrev.com/360ff39e17b9baf0ccd6c7d61cacf00c4bfa8bad/remoting/host/BUILD.gn
[modify] https://crrev.com/360ff39e17b9baf0ccd6c7d61cacf00c4bfa8bad/remoting/host/client_session.cc
[modify] https://crrev.com/360ff39e17b9baf0ccd6c7d61cacf00c4bfa8bad/remoting/host/remoting_me2me_host.cc
[add] https://crrev.com/360ff39e17b9baf0ccd6c7d61cacf00c4bfa8bad/remoting/host/test_echo_extension.cc
[add] https://crrev.com/360ff39e17b9baf0ccd6c7d61cacf00c4bfa8bad/remoting/host/test_echo_extension.h
[add] https://crrev.com/360ff39e17b9baf0ccd6c7d61cacf00c4bfa8bad/remoting/host/test_echo_extension_session.cc
[add] https://crrev.com/360ff39e17b9baf0ccd6c7d61cacf00c4bfa8bad/remoting/host/test_echo_extension_session.h

Comment 2 by joedow@chromium.org, Jun 22 2018

Status: Verified (was: Assigned)

►

Issue 606809 link

Issue metadata

[Host] [Cleanup] Move test-echo logic from ClientSession.cc into a host extension

Issue description

Comment 1 by bugdroid1@chromium.org, Jun 23 2017

Comment 1 Deleted

Comment 2 by joedow@chromium.org, Jun 22 2018

Comment 2 Deleted

Sign in to add a comment