Notification popping in the center with multiprofile |
|||||||||||
Issue descriptionChrome OS version 51.0.2704.26/8172.12.0 samus Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1) Login in two profiles (2) Take a screen shot to trigger a notification (3) Expected Result: Notifications seen at the right bottom corner Actual Result:Seeing is popping in the center How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always with multiprofile login What is the impact to the user, and is there a workaround? If so, what is it? Please provide any additional information below. Attach a screen shot or log if possible.
,
Apr 26 2016
I seem to recall seeing issues with this breifly but have not seen any recently in ToT. I have not been in the loop on any major changes to this code recently. +yosheki@ who has made some recent changes and may have an idea.
,
Apr 26 2016
+xdai@ for multi profile related issue.
,
Apr 26 2016
Let me take a look
,
May 3 2016
not reproduced on daisy(chromeOS:8172.22.0 / 51.0.2704.35 )
,
May 9 2016
It happens only on Pixel and looks a high DPI related issue.
,
May 9 2016
+oshima: do you have any idea about related hi-dpi issue?
,
May 24 2016
I found the cause.
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/331d88b5161e3c77e302722198bd4bf9180bd5a4 commit 331d88b5161e3c77e302722198bd4bf9180bd5a4 Author: yoshiki <yoshiki@chromium.org> Date: Wed May 25 03:58:26 2016 Update cached height for popup notifications after shelf alignment changes This patch fixes the misaligned notification issue. See the bug for detail. BUG= 606808 TEST=manual tested Review-Url: https://codereview.chromium.org/2000303003 Cr-Commit-Position: refs/heads/master@{#395795} [modify] https://crrev.com/331d88b5161e3c77e302722198bd4bf9180bd5a4/ash/system/tray/system_tray.cc
,
May 26 2016
,
May 26 2016
BTW, should we need to merge the patch to the M52 (or perhaps M51) branch?
,
May 26 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ba88c5aad6bb2da59d677abe443d0b700fbc5b8 commit 7ba88c5aad6bb2da59d677abe443d0b700fbc5b8 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Thu May 26 05:34:56 2016 Update cached height for popup notifications after shelf alignment changes This patch fixes the misaligned notification issue. See the bug for detail. BUG= 606808 TEST=manual tested Review-Url: https://codereview.chromium.org/2000303003 Cr-Commit-Position: refs/heads/master@{#395795} (cherry picked from commit 331d88b5161e3c77e302722198bd4bf9180bd5a4) Review URL: https://codereview.chromium.org/2012183002 . Cr-Commit-Position: refs/branch-heads/2743@{#74} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/7ba88c5aad6bb2da59d677abe443d0b700fbc5b8/ash/system/tray/system_tray.cc
,
May 26 2016
,
May 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5b3eea1b581ba3a276337c3491c62d848bc2625 commit d5b3eea1b581ba3a276337c3491c62d848bc2625 Author: yoshiki <yoshiki@chromium.org> Date: Mon May 30 04:27:59 2016 Add a test of updating cached height for popup notifications This patch adds a test for the recent change: crrev.com/331d88b5161e3c77e302722198bd4bf9180bd5a4. BUG= 606808 TEST=test passes Review-Url: https://codereview.chromium.org/2008993004 Cr-Commit-Position: refs/heads/master@{#396674} [modify] https://crrev.com/d5b3eea1b581ba3a276337c3491c62d848bc2625/ash/system/tray/system_tray_unittest.cc [modify] https://crrev.com/d5b3eea1b581ba3a276337c3491c62d848bc2625/ash/system/web_notification/ash_popup_alignment_delegate.h [modify] https://crrev.com/d5b3eea1b581ba3a276337c3491c62d848bc2625/ash/system/web_notification/web_notification_tray.cc [modify] https://crrev.com/d5b3eea1b581ba3a276337c3491c62d848bc2625/ash/system/web_notification/web_notification_tray.h
,
Jun 7 2016
chromeOs:8350.21.0/chrome:52.0.2743.28 |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by peter@chromium.org
, Apr 26 2016