New issue
Advanced search Search tips

Issue 606791 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Blamelist showed all CLs twice on all webkit builders.

Project Member Reported by joh...@chromium.org, Apr 26 2016

Issue description

The blame list on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/45802 shows all CLs twice. I've seen this happen on other Android bots, though I'm not sure if it affects all of them.

Perhaps it's listing all CLs in src/ and src/third_party/WebKit/, without realizing that they're now the same git repository?
 
Owner: bpastene@chromium.org
Status: Assigned (was: Untriaged)
Interesting. It looks like this occurs on all tester-only bots on the webkit waterfall, not just the android one. The tester is probably inheriting the blame list from its parent builder along with the blame list of the actual revision it's testing.

I'm not seeing this happen on any other builder-tester splits on other waterfalls. Probably something in the webkit's master configuration. I can take a look when I get a chance.

Comment 2 by benhenry@google.com, Apr 27 2016

Components: Infra>Client>Android
Labels: -Infra-Android

Comment 3 by stip@chromium.org, Aug 4 2016

Components: -Infra>Client>Android Infra>Platform>Buildbot
Owner: estaab@chromium.org
This is for all webkit, not just android: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/21656

Reassigning to Infra>Platform to triage.
Cc: estaab@chromium.org
Components: Blink>Infra
Owner: ----
Status: Available (was: Assigned)
Summary: Blamelist shows all CLs twice on all webkit builders (was: Blamelist shows all CLs twice on Android bots)
Labels: -OS-Android -Pri-1 Pri-2
Summary: Blamelist shows all CLs twice on all webkit builders. (was: Blamelist shows all CLs twice on all webkit builders)
To clarify, the place where there are duplicates is after "All Changes:", but there are *not* duplicates in the  "blamelist" build property which lists email addresses of authors of commits.

This isn't happening for all builders; I just looked at the latest build for all builders on the webkit waterfall and I observed this on three builders: WebKit Mac10.10, WebKit Mac10.11, WebKit Mac10.11 (dbg).


Screenshot from 2016-09-16 10:31:00.png
85.1 KB View Download

Comment 6 by estaab@chromium.org, Jan 23 2017

Cc: stip@chromium.org skyos...@chromium.org d...@chromium.org
 Issue 343982  has been merged into this issue.

Comment 7 by estaab@chromium.org, Jan 23 2017

I don't see this happening on this webkit builder anymore. Is this still a problem?

Comment 8 by stip@chromium.org, Feb 10 2017

Cc: -stip@chromium.org
Labels: -Pri-2 Pri-3
Summary: Blamelist showed all CLs twice on all webkit builders. (was: Blamelist shows all CLs twice on all webkit builders.)

Comment 10 by no...@chromium.org, Jun 16 2018

Status: Fixed (was: Available)
blamelist computation algorithm has changed. reopen if still occurs.

Sign in to add a comment