New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606784 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Increase internal read buffer size for SPDY upload

Project Member Reported by xunji...@chromium.org, Apr 26 2016

Issue description

The internal read buffer for upload is 14520 bytes for QUIC, 2852 bytes for SPDY, and 16384 bytes for normal stream. SPDY's buffer size is too small compared to normal stream and QUIC's. This CL increases the read buffer to 16384 so it is comparable to those of the other two implementations. This will make it easier for net embedders to configure uploads to work well across different transports.



 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/179a6e73881175ac0b7b977c12a9c376c254ff4f

commit 179a6e73881175ac0b7b977c12a9c376c254ff4f
Author: xunjieli <xunjieli@chromium.org>
Date: Tue Apr 26 19:47:45 2016

Increase read buffer size for SPDY upload

The internal read buffer for upload is 14520 for QUIC, 2852 for
SPDY, and 16384 for normal stream. SPDY is too small compared
to normal stream and QUIC. This CL increases the read buffer to
16384 so it is comparable to the other two implementations.
This will make it easier for net embedders to configure uploads to
work well across different transports.

This CL additionally updates flow control tests so they take
into account the new buffer size when zeroing out window size.

BUG= 606784 

Review URL: https://codereview.chromium.org/1914663002

Cr-Commit-Position: refs/heads/master@{#389856}

[modify] https://crrev.com/179a6e73881175ac0b7b977c12a9c376c254ff4f/net/spdy/spdy_http_stream.cc
[modify] https://crrev.com/179a6e73881175ac0b7b977c12a9c376c254ff4f/net/spdy/spdy_http_stream.h
[modify] https://crrev.com/179a6e73881175ac0b7b977c12a9c376c254ff4f/net/spdy/spdy_network_transaction_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment