New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606779 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 608064
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

BackgroundApplicationListModelTest.ExplicitTest crashes under Dr. Memory

Project Member Reported by glider@chromium.org, Apr 26 2016

Issue description

See https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/4702/steps/memory%20test%3A%20unit/logs/stdio:

[ RUN      ] BackgroundApplicationListModelTest.ExplicitTest
~~Dr.M~~ 
~~Dr.M~~ Error #1: UNADDRESSABLE ACCESS: reading 0x0000009f-0x000000a3 4 byte(s)
~~Dr.M~~ # 0 ExtensionService::NotifyExtensionLoaded                                    [chrome\browser\extensions\extension_service.cc:1035]
~~Dr.M~~ # 1 ExtensionService::AddExtension                                             [chrome\browser\extensions\extension_service.cc:1521]
~~Dr.M~~ # 2 BackgroundApplicationListModelTest_ExplicitTest_Test::TestBody             [chrome\browser\background\background_application_list_model_unittest.cc:167]
~~Dr.M~~ # 3 testing::internal::HandleExceptionsInMethodIfSupported<>                   [testing\gtest\src\gtest.cc:2458]
~~Dr.M~~ Note: @0:11:55.958 in thread 2464
~~Dr.M~~ Note: instruction: call   0x5c(%edx) %esp -> %esp 0xfffffffc(%esp)
Backtrace:
	ExtensionService::NotifyExtensionLoaded [0x041C93CF+319] (c:\b\build\slave\drm-cr\build\src\chrome\browser\extensions\extension_service.cc:1035)
	ExtensionService::AddExtension [0x041C5A5C+972] (c:\b\build\slave\drm-cr\build\src\chrome\browser\extensions\extension_service.cc:1521)
	BackgroundApplicationListModelTest_ExplicitTest_Test::TestBody [0x018CF6EB+683] (c:\b\build\slave\drm-cr\build\src\chrome\browser\background\background_application_list_model_unittest.cc:168)
	testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x02D99940+32] (c:\b\build\slave\drm-cr\build\src\testing\gtest\src\gtest.cc:2460)
	testing::Test::Run [0x02DABF1D+93] (c:\b\build\slave\drm-cr\build\src\testing\gtest\src\gtest.cc:2474)
	testing::TestInfo::Run [0x02DAC115+133] (c:\b\build\slave\drm-cr\build\src\testing\gtest\src\gtest.cc:2660)
	testing::TestCase::Run [0x02DABFFF+143] (c:\b\build\slave\drm-cr\build\src\testing\gtest\src\gtest.cc:2774)
	testing::internal::UnitTestImpl::RunAllTests [0x02DAC48E+462] (c:\b\build\slave\drm-cr\build\src\testing\gtest\src\gtest.cc:4647)
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x02D999D0+32] (c:\b\build\slave\drm-cr\build\src\testing\gtest\src\gtest.cc:2460)
	testing::UnitTest::Run [0x02DAC25E+190] (c:\b\build\slave\drm-cr\build\src\testing\gtest\src\gtest.cc:4255)
	base::TestSuite::Run [0x02BE7C13+163] (c:\b\build\slave\drm-cr\build\src\base\test\test_suite.cc:230)
	base::internal::Invoker<base::IndexSequence<0>,base::internal::BindState<base::internal::RunnableAdapter<int (__thiscall content::UnitTestTestSuite::*)(void)>,int __cdecl(content::UnitTestTestSuite *),base::internal::UnretainedWrapper<content::UnitTestTes [0x02DF3479+25] (c:\b\build\slave\drm-cr\build\src\base\bind_internal.h:372)
	base::`anonymous namespace'::LaunchUnitTestsInternal [0x02BD4F6F+751] (c:\b\build\slave\drm-cr\build\src\base\test\launcher\unit_test_launcher.cc:244)
	base::LaunchUnitTests [0x02BD4BC6+70] (c:\b\build\slave\drm-cr\build\src\base\test\launcher\unit_test_launcher.cc:445)
	main [0x02DF3526+150] (c:\b\build\slave\drm-cr\build\src\chrome\test\base\run_all_unittests.cc:21)
	__scrt_common_main_seh [0x0524008E+255] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:255)
	BaseThreadInitThunk [0x750F337A+18]
	RtlInitializeExceptionChain [0x775092B2+99]
	RtlInitializeExceptionChain [0x77509285+54]
~~Dr.M~~ WARNING: application exited with abnormal code 0xc0000005
04:30:17 common.py [INFO] process ended, did not time out
04:30:17 common.py [INFO] flushing stdout
04:30:17 common.py [INFO] collecting result code
04:30:17 common.py [ERROR] E:\b\build\slave\chromium-dbg-win-drmemory\build\src\tools\valgrind\..\..\third_party\drmemory\unpacked\bin\drmemory.exe exited with non-zero result code -1073741819
04:30:17 drmemory_analyze.py [INFO] Found 1 error reports
04:30:17 drmemory_analyze.py [INFO] Report #1
### BEGIN MEMORY TOOL REPORT (error hash=#E1E8D36CAD2C4174#)
UNADDRESSABLE ACCESS: reading 0x0000009f-0x000000a3 4 byte(s)
# 0 ExtensionService::NotifyExtensionLoaded                                    [chrome\browser\extensions\extension_service.cc:1035]
# 1 ExtensionService::AddExtension                                             [chrome\browser\extensions\extension_service.cc:1521]
# 2 BackgroundApplicationListModelTest_ExplicitTest_Test::TestBody             [chrome\browser\background\background_application_list_model_unittest.cc:167]
# 3 testing::internal::HandleExceptionsInMethodIfSupported<>                   [testing\gtest\src\gtest.cc:2458]
Note: @0:11:55.958 in thread 2464
Note: instruction: call   0x5c(%edx) %esp -> %esp 0xfffffffc(%esp)
Suppression (error hash=#E1E8D36CAD2C4174#):
  For more info on using suppressions see http://dev.chromium.org/developers/how-tos/using-drmemory#TOC-Suppressing-error-reports-from-the-
{
UNADDRESSABLE ACCESS
name=<insert_a_suppression_name_here>
*!ExtensionService::NotifyExtensionLoaded
*!ExtensionService::AddExtension
*!BackgroundApplicationListModelTest_ExplicitTest_Test::TestBody
*!testing::internal::HandleExceptionsInMethodIfSupported<>
}
### END MEMORY TOOL REPORT (error hash=#E1E8D36CAD2C4174#)


The crashes started showing up since https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/4627 (regression range 387840-387853), but note that there's an open issue 165458, which may also be relevant.

Tentatively assigning to Andrew, who owns the previous bug. 
 

Comment 1 by glider@chromium.org, Apr 26 2016

A similar report from https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%282%29/builds/10567/steps/memory%20test%3A%20unit/logs/stdio:

[ RUN      ] ExtensionContextMenuModelTest.ExtensionContextUninstall
~~Dr.M~~ 
~~Dr.M~~ Error #1: UNADDRESSABLE ACCESS beyond heap bounds: reading 0x0f4121e0-0x0f4121e4 4 byte(s)
~~Dr.M~~ # 0 ExtensionService::NotifyExtensionLoaded                                    [chrome\browser\extensions\extension_service.cc:1035]
~~Dr.M~~ # 1 ExtensionService::AddExtension                                             [chrome\browser\extensions\extension_service.cc:1521]
~~Dr.M~~ # 2 extensions::ExtensionContextMenuModelTest::AddExtensionWithHostPermission  [chrome\browser\extensions\extension_context_menu_model_unittest.cc:174]
~~Dr.M~~ # 3 extensions::ExtensionContextMenuModelTest::AddExtension                    [chrome\browser\extensions\extension_context_menu_model_unittest.cc:150]
~~Dr.M~~ # 4 extensions::ExtensionContextMenuModelTest_ExtensionContextUninstall_Test::TestBody [chrome\browser\extensions\extension_context_menu_model_unittest.cc:471]
~~Dr.M~~ # 5 testing::internal::HandleExceptionsInMethodIfSupported<>                   [testing\gtest\src\gtest.cc:2458]
~~Dr.M~~ Note: @0:08:28.228 in thread 1576
~~Dr.M~~ Note: next higher malloc: 0x0f412208-0x0f412238
~~Dr.M~~ Note: prev lower malloc:  0x0f412150-0x0f412170
~~Dr.M~~ Note: 0x0f4121e0-0x0f4121e4 is 32 byte(s) beyond memory 0x0f412190-0x0f4121c0 that was freed here:
~~Dr.M~~ Note: # 0 replace_operator_delete_nothrow                                         [d:\drmemory_package\common\alloc_replace.c:2974]
~~Dr.M~~ Note: # 1 base.dll!base::DictionaryValue::Set                                     [base\values.cc:425]
~~Dr.M~~ Note: # 2 base.dll!base::DictionaryValue::Set                                     [base\values.cc:428]
~~Dr.M~~ Note: # 3 extensions::ExtensionPrefs::UpdateExtensionPref                         [extensions\browser\extension_prefs.cc:443]
~~Dr.M~~ Note: # 4 extensions::ExtensionPrefs::SetExtensionPrefPermissionSet               [extensions\browser\extension_prefs.cc:636]
~~Dr.M~~ Note: # 5 extensions::ExtensionPrefs::SetActivePermissions                        [extensions\browser\extension_prefs.cc:983]
~~Dr.M~~ Note: instruction: mov    (%edi) -> %edx
~~Dr.M~~ 
~~Dr.M~~ Error #2: UNADDRESSABLE ACCESS: executing 0x2e736665-0x2e736666 1 byte(s)
~~Dr.M~~ # 0 <not in a module>                                            (0x2e736665)
~~Dr.M~~ # 1 ExtensionService::NotifyExtensionLoaded                                    [chrome\browser\extensions\extension_service.cc:1035]
~~Dr.M~~ # 2 ExtensionService::AddExtension                                             [chrome\browser\extensions\extension_service.cc:1521]
~~Dr.M~~ # 3 extensions::ExtensionContextMenuModelTest::AddExtensionWithHostPermission  [chrome\browser\extensions\extension_context_menu_model_unittest.cc:174]
~~Dr.M~~ # 4 extensions::ExtensionContextMenuModelTest::AddExtension                    [chrome\browser\extensions\extension_context_menu_model_unittest.cc:150]
~~Dr.M~~ # 5 extensions::ExtensionContextMenuModelTest_ExtensionContextUninstall_Test::TestBody [chrome\browser\extensions\extension_context_menu_model_unittest.cc:471]
~~Dr.M~~ # 6 testing::internal::HandleExceptionsInMethodIfSupported<>                   [testing\gtest\src\gtest.cc:2458]
~~Dr.M~~ Note: @0:08:28.290 in thread 1576
~~Dr.M~~ Note: instruction: outs   %ds:(%esi) %dx %esi -> %esi
Backtrace:
	(No symbol) [0x2E736665]
	ExtensionService::NotifyExtensionLoaded [0x04611172+322] (c:\b\build\slave\drm-cr\build\src\chrome\browser\extensions\extension_service.cc:1035)
	ExtensionService::AddExtension [0x0460D7FC+972] (c:\b\build\slave\drm-cr\build\src\chrome\browser\extensions\extension_service.cc:1521)
	extensions::ExtensionContextMenuModelTest::AddExtensionWithHostPermission [0x02015B14+932] (c:\b\build\slave\drm-cr\build\src\chrome\browser\extensions\extension_context_menu_model_unittest.cc:175)
	extensions::ExtensionContextMenuModelTest::AddExtension [0x02015729+57] (c:\b\build\slave\drm-cr\build\src\chrome\browser\extensions\extension_context_menu_model_unittest.cc:150)
	extensions::ExtensionContextMenuModelTest_ExtensionContextUninstall_Test::TestBody [0x02018FBF+79] (c:\b\build\slave\drm-cr\build\src\chrome\browser\extensions\extension_context_menu_model_unittest.cc:471)
	testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x031E1610+32] (c:\b\build\slave\drm-cr\build\src\testing\gtest\src\gtest.cc:2460)
	testing::Test::Run [0x031F3BED+93] (c:\b\build\slave\drm-cr\build\src\testing\gtest\src\gtest.cc:2474)
	testing::TestInfo::Run [0x031F3DE5+133] (c:\b\build\slave\drm-cr\build\src\testing\gtest\src\gtest.cc:2660)
	testing::TestCase::Run [0x031F3CCF+143] (c:\b\build\slave\drm-cr\build\src\testing\gtest\src\gtest.cc:2774)
	testing::internal::UnitTestImpl::RunAllTests [0x031F415E+462] (c:\b\build\slave\drm-cr\build\src\testing\gtest\src\gtest.cc:4647)
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x031E16A0+32] (c:\b\build\slave\drm-cr\build\src\testing\gtest\src\gtest.cc:2460)
	testing::UnitTest::Run [0x031F3F2E+190] (c:\b\build\slave\drm-cr\build\src\testing\gtest\src\gtest.cc:4255)
	base::TestSuite::Run [0x0302F8E3+163] (c:\b\build\slave\drm-cr\build\src\base\test\test_suite.cc:230)
	base::internal::Invoker<base::IndexSequence<0>,base::internal::BindState<base::internal::RunnableAdapter<int (__thiscall content::UnitTestTestSuite::*)(void)>,int __cdecl(content::UnitTestTestSuite *),base::internal::UnretainedWrapper<content::UnitTestTes [0x0323B149+25] (c:\b\build\slave\drm-cr\build\src\base\bind_internal.h:372)
	base::`anonymous namespace'::LaunchUnitTestsInternal [0x0301CC3F+751] (c:\b\build\slave\drm-cr\build\src\base\test\launcher\unit_test_launcher.cc:244)
	base::LaunchUnitTests [0x0301C896+70] (c:\b\build\slave\drm-cr\build\src\base\test\launcher\unit_test_launcher.cc:445)
	main [0x0323B1F6+150] (c:\b\build\slave\drm-cr\build\src\chrome\test\base\run_all_unittests.cc:21)
	__scrt_common_main_seh [0x05687DFE+255] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:255)
	BaseThreadInitThunk [0x764A337A+18]
	RtlInitializeExceptionChain [0x773092B2+99]
	RtlInitializeExceptionChain [0x77309285+54]
~~Dr.M~~ WARNING: application exited with abnormal code 0xc0000005

Comment 2 by glider@chromium.org, Apr 26 2016

The regression range for the previous comment is 389563-389666, which doesn't add much information.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4709131156d61963c412d67d3b28394e972e180

commit b4709131156d61963c412d67d3b28394e972e180
Author: glider <glider@chromium.org>
Date: Tue Apr 26 15:19:51 2016

Disable BackgroundApplicationListModelTest.ExplicitTest everywhere.
It crashes on too many platforms.

BUG= 606779 ,165458
TBR=atwilson@chromium.org

Review URL: https://codereview.chromium.org/1917043006

Cr-Commit-Position: refs/heads/master@{#389784}

[modify] https://crrev.com/b4709131156d61963c412d67d3b28394e972e180/chrome/browser/background/background_application_list_model_unittest.cc

Mergedinto: 608064
Status: Duplicate (was: Assigned)

Sign in to add a comment