New issue
Advanced search Search tips

Issue 606772 link

Starred by 3 users
Status: Fixed
Owner:
pwnall@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug-Regression



Sign in to add a comment

printf() method used without forcing sqlite 3.8.3

Project Member Reported by the...@opera.com, Apr 26 2016 
Version: 51.0.2687.0
OS: Any

What steps will reproduce the problem?
(1) Build chromium with system sqlite older than 3.8.3
(2) Run with a profile containing history database version 29 or older

What is the expected output?
Expecting migration of history database from version 29 to 30 to succeed

What do you see instead?
sql error: no such function: printf (code 1): , while compiling: UPDATE downloads SET guid = printf("%08X-%s-%s-%s-%s", id, hex(randomblob(2)), hex(randomblob(2)), hex(randomblob(2)), hex(randomblob(6)))
Project Member

Comment 1 by bugdroid1@chromium.org, May 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbbc7ddf2e5c2f3f72718bd5e807fa3e6ccad641

commit dbbc7ddf2e5c2f3f72718bd5e807fa3e6ccad641
Author: the_jk <the_jk@opera.com>
Date: Mon May 16 09:43:40 2016

Make SQL in DownloadDatabase SQLite pre 3.8.3 compatible

printf() was added in SQLite 3.8.3 so need to use other older
methods to generate the GUID.
third_party/sqlite/sqlite.gyp lists 3.6.1 as required version at the
time of writing

BUG= 606772 

Review-Url: https://codereview.chromium.org/1897153005
Cr-Commit-Position: refs/heads/master@{#393813}

[modify] https://crrev.com/dbbc7ddf2e5c2f3f72718bd5e807fa3e6ccad641/components/history/core/browser/download_database.cc
[modify] https://crrev.com/dbbc7ddf2e5c2f3f72718bd5e807fa3e6ccad641/components/history/core/browser/history_backend_db_unittest.cc

Comment 2 by pwnall@chromium.org, Feb 6 2018

Owner: pwnall@chromium.org
Seems like shess@ fixed this in https://crrev.com/1897153005. Also, we now require SQLite 3.14 for iOS, and ship SQLite 3.22 for all other platforms.

Comment 3 by pwnall@chromium.org, Feb 6 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment