Issue metadata
Sign in to add a comment
|
blimp_engine_bundle flakily fails (probably due to underspecified deps) |
||||||||||||||||||||||
Issue descriptionhttps://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/218393/steps/compile%20%28with%20patch%29/logs/stdio FAILED: python ../../blimp/tools/bundle-engine.py --build-dir /b/build/slave/linux/build/src/out/Release --dockerfile /b/build/slave/linux/build/src/blimp/engine/Dockerfile --startup-script /b/build/slave/linux/build/src/blimp/engine/start_engine.sh --manifest /b/build/slave/linux/build/src/blimp/engine/engine-manifest.txt --output /b/build/slave/linux/build/src/out/Release/blimp_engine_bundle.tar.gz Failed to create tarball: tar: icudtl.dat: file changed as we read it I guess the rule needs icudtl.dat but doesn't list that as a dependency? (In general, "bundle" scripts are easier to get right build-wise if all the things they're supposed to bundle up are passed as arguments to the script on the command line. If that isn't feasible for some reason, then it's probably a good idea to make the script write a depfile containing all the files it depends on, so it can rerun if any of those files change. It also needs explicit deps to make sure a clobber build works.)
,
Apr 26 2016
We've had the same issue before, but we thought it was fixed. https://bugs.chromium.org/p/chromium/issues/detail?id=587247 Wez, did anything change in BUILD.gn definitions recently?
,
Apr 26 2016
,
Apr 26 2016
We had a problem with blimp_engine_bundle not depending on blimp_engine, which was fixed in crrev.com/1830493002. Brett recommended fixing up the bundle step to explicitly list the inputs rather than rely on these dependencies, in part because some are pulled in via data_deps - I've got a bug assigned to get that done, so I'll de-dupe this bug to that one and bump the priority. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nyquist@chromium.org
, Apr 26 2016