New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 606762 link

Starred by 0 users
Status: Duplicate
Merged: issue 606760
Owner: ----
Closed: May 2016
Cc:
hablich@chromium.org
█ brettw@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4.4%-40.2% regression in thread_times.key_mobile_sites_smooth at 389414:389553

Project Member Reported by pmeenan@chromium.org, Apr 26 2016 
See the link to graphs below.
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Apr 26 2016 


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@389494         0.339864    0.014302    18          good
chromium@389507         0.323287    0.047598    18          bad

Bisect job ran on: android_nexus5_perf_bisect
Bug ID: 606762

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.key_mobile_sites_smooth
Test Metric: thread_other_cpu_time_per_frame/thread_other_cpu_time_per_frame
Relative Change: 4.01%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/3625
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9014314009345404320


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5895448145952768

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 3 by pmeenan@chromium.org, Apr 26 2016 

re-kicked with a different test and wider range
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Apr 27 2016

Cc: jochen@chromium.org
Owner: jochen@chromium.org

=== Auto-CCing suspected CL author jochen@chromium.org ===

Hi jochen@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of [GN] Define USE_EABI_HARDFLOAT=1 when arm_float_abi=="hard". (patchset #1 id:1 of https://codereview.chromium.org/1839763003/ )
Author  : jochen
Commit description:
  
Reason for revert:
Appears to break Android  crbug.com/604422 

Original issue's description:
> [GN] Define USE_EABI_HARDFLOAT=1 when arm_float_abi=="hard".
>
> Add this define to the config used for mksnapshot. This fixes a bug
> where certain applications would fail at runtime on Chromecast.
>
> BUG= 592660 
> LOG=Y
> Bug: internal b/27495984
>
> Test: Formerly broken Cast apps load and run as expected.
>
> Committed: https://crrev.com/86357d5235ceba61c151f0b6e509bcb365860454
> Cr-Commit-Position: refs/heads/master@{#35183}

TBR=dpranke@chromium.org,alokp@chromium.org,titzer@chromium.org,slan@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 592660 , 604422 
LOG=n

Review URL: https://codereview.chromium.org/1906373002

Cr-Commit-Position: refs/heads/master@{#35725}
Commit  : 0714485cbb4ea72359ae9ec73f9fb6c825a933e1
Date    : Fri Apr 22 11:19:49 2016


===== TESTED REVISIONS =====
Revision                Mean Value  Std. Dev.   Num Values  Good?
chromium@389413         0.253019    0.021982    5           good
chromium@389449         0.22991     0.004955    5           good
chromium@389458         0.25424     0.019137    5           good
chromium@389463         0.245892    0.010223    5           good
chromium@389465         0.239562    0.005898    5           good
chromium@389466         0.244049    0.012166    8           good
chromium@389466,v8@5c8609de9d0.238632    0.009797    5           good
chromium@389466,v8@0714485cbb0.34039     0.013143    5           bad         <-
chromium@389466,v8@9ce87d67720.340298    0.017747    5           bad
chromium@389466,v8@530cf26bb20.335343    0.022431    5           bad
chromium@389466,v8@4b580cad0c0.3361      0.008772    5           bad
chromium@389466,v8@6d9c4c86630.319037    0.036135    8           bad
chromium@389467         0.337935    0.017316    8           bad
chromium@389484         0.330226    0.02427     5           bad
chromium@389554         0.321081    0.012241    5           bad

Bisect job ran on: android_nexus5_perf_bisect
Bug ID: 606762

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.key_mobile_sites_smooth
Test Metric: thread_other_cpu_time_per_frame/thread_other_cpu_time_per_frame
Relative Change: 26.90%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/3626
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9014306969848158784


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5819066447560704

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 5 by jochen@chromium.org, Apr 27 2016

Cc: -jochen@chromium.org brettw@chromium.org hablich@chromium.org
Owner: ----
Status: Available (was: Assigned)
The CL reverts an incorrect change to GN compile flags
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, May 7 2016

Mergedinto: 606760
Status: Duplicate (was: Available)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Add field trial testing config for MojoChannel
Author  : rockot
Commit description:
  
R=asvitkine@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1918583002

Cr-Commit-Position: refs/heads/master@{#389497}
Commit  : bf36f2d46f43eff11f56ea205615f092801b1004
Date    : Mon Apr 25 16:47:03 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev    N  Good?
chromium@389410  1.91977  0.24186    8  good
chromium@389482  1.95536  0.215951   8  good
chromium@389491  1.97717  0.176492   8  good
chromium@389496  2.0688   0.0999698  8  good
chromium@389497  2.3435   0.0941019  5  bad    <--
chromium@389498  2.42233  0.0897959  5  bad
chromium@389500  2.37993  0.142621   5  bad
chromium@389518  2.35476  0.149646   5  bad
chromium@389553  2.34218  0.218542   8  bad

Bisect job ran on: android_nexus5_perf_bisect
Bug ID: 606762

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.key_mobile_sites_smooth
Test Metric: thread_IO_cpu_time_per_frame/http___cuteoverload.com
Relative Change: 17.41%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/3672
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013373701747087536


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5815816398831616

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
►

Sign in to add a comment