build/config/android/BUILD.gn adds ldflag -Wl,--icf=all which overrides the setting in top level BUILD.gn |
|||
Issue descriptionIn trying to repo issue 605494 I discovered that build/config/android/BUILD.gn adds the ldflag -Wl,--icf=all, however the toplevel BUILD.gn file adds ldflag -Wl,--icf=none. Since both these flags get added to the linker command, the resultant direction depends on which flag gets added to the command last (in the current case "-Wl,--icf=all" seems to win).
,
Apr 26 2016
Chrome for Android. And by toplevel, I actually meant build/config/compiler/BUILD.gn, which adds ldflag "-Wl,--icf=none", while build/config/android/BUILD.gn adds "-Wl,--icf=all" (unless use_order_profiling is true).
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f484bfda36d849c474922639f94eaf12d785d04 commit 0f484bfda36d849c474922639f94eaf12d785d04 Author: agrieve <agrieve@chromium.org> Date: Thu May 12 21:12:44 2016 Merge android's use_gold settings with the main use_gold GN arg logic This also fixes Android settin -Wl,--icf=all in a different spot. BUG= 606749 Review-Url: https://codereview.chromium.org/1972183003 Cr-Commit-Position: refs/heads/master@{#393355} [modify] https://crrev.com/0f484bfda36d849c474922639f94eaf12d785d04/build/config/android/BUILD.gn [modify] https://crrev.com/0f484bfda36d849c474922639f94eaf12d785d04/build/config/compiler/BUILD.gn [modify] https://crrev.com/0f484bfda36d849c474922639f94eaf12d785d04/build/config/compiler/compiler.gni [modify] https://crrev.com/0f484bfda36d849c474922639f94eaf12d785d04/build/config/gcc/BUILD.gn
,
May 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0f86c9c79b888051c81609f496fe7b598dc4e51 commit e0f86c9c79b888051c81609f496fe7b598dc4e51 Author: mlliu <mlliu@chromium.org> Date: Sat May 14 20:26:19 2016 Revert of
,
May 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/665f2abb04029e72a8852a2ecb0959031272ff25 commit 665f2abb04029e72a8852a2ecb0959031272ff25 Author: dpranke <dpranke@chromium.org> Date: Sun May 15 01:24:13 2016 Make x86 linux use gold by default again after android revert. The revert of the Android gold change in r393738 also partially reverted the change to using gold on x86 linux in r393645. This CL re-lands the x86 linux part. TBR=mlliu@chromium.org BUG= 590004 , 611618, 606749 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_compile_dbg_32_ng,linux_chromium_dbg_32_ng Review-Url: https://codereview.chromium.org/1985503002 Cr-Commit-Position: refs/heads/master@{#393759} [modify] https://crrev.com/665f2abb04029e72a8852a2ecb0959031272ff25/build/config/compiler/BUILD.gn
,
May 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10371eae8d24d0ea7efa880571d51d62ce8f197c commit 10371eae8d24d0ea7efa880571d51d62ce8f197c Author: agrieve <agrieve@chromium.org> Date: Thu May 19 03:34:51 2016 Reland of Merge android's use_gold settings with the main use_gold GN arg logic This also fixes Android setting -Wl,--icf=all in a different spot. Reason for reland: Removed --icf=safe for x86 BUG= 606749 , 576197 ,611668 Review-Url: https://codereview.chromium.org/1996433002 Cr-Commit-Position: refs/heads/master@{#394655} [modify] https://crrev.com/10371eae8d24d0ea7efa880571d51d62ce8f197c/build/config/android/BUILD.gn [modify] https://crrev.com/10371eae8d24d0ea7efa880571d51d62ce8f197c/build/config/compiler/BUILD.gn [modify] https://crrev.com/10371eae8d24d0ea7efa880571d51d62ce8f197c/build/config/compiler/compiler.gni [modify] https://crrev.com/10371eae8d24d0ea7efa880571d51d62ce8f197c/build/config/gcc/BUILD.gn
,
May 27 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by brettw@chromium.org
, Apr 26 2016