New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606729 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Warning text for ‘Update failed(error:11) is misplaced.

Reported by dmascare...@etouch.net, Apr 26 2016

Issue description

Chrome Version :52.0.2717.0 (Official Build) 82735e00e98486689f2d6bca470b0ad18d05a985-refs/heads/master@{#389638}
OS: MAC (10.10.5)(10.11.4)

Pre-condition: Change the System date to set it somewhere in the past year (for eg 1.4.15)

What steps will reproduce the problem?
1. Launch chrome, go to chrome://help
2. Observe warning text.

Actual: Warning text for ‘Update failed(error:11) is misplaced.(refer screenshot)
Expected: warning text should not be misplaced.

This is regression issue, broken in ‘M52’ and will soon update the info:

Good Build:52.0.2707.0
Bad build:52.0.2708.0
 
Clock.png
109 KB View Download
Labels: hasbisect
Owner: jsb...@chromium.org
Status: Assigned (was: Unconfirmed)
ChangeLog:
https://chromium.googlesource.com/chromium/src/+log/52.0.2707.0..52.0.2708.0?pretty=fuller&n=10000
(Unable to narrow down the range using tools since issue is not reproducible on chromium builds)

Suspecting: r387138 ?

Kindly help to re-assign, if your changes are not cause for this issue.

Comment 2 by f...@chromium.org, Apr 26 2016

Components: -Security>UX Security
I'm not sure how this got labeled Security UX, it probably needs a new component.

However, this does sound interesting to security. Chrome won't update if the system date is too far off??

Comment 3 by f...@chromium.org, Apr 26 2016

Cc: mab@chromium.org
+mab for his potential interest in clock things

Comment 4 by jsb...@chromium.org, Apr 26 2016

Not my change.

This is only about the visual appearance of the "chrome://help" page, right?

Comment 5 by jsb...@chromium.org, Apr 26 2016

@felt: HTTPS connections tend to fail if your system clock is skewed - guessing it's a symptom of that? (But should be another issue.)

Comment 6 by jsb...@chromium.org, Apr 26 2016

Cc: malaykeshav@chromium.org
Owner: ryanmyers@chromium.org
ryanmyers@ - it looks like you're at least familiar with this code and recently added the error message display (https://codereview.chromium.org/1769703002) - any idea what might be up with the layout here?

Owner: borisv@chromium.org
Sorry, I get a HTTP 500 when I try to view the image, so I can't see what the issue is.  Reassigning to borisv, who now owns this code (I'm no longer working on Chrome).
Okay, the 500 is passing now.  It looks like a CSS issue -- the <pre> tag containing the detailed error message is wide enough that the icon is getting pushed to the side, because it's an inline-block instead of a float + clear.  The CSS for it (from src/chrome/browser/resources/help/help_content.css):

.help-page-icon {
  background-position: center;
  background-repeat: no-repeat;
  display: inline-block;
  height: 18px;
  vertical-align: middle;
  width: 18px;
}

Tweaking the CSS for the output -- either by changing help-page-icon, or by tweaking version_updater_mac.mm to put an inline style in the <pre> tag, should fix it.  In any case, it's a purely visual issue, not a functionality one.

Comment 9 Deleted

Project Member

Comment 10 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, Jul 12 2016

Labels: -M-53 -Pri-1 M-54 MovedFrom-53 Pri-2
This issue is Pri-1 but has already been moved once. Lowering the priority and moving to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Assigned)
Above issue is not reproducible on Latest Canary Version:55.0.2878.0 (Official Build) 6bf82374fb3a17659851bc4e830c063577ba80fd-refs/heads/master@{#422326}

Sign in to add a comment