Issue metadata
Sign in to add a comment
|
Regression: Warning text for ‘Update failed(error:11) is misplaced.
Reported by
dmascare...@etouch.net,
Apr 26 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version :52.0.2717.0 (Official Build) 82735e00e98486689f2d6bca470b0ad18d05a985-refs/heads/master@{#389638} OS: MAC (10.10.5)(10.11.4) Pre-condition: Change the System date to set it somewhere in the past year (for eg 1.4.15) What steps will reproduce the problem? 1. Launch chrome, go to chrome://help 2. Observe warning text. Actual: Warning text for ‘Update failed(error:11) is misplaced.(refer screenshot) Expected: warning text should not be misplaced. This is regression issue, broken in ‘M52’ and will soon update the info: Good Build:52.0.2707.0 Bad build:52.0.2708.0
,
Apr 26 2016
I'm not sure how this got labeled Security UX, it probably needs a new component. However, this does sound interesting to security. Chrome won't update if the system date is too far off??
,
Apr 26 2016
+mab for his potential interest in clock things
,
Apr 26 2016
Not my change. This is only about the visual appearance of the "chrome://help" page, right?
,
Apr 26 2016
@felt: HTTPS connections tend to fail if your system clock is skewed - guessing it's a symptom of that? (But should be another issue.)
,
Apr 26 2016
ryanmyers@ - it looks like you're at least familiar with this code and recently added the error message display (https://codereview.chromium.org/1769703002) - any idea what might be up with the layout here?
,
Apr 26 2016
Sorry, I get a HTTP 500 when I try to view the image, so I can't see what the issue is. Reassigning to borisv, who now owns this code (I'm no longer working on Chrome).
,
Apr 26 2016
Okay, the 500 is passing now. It looks like a CSS issue -- the <pre> tag containing the detailed error message is wide enough that the icon is getting pushed to the side, because it's an inline-block instead of a float + clear. The CSS for it (from src/chrome/browser/resources/help/help_content.css):
.help-page-icon {
background-position: center;
background-repeat: no-repeat;
display: inline-block;
height: 18px;
vertical-align: middle;
width: 18px;
}
Tweaking the CSS for the output -- either by changing help-page-icon, or by tweaking version_updater_mac.mm to put an inline style in the <pre> tag, should fix it. In any case, it's a purely visual issue, not a functionality one.
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 12 2016
This issue is Pri-1 but has already been moved once. Lowering the priority and moving to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 3 2016
Above issue is not reproducible on Latest Canary Version:55.0.2878.0 (Official Build) 6bf82374fb3a17659851bc4e830c063577ba80fd-refs/heads/master@{#422326} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dmascare...@etouch.net
, Apr 26 2016Owner: jsb...@chromium.org
Status: Assigned (was: Unconfirmed)