New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 606722 link

Starred by 1 user
Status: Fixed
Owner:
█ zqzh...@chromium.org
Android MediaRouter only (left Chro...
Closed: Apr 2016
Cc:
█ avayvod@chromium.org
mlamouri@chromium.org
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
tguilbert@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Remote playback stops instantly when pause from ExpandedControllerActivity

Project Member Reported by zqzh...@chromium.org, Apr 26 2016 
1) Open videojs.com, play and cast the video;
2) Click the media notification, ExpandedControllerActivity will show up;
3) Click pause

Observed behavior:
The remote video playback stops immediately

Desired behavior
The remote video playback pauses

The issue is caused by a timestamp issue in the GMS core, which uses uptimeMillis instead of elapsedRealtime
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4b8069a230bc157f020ffaab138887a2bd63dd4

commit d4b8069a230bc157f020ffaab138887a2bd63dd4
Author: zqzhang <zqzhang@chromium.org>
Date: Tue Apr 26 13:48:27 2016

[MediaFling] Fix timestamp issue in remote media playback

This CL fixes a bug caused by the MediaItemStatus timestamp
inconsistency between the GMS core CastMediaRouteProvider and
PositionExtrapolator. The timestamp from the GMS core is overridden by
the elapsedRealtime.

BUG= 606722 
TEST=manual test on multiple devices

Review URL: https://codereview.chromium.org/1922093002

Cr-Commit-Position: refs/heads/master@{#389772}

[modify] https://crrev.com/d4b8069a230bc157f020ffaab138887a2bd63dd4/chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java

Comment 2 by zqzh...@chromium.org, Apr 26 2016

Labels: Merge-Request-51

Comment 3 by tin...@google.com, Apr 26 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aed4fb430380852f5f2533ec9997af15eba550f9

commit aed4fb430380852f5f2533ec9997af15eba550f9
Author: Zhiqiang Zhang <zqzhang@google.com>
Date: Tue Apr 26 14:22:26 2016

[MediaFling] Fix timestamp issue in remote media playback

This CL fixes a bug caused by the MediaItemStatus timestamp
inconsistency between the GMS core CastMediaRouteProvider and
PositionExtrapolator. The timestamp from the GMS core is overridden by
the elapsedRealtime.

BUG= 606722 
TEST=manual test on multiple devices

Review URL: https://codereview.chromium.org/1922093002

Cr-Commit-Position: refs/heads/master@{#389772}
(cherry picked from commit d4b8069a230bc157f020ffaab138887a2bd63dd4)

Review URL: https://codereview.chromium.org/1921993003 .

Cr-Commit-Position: refs/branch-heads/2704@{#246}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/aed4fb430380852f5f2533ec9997af15eba550f9/chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java

Comment 5 by zqzh...@chromium.org, Apr 26 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment