New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 606707 link

Starred by 5 users

Issue metadata

Status: Duplicate
Merged: issue 425368
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Switch stream operations in Chrome audio rendering from IPC to Mojo

Reported by rchtara@chromium.org, Apr 26 2016

Issue description

This replaces all audio stream operations (creation, closing, playing, pausing..) to use  Mojo instead of IPC. 

* A few Mojo interfaces and AudioOuputClient and AudioOutputImpl that implement the Mojo client and service will be added.
* A Mojo client and service will be initialized in the renderer and the browser. 
* AudioRendererHost and AudioMessageFilter are going to be removed and the logic inside them will be moved to AudioOuputClient and AudioOutputImpl.
* The browser and the renderer are going to get updated to use Mojo instead of IPC.

 
Cc: grunell@chromium.org tommi@chromium.org olka@chromium.org jansson@chromium.org tnakamura@chromium.org kjellander@chromium.org dalecur...@chromium.org henrika@chromium.org
Labels: -Type-Bug -Pri-3 M-52 OS-All Pri-1 Type-Feature
Owner: rchtara@chromium.org
Status: Started (was: Untriaged)
Components: Internals>Media>Audio
The plan for the Mojofication of audio rendering project is the following :
1) Create Mojo interfaces needed for switching audio rendering stream creation
and closing from IPC to Mojo.
2) Switch stream creation and closing in Chrome audio rendering from IPC to
Mojo.
3) Switch all other stream operations (request device authorization, play,
setVolume, pause) from IPC to Mojo.
4) Refactor: merge audio_renderer_host.cc and audio_output_impl.cc and merge
audio_message_filter.cc and audio_output_client.cc. Remove the stream_id for the
Createstream arguments.
Project Member

Comment 4 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78870627c0044f56533da4746e4b3231d04d87f1

commit 78870627c0044f56533da4746e4b3231d04d87f1
Author: rchtara <rchtara@chromium.org>
Date: Fri May 13 16:15:08 2016

Mojo interfaces needed for switching audio rendering stream
creation and closing from IPC to Mojo

This adds:
 * AudioOutput which allows managing audio output streams.
 * AudioOutputStream which handles audio output stream operations.
 * Type mapping for AudioParameters.
This is the media part: The content part is in the CL http://codereview.chromium.org/1930393002

BUG= 606707 

Review-Url: https://codereview.chromium.org/1896883002
Cr-Commit-Position: refs/heads/master@{#393537}

[modify] https://crrev.com/78870627c0044f56533da4746e4b3231d04d87f1/media/mojo/interfaces/BUILD.gn
[add] https://crrev.com/78870627c0044f56533da4746e4b3231d04d87f1/media/mojo/interfaces/audio_output.mojom
[add] https://crrev.com/78870627c0044f56533da4746e4b3231d04d87f1/media/mojo/interfaces/audio_parameters.mojom
[add] https://crrev.com/78870627c0044f56533da4746e4b3231d04d87f1/media/mojo/interfaces/audio_parameters.typemap
[modify] https://crrev.com/78870627c0044f56533da4746e4b3231d04d87f1/media/mojo/interfaces/mojo_bindings.gyp
[add] https://crrev.com/78870627c0044f56533da4746e4b3231d04d87f1/media/mojo/interfaces/typemaps.gni
[modify] https://crrev.com/78870627c0044f56533da4746e4b3231d04d87f1/mojo/public/tools/bindings/chromium_bindings_configuration.gni

Project Member

Comment 5 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -grunell@chromium.org
Labels: -Pri-1 -M-53 -MovedFrom-52 Pri-3
Owner: grunell@chromium.org
This work is currently on hold. It's planned to be continued in August or September.

A CL in progress for introducing the Mojo service and client, the stream representation object, and to switch create and close stream operations to Mojo: https://codereview.chromium.org/1930393002/
Cc: grunell@chromium.org
Owner: maxmorin@chromium.org
maxmorin@ has continued working on this.
Mergedinto: 425368
Status: Duplicate (was: Started)
This is tracked as part of a larger effort in 425368.

Sign in to add a comment