This also broke the unittests in content/test/gpu, breaking the ability to commit changes to src/content/test/gpu/ . https://codereview.chromium.org/1917093003/ was just kicked out of the CQ because of this:

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

Pylint (48 files using ['--disable=all', '--enable=cyclic-import']) (2.08s)

('run_content_test_gpu_unittests',) (22.11s)

** Presubmit ERRORS **
Pylint (48 files using ['--disable=cyclic-import'] on 8 cores) (2.44s) failed
************* Module gpu_tests.gpu_rasterization
E: 45,12: Module 'telemetry.page.page_test' has no 'Failure' member (no-member)


Ned, please change the Catapult auto-roll scripts to run src/content/test/gpu/run_unittests.py .

https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/173187 was the failing CQ job. stdout attached.

Deleted: stdout.txt 13.0 KB

stdout.txt 13.0 KB View Download

I've stopped the Catapult auto-rolls at https://catapult-roll.skia.org/ and am rolling it back to a version that works with the GPU tests.

I reverted the most recent catapult roll in https://codereview.chromium.org/1921223002/ and that allowed a WebGL failure suppression https://codereview.chromium.org/1917093003/ to be submitted.

Downgrading to P2. Must be fixed before Catapult rolls can resume.

I found out what went wrong here:
* content/test/gpu/run_unittests.py is still passing with this breaking change because there is no unittest coverage that touch page_test.Failure
* pylint in content/test/gpu/PRESUBMIT.py is failing because it detects that telemetry.page.page_test has no Failure member.

So this comes back to the bug of gpu PRESUBMIT is not kicked off upon catapult roll. 

I think I will cheat & add a gpu unittest that kick off content/test/gpu presubmit. Chatted witk kbr@ offline and he seems ok with this.

I verify manually that with https://codereview.chromium.org/1917173002, the gpu gpu PRESUBMIT is no longer failing. I enabled the catapult autoroll again.

File a different bug about how to run PRESUBMIT of projects depending on catapult/ upon catapult roll.

 Issue 606855  is about triggering the PRESUBMIT of projects depending on catapult/ upon catapult roll.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26ef26441a318284b93d7522239aa2ae29e38597

commit 26ef26441a318284b93d7522239aa2ae29e38597
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Tue Apr 26 20:22:02 2016

Roll src/third_party/catapult/ 89ac5c3cc..7744caa3a (9 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/89ac5c3cccf7..7744caa3a0f0

$ git log 89ac5c3cc..7744caa3a --date=short --no-merges --format='%ad %ae %s'

BUG=605972, 606052 , 606706 

TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1923583002

Cr-Commit-Position: refs/heads/master@{#389872}

[modify] https://crrev.com/26ef26441a318284b93d7522239aa2ae29e38597/DEPS