New issue
Advanced search Search tips

Issue 606705 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 671916


Participants' hotlists:
MacViews-Task-Queue


Sign in to add a comment

RenderTextMac renders zero-width spaces with gunk on it

Project Member Reported by tapted@chromium.org, Apr 26 2016

Issue description

Chrome Version       : 51.0.2704.19
OS Version: OS X 10.11.4

Run RenderTextTest.Multiline_ZeroWidthChars with RenderTextMac instead of RenderTextHarfbuzz. Have it fail.

Draw the text into views_examples's label_example.cc - see gunk.
 
harfbuzz_expected.png
4.3 KB View Download
arial_font.png
4.4 KB View Download
system_font.png
4.9 KB View Download
Cc: e...@chromium.org
Components: Blink>Fonts
Status: Untriaged (was: Available)

Comment 2 by e...@chromium.org, Jul 19 2016

Cc: -e...@chromium.org
Components: -Blink>Fonts UI>Browser
Blink>Fonts is for blink. RenderTextMac and RenderTextHarfbuzz are in the browser process.

Comment 3 by tapted@chromium.org, Jul 22 2016

Labels: Proj-MacViews
Status: Available (was: Untriaged)
This isn't in my queue, but I'll take it if it blocks me elsewhere.
sample_2017-03-16_16-46-23.png
36.6 KB View Download

Comment 5 by tapted@chromium.org, Mar 21 2017

Blocking: 671916
Labels: phase4
Status: Fixed (was: Available)
Bugdroid didn't come along, but this is probably fixed by r457472 -> https://codereview.chromium.org/2756683002/ . Thanks a ton!

CL details:

"""
Fix text rendering with RenderTextMac.

BUG= 606705 
Glyph 65535 means that the glyph is not printable. 
Replacing it with 0 results in a striped glyph that's
rendered instead of non-printable glyphs. 
Just remove old invalid code to fix this.
In my testing no Skia asserts were triggered.

Without this fix the title in tab of url : 
https://www.google.ru/trends/yis/2016/RU?autoplay=1
will be incorrect rendered:
See https://bugs.chromium.org/p/chromium/issues/detail?id=606705#c4

Review-Url: https://codereview.chromium.org/2756683002
Cr-Commit-Position: refs/heads/master@{#457472}
Committed: https://chromium.googlesource.com/chromium/src/+/76ea7030842aa09fbe9675701d7a879243ada736
"""

Sign in to add a comment